summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Refactor security group create to use SDKRichard Theis2016-03-106-166/+217
| | | | | | | | | | | | | | Refactored the 'os security group create' command to use the SDK when neutron is enabled, but continue to use the nova client when nova network is enabled. Added a release note for the change in security group rules output due to Network v2. The tenant_id column name was fixed to align with the 'os security group show' command. Change-Id: Ib29df42edcddcc73a123fff6a64743a6bfcb7fbf Partial-Bug: #1519511 Implements: blueprint neutron-client
* Refactor security group show to use SDKRichard Theis2016-03-109-93/+310
| | | | | | | | | | | | | | Refactored the 'os security group show' command to use the SDK when neutron is enabled, but continue to use the nova client when nova network is enabled. Added a release note for the change in security group rules output due to Network v2. The column names remain unchanged to maintain backwards compatibility. Change-Id: I25233ddb8115d18b8b88affb3de13346084a339d Partial-Bug: #1519511 Implements: blueprint neutron-client
* Merge "Trivial: Use 'SSH' rather than 'Ssh'"Jenkins2016-03-092-2/+2
|\
| * Trivial: Use 'SSH' rather than 'Ssh'Stephen Finucane2016-03-092-2/+2
| | | | | | | | | | | | This is reflected in the '--help' screen. Change-Id: Ic22a65ff6a56b069b37a0ea8365cce2b3f93621c
* | Merge "Remove FakeFlavorResource class"Jenkins2016-03-091-29/+16
|\ \
| * | Remove FakeFlavorResource classTang Chen2016-03-091-29/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | In unit tests, all real methods are faked. They should not do any real operations in the tests. So, FakeFlavorResource is not necessary. Just fake get_keys(), set_keys and unset_keys() in FakeResource would be enough. Change-Id: Icc3473ba9c77f4817d0edddb7ff3e1bd2946fac7
* | | Merge "remove py26 workaround in osc"Jenkins2016-03-091-24/+0
|\ \ \
| * | | remove py26 workaround in oscSteve Martinelli2016-03-081-24/+0
| | | | | | | | | | | | | | | | | | | | | | | | we don't support py2.6, so let's remove the workarounds we have. Change-Id: Id9c8fda065d4aceba3192b044b5c5f2124ee204f
* | | | Merge "Add port functional tests"Jenkins2016-03-091-0/+58
|\ \ \ \ | |_|_|/ |/| | |
| * | | Add port functional testsRichard Theis2016-03-081-0/+58
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | Add functional tests for "os port" commands. Change-Id: I162eff6abacd9ffdde369647491ae472b604c692 Depends-On: I2bea508e11290284aa64b1ab548a0bb61e7290d3 Partial-Bug: #1519909 Partially-Implements: blueprint neutron-client
* | | Merge "[Identity] Check return value is None in identity v3 unit tests"Jenkins2016-03-096-15/+28
|\ \ \
| * | | [Identity] Check return value is None in identity v3 unit testsTang Chen2016-03-096-15/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | take_action() in commands inheriting from Command returns nothing. So we should assert the return is None in the unit tests of these commands. Change-Id: I53eeb88316b2c20882fed97149d55cb04bcb2b2e Closes-Bug: #1550636
* | | | Merge "Add --reason for disable service"Jenkins2016-03-094-9/+54
|\ \ \ \ | |/ / / |/| | |
| * | | Add --reason for disable servicejichenjc2016-03-094-9/+54
| | | | | | | | | | | | | | | | | | | | | | | | | | | | disbale service allow a reason to be input as disable reason. This patch add support for it. Change-Id: I59622c3970e055ebd46bf03c33c864b6d064db28
* | | | Add 'port set' commandJas2016-03-085-5/+194
| |/ / |/| | | | | | | | | | | | | | | | | | | | Add CLI support for the 'port set' command Change-Id: I2bea508e11290284aa64b1ab548a0bb61e7290d3 Partial-bug: #1519909 Partially-implements: blueprint neutron-client
* | | Merge "Trivial: Fix incorrect comments in compute fakes.py"Jenkins2016-03-081-3/+3
|\ \ \ | |_|/ |/| |
| * | Trivial: Fix incorrect comments in compute fakes.pyTang Chen2016-03-081-3/+3
| | | | | | | | | | | | Change-Id: I18b1720af13b444527dda1ecab52e3cc8d8d9376
* | | [Identity] Check return value is None in identity v3 unit testsTang Chen2016-03-089-30/+64
|/ / | | | | | | | | | | | | | | | | take_action() in commands inheriting from Command returns nothing. So we should assert the return is None in the unit tests of these commands. Change-Id: I02af06b3d476aac2d93a23ef2111cdc7fa0892ec Partial-Bug: #1550636
* | Merge "Add port list command"Jenkins2016-03-085-0/+90
|\ \
| * | Add port list commandJas2016-03-075-0/+90
| | | | | | | | | | | | | | | | | | | | | | | | This patch adds the ability to list all created ports Change-Id: Ie1a48c203cabc96346a4950f21b83493d58a66a5 Partial-bug: #1519909 Partially-implements: blueprint neutron-client
* | | Merge "Use _get_columns() to obtain columns in network.py"Jenkins2016-03-071-4/+4
|\ \ \
| * | | Use _get_columns() to obtain columns in network.pyTang Chen2016-03-061-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Objects returned by Network v2 and Compute v2 are different. When getting columns to display, Network v2 uses obj.keys(), while Compute v2 uses obj._info.keys(). But both of them could obtain the keys of the object by _get_columns(). Change-Id: I347815f2d28822a95bd6f57d429b84b7ca96e0ee
* | | | Merge "Test take_action() instead of run() in unit tests"Jenkins2016-03-0711-101/+107
|\ \ \ \ | |_|/ / |/| | |
| * | | Test take_action() instead of run() in unit testsTang Chen2016-03-0511-101/+107
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some of the unit tests test run(), but not take_action(). For example, in openstackclient/tests/volume/v1/test_volume.py, there is: def test_volume_set_size_smaller(self): ...... result = self.cmd.run(parsed_args) self.assertEqual(0, result) ...... run() is defined in class Command in cliff. We don't need to test it in OSC unit tests. On the contrary, we should test take_action(), which is overwritten in each command classes in OSC. Change-Id: If07e89953d40ac530f08cbb1ec05f5805171364b Closes-bug: #1553468
* | | | Trivial: Remove useless returnTang Chen2016-03-079-13/+0
| | | | | | | | | | | | | | | | | | | | | | | | If a function returns nothing, do not add return in the end. Change-Id: I298b8717462f68d3076a1619d674775be2a94c42
* | | | Merge "Add release note for security group set refactor"Jenkins2016-03-061-2/+5
|\ \ \ \
| * | | | Add release note for security group set refactorRichard Theis2016-03-051-2/+5
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a release note for [1]. [1] https://review.openstack.org/#/c/287763/ Change-Id: I30812c3ead477267dc7e3dc774c09b3435152eb9 Partial-Bug: #1519511 Implements: blueprint neutron-client
* | | | Merge "" openstack server image create " doesn't print proper info"Jenkins2016-03-061-5/+19
|\ \ \ \ | |/ / / |/| | |
| * | | " openstack server image create " doesn't print proper infoMohan Muppidi2016-03-031-5/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | After creating a snapshot of a running instance, a print out similar to server create is expected, but it prints out something like "_info" which is nothing related to created image. _prep_image_detail method is added to /compute/v2/server.py to enable the priting, while running the test properly. Change-Id: I4b06be959768bcdaafd9aa8df497490958bee649 Closes-Bug:1551586
* | | | Merge "Refactor security group set to use SDK"Jenkins2016-03-054-42/+190
|\ \ \ \ | |_|/ / |/| | |
| * | | Refactor security group set to use SDKRichard Theis2016-03-034-42/+190
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Refactored the 'os security group set' command to use the SDK when neutron is enabled, but continue to use the nova client when nova network is enabled. This patch set also fixes a compute bug which ignores name and description when set to an empty value. Change-Id: I4225179dca4aedf799e1656ec49236bdedc5e9bd Partial-Bug: #1519511 Implements: blueprint neutron-client
* | | Merge "[compute] Support restore server"Jenkins2016-03-046-1/+63
|\ \ \
| * | | [compute] Support restore serverjichenjc2016-02-236-1/+63
| | | | | | | | | | | | | | | | | | | | | | | | Server in soft-delete state can be restored, add this command. Change-Id: Id9d7246f89ae65273505f36dcb664996534ae986
* | | | Merge "Add 'port create' command"Jenkins2016-03-045-53/+400
|\ \ \ \
| * | | | Add 'port create' commandJas2016-03-045-53/+400
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch adds usage of 'port create' in CLI Change-Id: I888af50784c3b6c7ec30552ade79f05a5e974711 Partial-bug: #1519909 Partially-implements: blueprint neutron-client
* | | | | Merge "[compute] Add unit test for keypair"Jenkins2016-03-043-1/+318
|\ \ \ \ \
| * | | | | [compute] Add unit test for keypairjichenjc2016-02-233-1/+318
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | keypair do not have unit test, this patch adds it. Change-Id: Id702ccaad239b916340bb17014d1ede0a28aaec9
* | | | | | Updated from global requirementsOpenStack Proposal Bot2016-03-041-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Change-Id: Ife3956a1109ffa2faf367953cc13b8cb5f64e5c2
* | | | | | Merge "[Volume] Check return value is None in volume unit tests"Jenkins2016-03-047-46/+84
|\ \ \ \ \ \
| * | | | | | [Volume] Check return value is None in volume unit testsTang Chen2016-03-037-46/+84
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | take_action() in commands inheriting from Command returns nothing. So we should assert the return is None in the unit tests of these commands. Change-Id: Idd961a5fa3db825353700837a559621d17f782c5 Partial-Bug: #1550636
* | | | | | | Updated from global requirementsOpenStack Proposal Bot2016-03-041-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I8bfe67141572a0bf406959dea83eaf1f2c30b890
* | | | | | | Merge "Add test cases to test some commands with '--wait' and fix bug"Jenkins2016-03-042-2/+190
|\ \ \ \ \ \ \
| * | | | | | | Add test cases to test some commands with '--wait' and fix bugting.wang2016-03-022-2/+190
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | "server image create" "server rebuild" "server resize" Above 3 commands are not covered by unit test. So add some unit tests. Meanwhile, fix bug. Now that image name is an optional argument, we'd better record error messages with positional arguments instead of optional argument. So, record server name. Change-Id: I41bc025d4824dc46f63a3213d82e1528bacbbe12
* | | | | | | | Updated from global requirementsOpenStack Proposal Bot2016-03-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I49cfc47d791d890941dc199bd0d5fa0205b1f1ca
* | | | | | | | Merge "Fix incorrect unit test for router"Jenkins2016-03-033-10/+18
|\ \ \ \ \ \ \ \
| * | | | | | | | Fix incorrect unit test for routerTang Chen2016-03-033-10/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Command "router show" will display router's "tenant_id" as "project_id". But in the unit test, it checks "tenant_id", which is incorrect. This patch fix this problem, and add a _get_columns() helper function to simplify the code. Change-Id: I0087ef7dfd0130b6c47222495848c4f2b9804b1b
* | | | | | | | | Fix test_aggregate functional test2.2.0Richard Theis2016-03-031-1/+4
| |_|/ / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Nova API validation changes [1] appear to have broken the 'os aggregate create' and 'nova aggregate-create' commands when an availability zone name is not specified. This patch set updates the test_aggregate functional test to set the availability zone name in order to unblock the osc gate while nova investigates the issue. [1] https://review.openstack.org/#/c/281143/ Change-Id: I00b497be61c4bc4bc467c66c1e49b2e0636ab841 Related-Bug: #1541691
* | | | | | | | Merge "Trivial: Reorder unit tests in alphabetical order in volume tests"Jenkins2016-03-032-165/+165
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | |
| * | | | | | | Trivial: Reorder unit tests in alphabetical order in volume testsTang Chen2016-03-022-165/+165
| | |_|_|_|/ / | |/| | | | | | | | | | | | | | | | | | | Change-Id: I622123f68e2bb53f8767069e4a717fcc34e37b5c
* | | | | | | Updated from global requirementsOpenStack Proposal Bot2016-03-021-1/+1
| |_|_|/ / / |/| | | | | | | | | | | | | | | | | Change-Id: Icc45c24eebbdd524254dc3200b016fe75b621b15
View Lorry Controller Status