summaryrefslogtreecommitdiff
path: root/openstackclient/api
Commit message (Collapse)AuthorAgeFilesLines
* Merge "Make container list --all work"Zuul2020-06-091-6/+6
|\
| * Make container list --all workPete Zaitcev2020-05-161-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The caller in openstackclient/object/v1/object.py passed a keyword argument full_listing, but the eventual callee container_list() expected all_data. So, --all did not work at all. The issue passed undetected because --all did not have a test, so we added a unit test. In addition, exisiting tests were using a test set that did not look like the real container listing, so we changed LIST_CONTAINER_RESP to be realistic. Change-Id: Id0604bcab25892e43c26cd6656b2b2eef5daa69b
* | Cleanup: remove a useless reference to "object"Pete Zaitcev2020-05-151-1/+1
|/ | | | | | | The method "object_list" does not have an argument "object", so we were using a built-in class "object" by mistake. Change-Id: I74687659223d31d3c3c119eee5874edff30634fd
* Add storage policy option to create container commandSimon Merrick2020-02-191-2/+25
| | | | | | | | + Add CLI option to specify swift storage policy + Add CLI flag to specify container uses public read ACLS + Show storage policy in container show data Change-Id: I08ffa0d98bd39d467aa415771675f59bd77768ff
* Raise flake8-import-order version to latestSean McGinnis2020-01-101-2/+1
| | | | | | | | | | | We had this library capped at a release that is a few years old. Now that we have dropped py2 testing, we can pick up the latest version. This uncovered a few things to clean up. Mostly the fact that mock is now a part of the StdLib unittest since Python 3.3. Change-Id: I27484dd4c25378413ff16e97a35a1a46062357bc Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
* Replace six.iteritems() with .items()lihaijing2020-01-091-3/+2
| | | | | | | | | | | | | | | | 1. As mentioned in [1], we should avoid using six.iteritems to achieve iterators. We can use dict.items instead, as it will return iterators in PY3 as well. And dict.items/keys will more readable. 2. In py2, the performance about list should be negligible, see the link [2]. [1] https://wiki.openstack.org/wiki/Python3 [2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html Co-Authored-By: Akihiro Motoki <amotoki@gmail.com> Change-Id: I4b9edb326444264c0f6c4ad281acaac356a07e85 Implements: blueprint replace-iteritems-with-items
* Remove token_endpoint auth typeDean Troyer2019-08-271-61/+0
| | | | | | | | | | | The token_endpoint was a compatibility auth type to maintain support for the --url global option that dated back to the beginning of OpenStack CLI auth. The common keystoneauth library implements 'admin_token' which provides the same functionality using --endpoint rather than --url. Change-Id: I1b9fbb96e447889a41b705324725a2ffc8ecfd9f Signed-off-by: Dean Troyer <dtroyer@gmail.com>
* Update api-ref locationAndreas Jaeger2019-07-221-19/+19
| | | | | | | | | | | | | | The api documentation is now published on docs.openstack.org instead of developer.openstack.org. Update all links that are changed to the new location. Note that redirects will be set up as well but let's point now to the new location. For details, see: http://lists.openstack.org/pipermail/openstack-discuss/2019-July/007828.html Change-Id: I1572a21632740b4d9a233a6a31c49e3bac5394ef
* Remove code migrated to osc-lib long agoDean Troyer2019-05-161-84/+0
| | | | | | | | | * Remove openstackclient.api.utils and use osc_lib.api.utils * Remove openstackclient.common.clientmanager.ClientManager.auth_ref * Remove openstackclient.common.commandmanager Change-Id: I67e1dbc53cc0b37967c0011bcb2fc09bdef62d94 Signed-off-by: Dean Troyer <dtroyer@gmail.com>
* Before writing object data to stdout, re-open it in binary modeTim Burke2019-04-101-2/+3
| | | | | | | Otherwise, you can hit TypeErrors on Python3. Change-Id: I9a891508886feddac3982ce593bd95130392e035 Closes-Bug: 1775482
* Merge "trivial: remove commented-out code"Zuul2018-12-301-2/+0
|\
| * trivial: remove commented-out codeChen2018-09-281-2/+0
| | | | | | | | | | | | | | These comments have existed from the beginning. But they seem to be meaningless. Change-Id: Ic38272ecfb321d77219d477634e9e29b968e7f00
* | Fix i18n issueliuyamin2018-11-131-1/+1
|/ | | | | | This patch fix some i18n issues in the files vapi/compute_v2.py. Change-Id: Ic4da472ca585a35ce64512cf0e72e2fe9d4c9d6e
* Support --community in openstack image listNobuto Murata2018-07-241-6/+11
| | | | | | | | | "--community" was added to "image create" and "image set" previously, but was missed in "image list". Change-Id: I959fdd7f67ae62c8326659ce52389228152ec019 Story: 2001925 Task: 14453
* Re-implement novaclient bits removed in 10.0Dean Troyer2018-03-131-1/+155
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | a) /os-floating-ips was removed in Compute API 2.36 and from novaclient's Python API in 10.0 Add to api.computev2: floating_ip_add() floating_ip_remove() Convert add floating IP command to nova-net/neutron split: "server add floating ip" "server remove floating ip" b) /os-hosts was removed in Compute API 2.43 and from novaclient's Python API in 10.0. Add to api.computev2: host_list() host_set() host_show() Convert host commands to use intenal api: "host list" "host set" "host show" c) The introduction of the Network-style commands into the server group broke cliff's autoprogram directive as it executes the get_parser() methods without fully initializing the Command object. NOTE: This is really three reviews squashed to get through the gate in one pass. Depends-on: Id6de87211d6c4ea8fd14aa9203d8d5b17e9e2f04 Change-Id: I5116086f9a9e4b2b31a744bf8f4558c79f0bfe59
* Remove a bunch of things we promised to remove in 2H 2017Dean Troyer2017-11-301-28/+0
| | | | Change-Id: I060559fe13e354fe87551cd9dd82774bddb54640
* Allow objects to be streamed to stdoutHonza Pokorny2017-07-051-5/+10
| | | | Change-Id: Icd8de6b2122fe77926d93da9bda08f56c3672a7a
* Trivial fix typosVu Cong Tuan2017-05-301-1/+1
| | | | Change-Id: I72a1da209df38e226ec02d9dbd0142ed4020c0d2
* Fix Nova-net netowrk commandsDean Troyer2017-04-271-11/+12
| | | | | | | | | | | | In cleaning up functional tests for nova-net, I discovered some problems in network create: * --subnet option is required in network create command * Switch API to use /os-networks rather than /os-tenant-networks as this is what we were actually using via novaclient * Fix functional tests for nova-net * Normalize some private function names in network/v2/network.py Change-Id: I426b864406756d58d140575a3a45ee9aee67ce84
* Low-level Compute v2 API: floating ip poolDean Troyer2017-04-181-1/+18
| | | | | | | | | | | | | api.compute.APIv2 floating ip pool function. novaclient 8.0 is now released without support for the previously deprecated nova-net functions, so include a new low-level REST implementation of the removed APIs. Also includes a handful of cleanups that the previous security group and floating IP reviews missed. Change-Id: I20116ec4fc1113857d8d917bfb30fa3170d05b9f
* Low-level Compute v2 API: networkDean Troyer2017-04-171-0/+94
| | | | | | | | | | api.compute.APIv2 network functions. novaclient 8.0 is now released without support for the previously deprecated nova-net functions, so include a new low-level REST implementation of the removed APIs. Change-Id: If230f128e91cda44461fe93c976cac2aecec2252
* Merge "Low-level Compute v2 API: floating ip"Jenkins2017-04-171-0/+82
|\
| * Low-level Compute v2 API: floating ipDean Troyer2017-04-111-0/+82
| | | | | | | | | | | | | | | | | | | | api.compute.APIv2 floating ip functions. novaclient 8.0 is now released without support for the previously deprecated nova-net functions, so include a new low-level REST implementation of the removed APIs. Change-Id: Ic461b8d15e072e0534dcd73fff6857581d83c89b
* | Low-level Compute v2 API: security group rulesDean Troyer2017-04-111-0/+97
|/ | | | | | | | | | api.compute.APIv2 security group rule functions. novaclient 8.0 is now released without support for the previously deprecated nova-net functions, so include a new low-level REST implementation of the removed APIs. Change-Id: Ieabd61113bc6d3562738686f52bb06aa84fca765
* Low-level Compute v2 API: security groupDean Troyer2017-04-111-0/+211
| | | | | | | | | | api.compute.APIv2 starts with security group functions. novaclient 8.0 is now released without support for the previously deprecated nova-net functions, so include a new low-level REST implementation of the removed APIs. Change-Id: Id007535f0598226a8202716232313e37fe6247f9
* Make 'object save' fast againJordan Pittier2017-01-091-1/+1
| | | | | | | | | | | | | 'openstack object save' is critically slow to download big objects. While we 'stream' (chunked download) the data, the default chunks_size is 1 byte [1], which is terribly inefficient. [1] : http://docs.python-requests.org/en/master/api/#requests.Response.iter_content Closes-Bug: 1654645 Change-Id: I2223e5897346acd2f2c1fae638d1193cff833c19
* Fixes image api URL endpoint for certain scenarioImtiaz Chowdhury2017-01-042-6/+6
| | | | | | | | | | | | | | | | | | | openstackclient fails to get image list when the image api endpoint has 'v2' substring in the URL. Instead of checking whether the api endpoint URL terminates with '/v2', the current logic is checking whether 'v2' appears anywhere in the endpoint string. This issue was discovered on a production setup where certain server names had 'v2' in their names. For example, when a hostname is gopher.dev20.com, the image list APIs fail. This commit updates the unit test to reflect this scenario. Without the change in openstackclient/api/image_v2.py, all the unit tests fail. Co-Authored-By: sergio.carvalho@workday.com Change-Id: I26b85afd646938272dbabe8e045b337b7df58c7d Closes-Bug: 1652827
* Add option "--name" to command "openstack object create"Rajasi Kulkarni2016-09-261-2/+9
| | | | | | | | | | | Option "--name" can be used to set as the object name of the file to be uploaded in the container. Similar to option "--object-name" in command "swift upload". Added unit test case to ensure an exception is raised when using option "--name" for uploading multiple objects. Change-Id: Ied7827841f6ca1cf9d4b48e304cbe5d62eda38ab Closes-Bug: #1607972
* Add importing file to import warningsDean Troyer2016-08-301-1/+4
| | | | | | | | Add the Python file doing the import to the warnings emitted by the modules moved to osc-lib. Users will at least have a hint as to which package is out-of-date. Change-Id: I633b440c30b2b15cfde7a9013e30dfa39ab200bc
* Standardize import formatshizhihui2016-07-221-2/+1
| | | | | | | | According to the rule in http://docs.openstack.org/developer/hacking/#imports I modify some irregular import format. Change-Id: Ibf29ccaf3ddec4a956334cc3368ebee7a66e282c
* remove unused LOGji-xuepeng2016-07-091-4/+0
| | | | | | This is to remove unused LOG to keep code clean. Change-Id: Ic544157b19cefb4120381f3314334c60a9020baf
* osc-lib: api.authDean Troyer2016-06-301-222/+8
| | | | | | Move auth plugin checking to osc-lib. Change-Id: I673d9c2d6e8bbf724c3000459a729e831d747814
* Remove OSCGenericPassword pluginDean Troyer2016-06-222-46/+2
| | | | | | | The need for this has passed plus with 3.0 we can take the breakage hit, if any. Change-Id: Ic019842f00033d2cd67b75f036e7e817e4b7c075
* Fix token/endpoint auth pluginDean Troyer2016-06-211-25/+30
| | | | | | | | | | | [This is not quite reduced from the original proposed fix as some changes have merged that complicate the switch to OSC_Config and v2 auth broke anyway.] Fix the --os-token --os-url breakage in the switch to ksa. Closes-bug: 1593664 Change-Id: I3ac23234fbf647fb145c7bd151d53c5c105462bf
* Refactor setting defaults for some scope parametersAlvaro Lopez Garcia2016-06-212-2/+5
| | | | | | | | | | The code is setting defaults for some scope parameters, cheking if the name ends with some specific substring (namely ending in "password") causing failures in some plugins that end with the same string, but do not allow those parameters (like "user_domain_id" in "v3oidcpassword"). Closes-Bug: #1582774 Change-Id: Id7036db3b783b135353d035dc4c1df7c808d6474
* Refactor check_valid_auth_options functionAlvaro Lopez Garcia2016-06-211-22/+21
| | | | | | | | | | | | The functions check_valid_auth_options() function was relying on the name for checking the set of required options, but this could cause errors with external auth plugins. If somebody defines an auth plugin plugin named "footoken" the check function would check for a "token" option, even if the plugin has not defined that option. This change tries to improve this situation, cheking for some options only if they have been defined in the plugin. Change-Id: I4255f2e7d4d23449c95be957ea7b6b60983f2608
* Do not prompt for scope options with default scoped tokensDolph Mathews2016-06-171-18/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | This changes the scope validation to occur after a token has already been created. Previous flow: 1. Validate authentication options. 2. Validate authorization options if the command requires a scope. 3. Create a token (using authentication + authorization options) 4. Run command. This means that scope was being checked, even if a default scope was applied in step 3 by Keystone. New flow: 1. Validate authentication options. 2. Create token (using authentication + authorization options) 3 Validate authorization options if the command requires a scope and the token is not scoped. 4. Run command. Change-Id: Idae368a11249f425b14b891fc68b4176e2b3e981 Closes-Bug: 1592062
* Fix missing i18n supports in api/ and shell.pyHuanxuan Ao2016-06-143-18/+28
| | | | | Change-Id: I28d79d7f44b27d2b600dedad2a3601180650ad83 Partial-bug: #1574965
* osc-lib: utilsDean Troyer2016-06-132-2/+3
| | | | | | | | Use osc-lib directly for utils. Leave openstackclient.common.utils for deprecation period. Change-Id: I5bd9579abc4e07f45219ccd0565626e6667472f7
* osc-lib: exceptionsDean Troyer2016-06-132-3/+2
| | | | | | | | Use osc-lib directly for exceptions. Leave openstackclient.common.exceptions for deprecation period. Change-Id: Iea3e862302372e1b31ccd27f69db59b4953ca828
* Moving authentication from keystoneclient to keystoneauthNavid Pustchi2016-06-092-30/+18
| | | | | | | | | | | | | | | | | Currently OpenStackClient uses keystoneclient for authentication. This change will update OpenStackClient to use keystoneauth for authentication. All dependant test have been updated. Updating how auth_ref is set in the tests to use KSA fixtures had some racy side-effects. The user_role_list tests failed when they picked up an auth_ref that was a fixture. This exposed a weakness in ListUserRole that needed to be fixed at the same time re handling of unscoped tokens and options. Change-Id: I4ddb2dbbb3bf2ab37494468eaf65cef9213a6e00 Closes-Bug: 1533369
* Avoid TypeError on message object additionsMadhu Mohan Nelemane2016-05-191-16/+20
| | | | | Change-Id: I634c1e158e93eeb55ab17fef8a0715b6678dffec Closes-Bug: #1575787
* Fix typos in docstrings and commentsDao Cong Tien2016-04-062-2/+2
| | | | Change-Id: Ic2dc057dca87212f715970f8325956c42f62ea9f
* Merge "Clean up unnecessary import of urlparse module"Jenkins2016-03-011-6/+1
|\
| * Clean up unnecessary import of urlparse moduleYang Hongyang2016-03-011-6/+1
| | | | | | | | | | | | | | six.moves.urllib already covers the py2 and py3 compatibility issues of urlparse module, use six.moves.urllib.parse.urlparse is enough. Change-Id: I785f4f872850e5d770fdcf4c0d3392be3978cc4a
* | Trivial: Update image_list v2 docsYang Hongyang2016-03-011-4/+7
|/ | | | | | | This api doc is clearly copied from v1, we should update it to reflact v2 API. Added 'shared' param description. Change-Id: I73d36e3a2a0448c28edab788a9340fd46177f8ef
* Py3 replace dict.iteritems with six.iteritemsting.wang2016-02-241-1/+1
| | | | | | | | All dict.iteritems in osc are replaced with six.iteritems except this one. So fix it to add py3 compatibility. Change-Id: I1aa51399a36e650d262d839ce2b4ec04d3f91db2
* Use instanceof instead of typeBrandon Palm2016-02-222-4/+4
| | | | | | | | | Adjusted conditional statements to use instanceof when comparing variables. Instanceof supports inheritance type checking better than type. Change-Id: I4ee0004934dc2322d43ef07e797a6811e39a812c Closes-Bug: 1548530
* Clean redundant argument to dict.getting.wang2016-02-212-37/+32
| | | | | | | `dict.get()` returns `None` by default, if a key wasn't found. Removing `None` as second argument to avoid redundancy. Change-Id: Ia82f7469cd019509bbeccbfe54b15eeedc7bb6ea
* Merge "Support unscoped token request"Jenkins2016-02-211-3/+8
|\
View Lorry Controller Status