summaryrefslogtreecommitdiff
path: root/openstackclient/common
Commit message (Collapse)AuthorAgeFilesLines
* fix: Exception message includes unnecessary class argsJas2016-02-291-2/+2
| | | | | | | | | Fix misusages of ArgumentTypeError which causes a tuple of class instance and error message string to be printed rather than just the error message string itsself. Change-Id: I0e997f86bb6603930cc92e90efcb48155f62ffb5 Closes-bug: #1551426
* Add MultiKeyValueAction to custom parser actionTang Chen2016-02-271-0/+81
| | | | | | | | | | | | | | Class MultiKeyValueAction will be used to parse arguments like this: --route destination=xxx,gateway=xxx --route destination=yyy,gateway=yyy The result is a list like this: [{destination:xxx, gateway:xxx}, {destination:yyy, gateway:yyy}] This action also contain validation of the parameters. Change-Id: Ie3aa8635c6a13fc2e429fe6922acd681dc7244cf
* Merge "Defaults are ignored with flake8"Jenkins2016-02-261-1/+2
|\
| * Defaults are ignored with flake8Tom Cocozzello2016-02-231-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | If “ignore” is not set under flake8 in the tox.ini file there there are defaults set to be ignored. The depended patch fixes many of the problems. Change-Id: Ieed2fe1c4654e201d3fe6d40ef93e247ee736f8b Doc: http://flake8.readthedocs.org/en/latest/config.html#default Depends-On: I935ab48e7c5bac5f88ecdb3a05f73fb44fc9f41d Closes-Bug: #1548910
* | Merge "Fixed a bunch of spacing"Jenkins2016-02-254-2/+5
|\ \ | |/
| * Fixed a bunch of spacingBrandon Palm2016-02-234-2/+5
| | | | | | | | | | | | | | Nothing too complicated here. I fixed a bunch of spacing issues that I saw in OSC. Change-Id: I935ab48e7c5bac5f88ecdb3a05f73fb44fc9f41d
* | Merge "Refactor network AZ exception handling"Jenkins2016-02-241-3/+2
|\ \ | |/ |/|
| * Refactor network AZ exception handlingRichard Theis2016-02-101-3/+2
| | | | | | | | | | | | | | | | Exceptions that occur while getting network availability zones should not be masked as if the extension does not exist. Change-Id: I07213ec6c4d83e97261b58bf8d42417c1cdfae6a Related-Bug: #1534202
* | Clean redundant argument to dict.getting.wang2016-02-213-10/+10
| | | | | | | | | | | | | | `dict.get()` returns `None` by default, if a key wasn't found. Removing `None` as second argument to avoid redundancy. Change-Id: Ia82f7469cd019509bbeccbfe54b15eeedc7bb6ea
* | Merge "Support unscoped token request"Jenkins2016-02-211-2/+20
|\ \
| * | Support unscoped token requestguang-yee2016-02-191-2/+20
| | | | | | | | | | | | | | | | | | | | | | | | Make scope check optional for the "token issue" command as unscoped token is a valid Keystone V2/V3 API. Change-Id: Ie1cded4dbfdafd3a78c0ebdf89e3f66762509930 Closes-Bug: #1543214
* | | Merge "Fix Mutable default argument"Jenkins2016-02-211-2/+12
|\ \ \
| * | | Fix Mutable default argumentting.wang2016-02-201-2/+12
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Python’s default arguments are evaluated once when the function is defined, not each time the function is called. This means that if you use a mutable default argument (like list and dict) and mutate it, you will and have mutated that object for all future calls to the function as well. more details about this wrong usage here: http://docs.python-guide.org/en/latest/writing/gotchas/#mutable-default-arguments Change-Id: If187f16bfb305ac4fe6e4177e498a06c49c3f946
* | | Replace string format arguments with function parametersting.wang2016-02-201-2/+2
|/ / | | | | | | | | | | | | | | There are files containing string format arguments inside logging messages. Using logging function parameters should be preferred. Change-Id: I15b405bf4d4715263fe1e1262982467b3d4bc1f4 Closes-Bug: #1321274
* | Allow custom log levels for other loggersTerryHowe2016-02-051-9/+37
|/ | | | | | | | | | | | | | It would be convenient to be able to enable special logging for various components that openstack uses. The biggest thing is the --debug prints a lot of information when often all I want to see is the outgoing requests/responses. To get just that logged you would put this in your clouds.yaml: logging: keystoneclient.session: debug Closes-Bug: #1484660 Change-Id: I15c2607e8262f10903dd831ee8622fb5d6315310
* Merge "Support listing network availability zones"Jenkins2016-02-041-10/+56
|\
| * Support listing network availability zonesRichard Theis2016-02-021-10/+56
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update the "os availability zone list" command to support listing network availability zones along with the currently listed compute and volume availability zones. This adds the --network option to the command in order to only list network availability zones. By default, all availability zones are listed. The --long option was also updated to include a "Zone Resource" column which is applicable to network availability zones. Example zone resources include "network" and "router". If the Network API does not support listing availability zones then a warning message will be issued when the --network option is specified. This support requires an updated release of the SDK in order to pull in [1]. [1] https://bugs.launchpad.net/python-openstacksdk/+bug/1532274 Change-Id: I78811d659b793d9d2111ea54665d5fe7e4887264 Closes-Bug: #1534202
* | Merge "Allow wait_for_delete to work for all clients"Jenkins2016-02-041-2/+6
|\ \
| * | Allow wait_for_delete to work for all clientsMark Vanderwiel2016-01-281-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allow the exception and error status strings to be passed in such that other plugins can make use of this function. There is a comment in find_resource: The exception to catch here is dependent on which client library the manager passed in belongs to. Eventually this should be pulled from a common set of client exceptions. Since I think that is a long ways off, this change will work now and also work when a common exception is defined and used. Change-Id: Iab56cd1166028caed4f1e657e0b1ee81af3f48d8
* | | Merge "Add "os port show" command"Jenkins2016-02-031-0/+10
|\ \ \
| * | | Add "os port show" commandRichard Theis2016-02-021-0/+10
| | |/ | |/| | | | | | | | | | | | | | | | | | | Add "os port show" command. Change-Id: Id87c81640e74c60ae8f247c722c64fdadff022a2 Partial-Bug: #1519909 Partially-Implements: blueprint neutron-client
* | | Merge "Drop log_method decorator"Jenkins2016-02-021-27/+0
|\ \ \ | |/ / |/| |
| * | Drop log_method decoratorAkihiro Motoki2016-02-021-27/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As a result of the recent logging refactoring, log_method decorator is no longer required. oslo.log provides a similar decorator oslo_log.helpers.log_method_call. If a similar feature is needed, we can use the decorator from oslo_log. searchlightclient is the only OSC external plugin which uses this decorator. The depending patch removes it, so we can safely drop the decorator. Change-Id: If3df09cf6aa0a401d9f89e8924adce851d0c6dec Depends-On: Ib94e7ba77262a9a8cbfce71f3083c47cb1973364
* | | Merge "Fix showing network quotas for a project"Jenkins2016-02-021-4/+7
|\ \ \ | |/ / |/| |
| * | Fix showing network quotas for a projectRichard Theis2016-02-021-4/+7
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The OpenStack SDK is now used for the network client. However, the 'openstack quota show' command wasn't updated for the client change. As a result, the command will fail to show network quotas when a project name is specified. For example: $ openstack quota show admin 'Proxy' object has no attribute 'show_quota' This patch set fixes the command by using the OpenStack SDK to get network quotas for a project. Change-Id: I59a7b6780a7b80cd09e79d40d214751b25d3016e Related-To: blueprint neutron-client Closes-Bug: #1528249
* | log take_action parameters in a single placeAkihiro Motoki2016-02-028-60/+19
|/ | | | | | | | | | | | Previously each command logs take_action parameters explicitly by using @utils.log_method decorator or log.debug(). Some commands have no logging. This commit calls a logger in the base class and drops all logging definition from individual commands. Closes-Bug: #1532294 Change-Id: I43cd0290a4353c68c075bade9571c940733da1be
* Merge "Support listing volume availability zones"Jenkins2016-01-221-14/+61
|\
| * Support listing volume availability zonesRichard Theis2016-01-141-14/+61
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Update the "os availability zone list" command to support listing volume availability zones along with the currently listed compute availability zones. This adds a --compute and --volume option to the command in order to select the availability zones to list. By default, all availability zones are listed. If the Block Storage API does not support listing availability zones then an warning message will be issued. Change-Id: I8159509a41bd1fb1b4e77fdbb512cf64a5ac11a9 Closes-Bug: #1532945
* | Merge "Refactor "os availability zone list""Jenkins2016-01-221-0/+102
|\ \ | |/
| * Refactor "os availability zone list"Richard Theis2016-01-141-0/+102
| | | | | | | | | | | | | | | | | | | | | | | | Refactor the "os availability zone list" command to make it a common command instead of a compute-only command. Since availability zones are common to compute, volume and network (new), this refactoring allows availability zone support to be added for volume and network. In addition to the refactor, unit and functional tests were added. Change-Id: I63e9d41d229b21cd38e5a083493042c096d65e05 Partial-Bug: #1532945
* | log_method: get logger from decorated method if unspecifiedAkihiro Motoki2016-01-201-9/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | This commit makes 'log' optional. 'log' attribute of each command class does not exist when the class is defined because 'log' is now setup dynamically when a class is instantiated. Instead log_method looks for a logger from a decorating method. compute.v2.server is changed in this commit as an example. Change-Id: Ic4d128f8e027d3b8e6f884f31369e9085c0f0871 Partial-Bug: #1532294
* | Set up logger of each command by metaclassAkihiro Motoki2016-01-201-0/+42
| | | | | | | | | | | | | | compute.v2.flavor is changed in this commit as an initial example. Partial-Bug: #1532294 Change-Id: I262af6ade0ae03fbe1cd2ad198faf4ebb4ecf7ce
* | Merge "Refactor network endpoint enablement checking"Jenkins2016-01-141-0/+20
|\ \ | |/ |/|
| * Refactor network endpoint enablement checkingRichard Theis2016-01-041-0/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Move the network endpoint enablement checking from the 'server create' command to the common client manager. This allows future network commands to use either nova or neutron networking based on the cloud environment. This patch set also includes related unit test enhancements to the common client manager to trigger authentication on the tests. Change-Id: Ia37e81d4fb05a1e2fceb3e5d367bda769ab8e64b Related-Bug: #1519511 Related-to: blueprint neutron-client
* | Merge "Trivial: Remove useless string_to_bool()"Jenkins2016-01-081-4/+0
|\ \
| * | Trivial: Remove useless string_to_bool()Tang Chen2015-12-291-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | string_to_bool() is not used by anyone. Furthermore, it is not well designed. It tries to convirt 't', '1' to True, which could be confused. So remove it. If we need something similar, let's make a better one. Change-Id: Ic1f63480c806bf7bcc9f541fc806eed297ddf718
* | | Delete the unused LOG configure codezhurong2016-01-051-4/+0
| | | | | | | | | | | | | | | | | | Delete the unused LOG configure code and import code Change-Id: I1fb0cacfe44b6a2fd4e4b3f504b6d1dec055c5c4
* | | Merge "Use Block Storage instead of Volume"Jenkins2016-01-042-3/+3
|\ \ \ | |_|/ |/| |
| * | Use Block Storage instead of VolumeXi Yang2015-11-272-3/+3
| | | | | | | | | | | | | | | | | | | | | Volume is better to be replaced by Block Storage in the doc. Change-Id: I736669ee01c7385b6e701cb20f4334eff1c49286
* | | Improve output for "os security group show"Richard Theis2015-12-231-3/+4
| |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Improve the security group rules output when running the "os security group show" command. Each security group rule is now displayed on a separate line. Current output example: $ openstack security group show default +-------------+------------------------- ... ---+ | Field | Value ... | +-------------+------------------------- ... ---+ | description | Default security group ... | | id | 048a5fc3-3be1-407d-ae47-9... | | name | default ... | | project_id | 3b96bb2020c1459da76963f9e... | | rules | [u"id='5d812367-9829-4340...t"] | +-------------+------------------------- ... ---+ New output example: +-------------+------------------------- ... ---+ | Field | Value ... | +-------------+------------------------- ... ---+ | description | Default security group ... | | id | 048a5fc3-3be1-407d-ae47-9... | | name | default ... | | project_id | 3b96bb2020c1459da76963f9e... | | rules | id='5d812367-9829-4340-95...lt' | | | id='ee451d1c-ade3-4975-8e...lt' | +-------------+------------------------- ... ---+ Change-Id: I1386075310896c58a2b776e2bbec3603bd00eff1 Partial-Bug: #1519511 Related-To: blueprint neutron-client
* | SDK integration extensions and server create networksTerry Howe2015-12-091-2/+2
| | | | | | | | | | | | | | Finish up the SDK integration with server create network and port find and extension list. Change-Id: I18dbada784d8aa92a45a937f251023ddf899c53e
* | Switch to ksa SessionDean Troyer2015-12-021-2/+2
| | | | | | | | | | | | | | | | * Change session imports to keystoneauth1 * Change keystoneclient.exception imports to keystoneauth1 * Change exceptions raised from internal API from keystoneclient to openstack.common Change-Id: I046d89f561d6fe04baae53726f9749d2e7fe2056
* | Add project name/ID validation for "openstack quota show"xiexs2015-11-291-3/+9
|/ | | | | | | A validation is necessary to check the existence of project. This patch is similar to Ia2d8c96527820e25b074e6486d3f39c5ad7eae60. Change-Id: Id8895ba7a21ecad05942619a82a87c0dc68eae53
* Trivial: Fix a typo.Tang Chen2015-11-271-1/+1
| | | | Change-Id: I236b4f53ee23cc97900e6244ab709404cc44a4ca
* Trivial: Add missing doc for parameter in wait_for_delete().Tang Chen2015-11-261-0/+1
| | | | | | The doc of parameter manager is missing. Change-Id: I4e99c06ab713532d73615670ada0a61462285d76
* Merge "Unable to set some compute quotas"Jenkins2015-11-251-0/+1
|\
| * Unable to set some compute quotasRichard Theis2015-11-201-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The OpenStackClient mapping of 'openstack quota set' arguments isn't correct for compute quota items that have to different names. For example, the --injected-file-size argument is mapped to injected_file_size, but the compute quotas item is actually injected_file_content_bytes. This incorrect mapping prevented the impacted compute quota items from being set. The problem impacts the following 'openstack quota set' arguments: --injected-file-size --injected-path-size --properties --secgroup-rules --secgroups This patch set also expands the compute quota unit tests to verify all compute quota items that can be set. Change-Id: I0a2f241e425f4811e4ae55be183ac0c8b0805c2a Closes-Bug: #1475831
* | Merge "Trivial: Fix wrong doc for wait_for_status()."Jenkins2015-11-231-1/+2
|\ \
| * | Trivial: Fix wrong doc for wait_for_status().Tang Chen2015-11-241-1/+2
| |/ | | | | | | | | | | | | | | Two trivial fixes: 1. docs for parameters are not sorted correctly 2. missing doc for a parameter Change-Id: I0cfb65e0f897c391b9b6e7225251e88855b07a56
* | Trivial: Remove doc for non-existing param in format_dict().Tang Chen2015-11-211-1/+0
|/ | | | | | There is no parameter named format. Change-Id: I286006430efb2850b978b6f2abaed87216156d12
View Lorry Controller Status