summaryrefslogtreecommitdiff
path: root/openstackclient/compute/v2/security_group.py
Commit message (Collapse)AuthorAgeFilesLines
* Merge "Use a common decorator to log 'take_action' activation"Jenkins2015-09-111-4/+4
|\
| * Use a common decorator to log 'take_action' activationJoshua Harlow2015-09-011-4/+4
| | | | | | | | | | | | | | | | | | Instead of duplicating the same log statement throughout the code, the same logic can be provided by a shared decorator that abstracts away the logging capability and unifies it behind a common function instead. Change-Id: Icc63bced7347c8bbf0299a4c5821425a10892a79
* | Properly handle port arguments for ICMPDean Troyer2015-09-031-4/+7
|/ | | | | | | | | | The Compute API requires 'from_port' and 'to_port' to be -1 for ICMP security group rules. It happily accepts them empty or None but the resulting rules do not work. So we force the values for ICMP rules. Closes-bug: #1477629 Change-Id: Iba57211014caca16be7c9a28d15d4db2a6c51b8d
* Fix security group list commandTerryHowe2015-06-021-1/+1
| | | | | | | | | | | | Security group list command tries to get a project list and this may fail with a multitude of exceptions including but not limited to 401, 404, ConnectionRefused and EndpointNotFound. Rather than try to capture every possibility, this patch just catches the base class. Converting project ids to names is less important than having a working security group list command. Change-Id: I68214d2680bad907f9d04ad3ca2f62cf3feee028 Closes-Bug: #1459629
* Security group rule delete brokenTerryHowe2015-05-071-35/+4
| | | | | | | | | | Nova client was changed to take a rule id for security group rule delete. https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/security_group_rules.py#L72 Change-Id: I0a69f3f196a36f267ee85a651b09aa8d3c328121 Closes-Bug: #1450872
* Merge "Fix security group create description bug"Jenkins2015-04-231-1/+3
|\
| * Fix security group create description bugDean Troyer2015-04-221-1/+3
| | | | | | | | | | | | | | | | --description is optional in our CLI but the server requires it to be non-empty. Set a default value of the given name. Closes-Bug: #1434172 Change-Id: I81507a77ad8d815000ff411784ae71e229c77f78
* | Security group rule create failsRamaraja Ramachandran2015-04-221-0/+1
|/ | | | | | | | | By default the --dst-port value is set to None when no --dst-port argument is provided. By making the default value (0, 0), this allows novaclient to proceed without any error. Change-Id: Ibb58f5df5ed1890a8f499dd2467b12b0e79d547b Closes-Bug: #1443963
* Merge "Fix help messages"Jenkins2015-03-061-2/+2
|\
| * Fix help messagesRamaraja2015-03-041-2/+2
| | | | | | | | | | | | | | | | Update help message for openstack security group rule delete Update help message for openstack security group rule list Change-Id: I017ffd424ca25b6c62193b91068eb1ba7de6c919 Closes-Bug: #1417854
* | Handle novaclient >2.20.0Dean Troyer2015-03-031-1/+6
|/ | | | | | | | | | As of 2.21.0 novaclient moved all of the v1_1 classes to v2 with a deprecation warning. The version-non-specific interfaces provided in novaclient.client are insufficient to support a few specific commands in OSC so we need to conditionally import directly from the correct classes. Closes-Bug: #1418024 Change-Id: I864b1908737803069dc1419c9cbca391b985c932
* Don't import form keystoneclient.openstack.commonJamie Lennox2014-12-171-1/+1
| | | | | | | | The keystoneclient.openstack.common directory is where we sync files from oslo incubator. It is not a public directory and should not be being consumed by openstackclient. Change-Id: I011bb95c2c824e2dbc4b822ca922ae77b8d9b955
* Fix security group list for non-adminDean Troyer2014-08-271-3/+9
| | | | | | | Non-admin users couldn't list security groups due to the project lookup failure. That shouldn't stop the listing. Change-Id: I27f6ff4975b35d1de1c852c8d4e830b83c7dec75
* replace string format arguments with function parametersChristian Berendt2014-05-201-8/+8
| | | | | | | | There are files containing string format arguments inside logging messages. Using logging function parameters should be preferred. Change-Id: Ic749ac9eb55564ed631d57055a5a4dfc3aebd169
* Fix format errors in nova security group rule listTerry Howe2014-02-201-7/+15
| | | | | | | | | | * port range was throwing exception for None to/from ports * ip_range didn't always have cidr causing error * ip_protocol None at times and looked bad Closes-Bug #1256935 Change-Id: I451a0f038a3e9646bca3f278c5d6f6d7e3097a83
* Add security group commandsDean Troyer2013-07-291-0/+394
* Add security group: create, delete, list, set, show * Add server: add secgroup, remove secgroup * Add security group rule: create, delete, list * Add Oslo's strutils and gettextutils * Adds parseractions.RangeAction() to handle option arguments of either a single number or a range of numbers: '--port 25' or '--port 1024:65535' Blueprint: nova-client Change-Id: Iad2de1b273ba29197709fc4c6a1036b4ae99725f