summaryrefslogtreecommitdiff
path: root/openstackclient/image/v2
Commit message (Collapse)AuthorAgeFilesLines
* Don't look up project by id if given idDmitriy Rabotyagov2020-03-241-3/+8
| | | | | | | | | | | | There is a much deeper and systemic issue going on here, but let's start with fixing the immediate issue which is that adding a project to an image fails trying to look up project information even if the user passes the project id by id. _is_uuid_like from sdk isn't perfect, but it'll be good enough for this. Change-Id: I541416d737b961c56aa2f584c172528632fd5537
* Switch image to use SDKArtem Goncharov2020-03-231-121/+153
| | | | | | | | | | | | | This is a work to switch OSC from using glanceclient to OpenStackSDK. With this change only v2 is using OpenStackSDK. V1 is still using glanceclient and will be switched in a separate change. Remove the direct depend on keystoneauth- let that flow through openstacksdk. Depends-on: https://review.opendev.org/#/c/698972 Change-Id: I36f292fb70c98f6e558f58be55d533d979c47ca7
* Replace six.iteritems() with .items()lihaijing2020-01-091-5/+5
| | | | | | | | | | | | | | | | 1. As mentioned in [1], we should avoid using six.iteritems to achieve iterators. We can use dict.items instead, as it will return iterators in PY3 as well. And dict.items/keys will more readable. 2. In py2, the performance about list should be negligible, see the link [2]. [1] https://wiki.openstack.org/wiki/Python3 [2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html Co-Authored-By: Akihiro Motoki <amotoki@gmail.com> Change-Id: I4b9edb326444264c0f6c4ad281acaac356a07e85 Implements: blueprint replace-iteritems-with-items
* Use cliff formattable columns in image commandsAkihiro Motoki2019-06-221-3/+4
| | | | | | | | | | Related functional tests are converted into JSON format. Otherwise, it is not easy to check results. Partial-Bug: #1687955 Partially implement blueprint osc-formattable-columns Change-Id: Ib82e15738544975fede0c54cc5eaf239f4c67277
* Remove deprecated image commandsDean Troyer2019-05-191-43/+6
| | | | | | | * Remove ``image create|set`` option ``--owner`` Change-Id: I1fabab98c8660eba6d0dd75e74544c6c9d432b9e Signed-off-by: Dean Troyer <dtroyer@gmail.com>
* Remove code migrated to osc-lib long agoDean Troyer2019-05-161-1/+1
| | | | | | | | | * Remove openstackclient.api.utils and use osc_lib.api.utils * Remove openstackclient.common.clientmanager.ClientManager.auth_ref * Remove openstackclient.common.commandmanager Change-Id: I67e1dbc53cc0b37967c0011bcb2fc09bdef62d94 Signed-off-by: Dean Troyer <dtroyer@gmail.com>
* Merge "Fix --limit option in image list sub-command"Zuul2019-05-081-0/+5
|\
| * Fix --limit option in image list sub-commandRadoslaw Smigielski2019-02-041-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | Client site fix of --limit option. This bugfix makes client "image list" command working again with "--limit" option. This option was ignored and even if user specified it, still list of all available images was returned. Story: 2004314 Change-Id: I30a78d65a644c9b7d23706a6637ce77bca2c2386 Depends-On: https://review.openstack.org/#/c/634776/
* | Merge "Add possibility to filter images using member_status"Zuul2019-03-071-0/+13
|\ \
| * | Add possibility to filter images using member_statusArtem Goncharov2019-02-261-0/+13
| |/ | | | | | | | | | | | | | | | | In order to see image sharing membership it is required to additionally pass member_status filter to API. Otherwise only those with status 'all' will be returned. Thus adding possibility to see images shared with project to be approved or rejected. Change-Id: Ifd6e13e5a4ef09fbc29e76d464c93fbdbb178ae4
* | Fix help message of image add projectDavid Rabel2019-02-191-1/+1
|/ | | | | | | | | | | Only with the admin role you can use the project name with 'image add project'. With the normal member role you have to use the project id instead. If you try to use the name, you don't receive an error, but it won't work. Change-Id: I2d11c07a256917d12c46a7c302c5a5e8752a1df0 Task: 29543 Story: 2002535
* image/v2: support multiple property filtersSven Wegener2018-11-071-9/+9
| | | | | Change-Id: I8ba40cb8ca647ec24b80c2824bb64e84430535d4 Signed-off-by: Sven Wegener <sven.wegener@inovex.de>
* osc-included image signing (using openstacksdk)Josephine Seifert2018-09-081-0/+58
| | | | | | | | | | | | | This extension adds image signing functionality to the "image create" command. Therefore, new CLI options --sign-key-path and --sign-cert-id have been added. This patch uses openstacksdk as the signing backend library instead of cursive. Therefore, requirements and lower_constraints have been updated to use the openstacksdk version 0.17 or higher. Depends-On: Idc15b9a12d408bd4b2e096da8402c374be56f9fa Change-Id: Ia20bc02a49c3fbeb9222e485e3396395f4ab817a Story: 2002128 Co-Authored-By: Markus Hentsch <markus.hentsch@secustack.com>
* Merge "Support --community in openstack image list"Zuul2018-07-251-0/+9
|\
| * Support --community in openstack image listNobuto Murata2018-07-241-0/+9
| | | | | | | | | | | | | | | | | | "--community" was added to "image create" and "image set" previously, but was missed in "image list". Change-Id: I959fdd7f67ae62c8326659ce52389228152ec019 Story: 2001925 Task: 14453
* | Fix error with image show when image name is NoneJake Yip2018-07-231-1/+1
|/ | | | | | | | Need to bump osc-lib to 1.10.0 Closes-Bug: #1736696 Depends-On: I2aab5cc1f550848bda2b90ef7ef9a60f07b88996 Change-Id: I7420204f28d36529354e5671bd88587d9b15bb06
* Add ability to filter image list by tagAdam Harwell2018-06-281-0/+8
| | | | Change-Id: I2e222d3e69df9d8d7cd472663caaee31bedd848c
* Merge "Add support to list image members"Zuul2018-04-021-0/+33
|\
| * Add support to list image membersMohammed Naser2018-03-211-0/+33
| | | | | | | | | | | | | | | | The OpenStack client presently has support to add or remove members from an image, but no way to list image members. This patch addreses this issue. Change-Id: Ie85c5de23c6beb21fd6b4c04c83ddf2a116606ef
* | Fix additional output encoding issuesDean Troyer2018-03-201-2/+1
|/ | | | | | | | This is a followup to https://review.openstack.org/#/c/541609/ that changes most outstanding direct uses of sys.stdout to use the encoded stdout set up by cliff. Change-Id: I07cfc418385fc787d3b7d3c32d39676cf81bb91f
* Merge "Replace assert with condition"Zuul2018-01-221-3/+1
|\
| * Replace assert with conditionPavlo Shchelokovskyy2018-01-221-3/+1
| | | | | | | | | | | | | | a piece of code in image client has some business logic behind assert, which can be lost when running python in optimized mode (-O). Change-Id: I2179970df495e1215d691915c51cebe5cb4541a7
* | Check that Glance returns image data before processing itMike Fedosin2018-01-051-0/+7
|/ | | | | | | | | | | | | | | | | | | | | | | | Now if Glance v2 cannot find image data it returns an empty response with 204 status code, instead of raising an error. Glance client handles this situation and wraps the response with a RequestIdProxy object, whose 'wrapped' attribute is None. But when openstack client tries to parse this object using glanceclient's save_image util function, it fails with "NoneType object is not iterable" message, for the object doesn't contain any data. This patch adds additional check to prevent such behaviour and raises SystemExit exception if no data was returned from the server. Glance v1 is not affected, because it raises an error if can't find an image data. Change-Id: I016a60462ba586f9fa7585c2cfafffd7be38de7b Closes-Bug: #1741223
* Accept 0 for --min-disk and --min-ramShogoAdachi2017-10-201-2/+2
| | | | | | | | | | | | | | The current openstackclient implementation cannot accept 0 for --min-disk and --min-ram with the "openstack image set" command. If theses options get set to 0, the option parser in openstackclient wrongly interprets 0 as no option value. The 0 is valid for these options if administrators want to make it the default(no minimum requirements). This patch fix the parser so that it avoids only 'None'. Change-Id: Ie8ee37484c02c26f54adc56263fcd167c0ce7eb3 Closes-bug: #1719499
* Update image cli doc and fix some typoslihaijing2017-08-251-1/+1
| | | | | Change-Id: I0a8d095e51a96804c97612e28fac2d00aa94c638 Closes-Bug: #1711284
* Fix "openstack image unset" command's help message typolihaijing2017-08-231-2/+2
| | | | | Change-Id: Ie286d9ee6054cc2126473d7e6e77bafbfd80023b Closes-Bug: #1712473
* image-list should support filters 'name','status'nidhimittalhada2017-07-121-0/+16
| | | | | | | | | nova api support parameters like 'name', 'server', 'status', etc in image-list(). So openstackclient should support this too. DocImpact Closes-Bug: #1698742 Change-Id: Ice66b409f989e6785aa3b2d42f2fdbf6e23fa0aa
* Added 'openstack image set --visibility'M V P Nitesh2017-06-301-4/+30
| | | | | | | | | | This feature will allow image owners to share images across multiple tenants/projects without explicitly creating members individually through the glance API V2. “Community images” will not appear iu user's default image listings Change-Id: Ic02bf44cca5d6d793d68a8737d3cfe3f44407d88 Closes-Bug: #1626837
* Merge "To display image size in human friendly format"Jenkins2017-06-011-0/+8
|\
| * To display image size in human friendly formatBadhmapriya Boopalan2017-01-111-0/+8
| | | | | | | | | | | | | | | | | | | | Include option '--human-readable' to 'image show' command. This option displays image size in human readable format (such as K, M, G, T,..) Related Commit: I0ef74c2ec978483fe49156c88acf5c369a8fa5c2 Closes-Bug: #1640086 Change-Id: I28cd5702925d51303d0607ed8dccf12c56434682
* | Help/docs cleanups: marker, limit, ip-address metavarsDean Troyer2017-04-041-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | Cleanup help strings and docs for clarity and to keep things consistent: * --limit metavar should be <num-resource> to indicate what is being counted * --marker metavar should be <resource> or <resource-id> to indicate the type of value being specified * <*-ip-address> metavars should be just <ip-address> as there is no difference in format between fixed and floating IPs * Move all occurances of '(name or ID)' to end of help text Change-Id: I2c31746ed6ded3845244e03e57d809f8bc0e6b9d
* | openstack image create : --file and --volume exclude each otherDavid Rabel2017-02-241-2/+3
| | | | | | | | | | | | | | | | Added parser.add_mutually_exclusive_group() for --file and --volume in openstack image create. Change-Id: I4d9fc6314801d569354e5644e231ddd6c7f1853d Closes-Bug: 1666551
* | Update container format choicesBrian Rosmaita2017-01-231-4/+10
| | | | | | | | | | | | | | | | | | | | The choices for valid container formats is out of date in the image v1 and v2 help text. This patch adds 'ova' and 'docker' and does some minor refactoring to align the container_format option with the disk_format option. Change-Id: Icdea5fab801abd651baf45cf96c920c7df79f11b Closes-bug: #1658138
* | Add support for Glance 'update image members' featureJordan Pittier2017-01-041-1/+35
| | | | | | | | | | | | | | | | | | This patch adds 3 new options to the "image set" command: --accept, --reject and --pending. This updates the membership status for an image. Closes-Bug: 1620481 Change-Id: I13b8c067aad68ece9ff636fbdd83bcb3663c91b2
* | Add ploop to supported disk formatsMikhail Feoktistov2016-12-151-1/+1
| | | | | | | | | | | | | | | | This format is used for containers for Virtuozzo hypervisor Closes-Bug: 1650342 Change-Id: Ic79f29a1fe9ea5016d3d5520c2b06e39da01ff61
* | Merge "Revert "Remove marker and loop from "image list" command""Jenkins2016-12-051-2/+13
|\ \
| * | Revert "Remove marker and loop from "image list" command"Steve Martinelli2016-12-051-2/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 0b6fdcbe4c3f3142fdd18bfd827653d894607941. Adapt "image list" to not loop when --marker is specified on command line. Update tests to work with current state of code. Change-Id: I8af58adf8637a9e34371c6280db40935d22bc3c3
* | | Merge "Sort list images by name by default"Jenkins2016-12-021-1/+2
|\ \ \ | |/ / |/| |
| * | Sort list images by name by defaultVijendra Soni2016-11-211-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | Set the default key and dir for openstack image list, if no command line argument passed Changing sort_key to name(old value: created_at) Change-Id: I6c61f6e5a04824d655ccf43477afcec9652101df Closes-Bug: #1639231
* | | clean up image choices and help textSteve Martinelli2016-11-231-4/+8
| |/ |/| | | | | | | | | | | | | | | | | | | Use choices for image set and image create commands, this aligns with our use of choices in networking commands. Also update the help text to match that of the networking commands, where we iterate through the options. Related-Bug: 1635518 Change-Id: Ib4c66b06e07f1d4e5bfe1b74053f2215cccad890
* | translate all command help strings3.4.0Steve Martinelli2016-11-171-10/+10
|/ | | | | | | | | | | | | | Leverage the new cliff command class attribute (_description) to get the help of a command, this allows us to mark strings for translation. We could not do this before since the help was grabbed from the docstring. This also depends on a new release of cliff and a bump to the minimum level in osc's requirements. Closes-Bug: 1636209 Depends-On: Id915f6aa7d95a0ff3dc6e2ceaac5decb3f3bf0da Change-Id: I8673080bb5625e8e3c499feaefd42dfc7121e96f
* Remove execute permission on a few filesSongmingYan2016-07-221-0/+0
| | | | | | | Some files have execute permission unnecessarily. Change them from 755 to 644. Change-Id: I471ebd1c3d123ad4a7376f7f5996f53f8c2d9b0b
* image list: Add Checksum columnMarc Abramowitz2016-07-111-0/+2
| | | | | | | | | The checksum could potentially be useful for spotting duplicated images or checking if images with the same name are identical or different. Closes-Bug: #1602073 Change-Id: Ia0c41970c846d550de14297e18bc738e847e5a3b
* Correct reraising of exceptionqinchunhua2016-07-071-4/+4
| | | | | | | | | When an exception was caught and rethrown, it should call 'raise' without any arguments because it shows the place where an exception occured initially instead of place where the exception re-raised. Change-Id: I5fb6dea5da7fb6e1e2b339a713c7d37f8c99e407
* Make the print info support i18nliyifeng2016-06-211-1/+2
| | | | | | | | When OSC failed to set a image's property, it will print the image name and status, which is an useful info to users. So translate this massage, and record it in log. Change-Id: Icdff4dab17dedcb40289700c4cd278e6e62eea25
* Standardize logger usageTang Chen2016-06-201-16/+16
| | | | | | | | | | | | | | | | | | | Use file logger for all command specific logs. This patch also fixes some usage that doesn't follow rules in: http://docs.openstack.org/developer/oslo.i18n/guidelines.html After this patch, all self.log and self.app.log will be standardized to LOG(). NOTE: In shell.py, we got the log in class OpenStackShell, which is also known as self.app.log in other classes. This logger is used to record non-command-specific logs. So we leave it as-is. Change-Id: I114f73ee6c7e84593d71e724bc1ad00d343c1896 Implements: blueprint log-usage
* Merge "Make set/unset command in identity and image pass normally when ↵Jenkins2016-06-171-13/+0
|\ | | | | | | nothing specified"
| * Make set/unset command in identity and image pass normally when nothing ↵sunyajing2016-06-171-13/+0
| | | | | | | | | | | | | | | | | | specified Also update its unit tests. Change-Id: I82b90658b0d4247cdc9a650f14aceda640a32059 Partial-bug: #1588588
* | Merge "Fix image delete multiple arguments error"Jenkins2016-06-141-5/+19
|\ \ | |/ |/|
| * Fix image delete multiple arguments errorsunyajing2016-06-131-5/+19
| | | | | | | | | | | | | | | | | | Fix image delete command, support processing multiple arguments delete error. Fix doc/source/command-errors.rst, make the msg format correct. Change-Id: Icbe347fe077bc148bf71ea8f7399b0e934b7cdf9 Partially-Implements: blueprint multi-argument-image
View Lorry Controller Status