summaryrefslogtreecommitdiff
path: root/openstackclient/image
Commit message (Collapse)AuthorAgeFilesLines
* Add missing documentation for state options for "image set"lsmman2023-02-221-2/+8
| | | | | | | | | | | | | | | | The current "image set" with the state option behaves as follows: if you use --project, it updates the membership status of the given project. When this command was first added, it had the following description: If --project is passed, update the membership status for the given project However, the description was missed when moving the documentation for which command to the parser for each command method in commit f055fe67c. Correct this oversight. Co-authored-by: JAE YONG LEE <jaeljy135@gmail.com> Change-Id: I18a29a19ce973971f68a52cbf4020cfa324c7a35
* Merge "image: Add support for additional image import methods"Zuul2023-01-251-4/+4
|\
| * image: Add support for additional image import methodsStephen Finucane2022-11-301-4/+4
| | | | | | | | | | | | | | | | These are now supported in openstacksdk so we can use them. Change-Id: Ie3107ba2155f9008e6065171298f85978957a172 Signed-off-by: Stephen Finucane <sfinucan@redhat.com> Depends-on: https://review.opendev.org/c/openstack/openstacksdk/+/864029
* | Merge "image: Fail if we can't find an image"Zuul2022-12-201-8/+22
|\ \
| * | image: Fail if we can't find an imageStephen Finucane2022-12-011-8/+22
| | | | | | | | | | | | | | | | | | | | | | | | Whenever we attempt to find a provided image, we generally want to fail fast if they can't be found. This wasn't happening. Fix it. Change-Id: Ibea38354a78381cb87d287f03726ecd03ecd246d Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | Merge "image: Rename import"Zuul2022-12-201-13/+15
|\ \ \ | |/ /
| * | image: Rename importStephen Finucane2022-12-011-13/+15
| | | | | | | | | | | | | | | | | | | | | This makes the code a little clearer. Change-Id: Ib552d510ca484571e59363ef15fe5e2cc0a2f4e1 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | Merge "Add image metadef namespace command"Zuul2022-12-151-0/+247
|\ \ \
| * | | Add image metadef namespace commandhoosa2022-12-071-0/+247
| | | | | | | | | | | | | | | | | | | | | | | | add image metadef namespace create, delete, set, show command Change-Id: I35b1cb8ff2b1735ae3a1b405d8f2071fe449ea6e
* | | | Merge "image: Add 'image import' command"Zuul2022-12-051-0/+243
|\ \ \ \ | |_|/ / |/| | / | | |/ | |/|
| * | image: Add 'image import' commandStephen Finucane2022-11-091-0/+243
| |/ | | | | | | | | | | | | | | Note that we require some additional functionality in SDK for this to work properly, but it's a start. Change-Id: I87f94db6cced67f36f71685e791416f9eed16bd0 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | Revert "Don't look up project by id if given id"Stephen Finucane2022-11-301-9/+5
|/ | | | | | | | | | | | | | | This reverts commit 042be7c7fe89f5a1a190af90d5980205d995941b. This solution worked but it was confusing. The issue that the author was seeing was presumably due to users not being able to list projects but in theory the 'openstackclient.image.common.find_project' function that was being called here should have already handle this. It transpires however that there was a bug in this and we weren't correctly handling HTTP 403 errors correctly. This bug has since been fixed in change I2ea2def607ec5be112e42d53a1e660fef0cdd69c meaning this change is no longer necessary. Remove it and simplify the code somewhat. Change-Id: I108efec2c8deda50fcb9cc84f313602bed2ac15c Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* image: Add 'image stage' commandStephen Finucane2022-11-091-0/+77
| | | | | | | This is the equivalent of the 'image-stage' glanceclient command. Change-Id: I10b01ef145740a2f7ffe5a8c7ce0296df0ece0bd Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* image: Simplify handling of data provided via stdinStephen Finucane2022-11-091-39/+52
| | | | | | | This was unnecessarily complex. Change-Id: I8289d5ce7356d8bc89425590a7f71bca91a6d396 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* image: Ignore '--progress' if providing image data from stdinStephen Finucane2022-11-091-1/+3
| | | | | | | | You can provide data via stdin when creating an image. Using this with '--progress' makes no sense and causes an error currently. Fix this. Change-Id: I3c2d658b72a7c62931b779b0d19bb97f60a0c655 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* Added "openstack image metadefs namespace list" commandAreg Grigoryan2022-10-261-0/+65
| | | | | Change-Id: Ibc064566478818bd70e7e6550095d24a05e1bb0e Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/854612
* image: Add 'image task list' commandStephen Finucane2022-09-211-0/+101
| | | | | | | | | | | | This replaces the 'glance task-list' command. $ openstack image task list We also indicate that the 'image task create' command will never be implemented. This is an admin-only API that isn't really intended to be used by humans thus it does not need an OSC command implementation. Change-Id: Id8a943a5443782fc70c0fbf3639f5aa17b9d30af
* image: Add 'image task show' commandslsmman2022-09-211-0/+78
| | | | | | | | This replaces and the 'glance task-show' command. For example: $ image task show <TASK_ID> Change-Id: I74cb23e436c373fe238804b903bbeb28f643d5af
* image: Split image creation depending on serviceStephen Finucane2022-06-301-50/+84
| | | | | | | | | | | The 'image create' operation is actually one of two operations: it can be either an image service (glance) operation if the '--volume' argument is *not* passed or a block storage (cinder) operation if it is. Make this clearer and add a log warning users about options that are supported by the former but not the latter. Change-Id: Id153c951a7d18403568bf67e13d5e0a4827428d4 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* image: Make better use of argparseStephen Finucane2022-06-301-69/+80
| | | | | | | | Simplify some logic by using a common 'dest' for mutually exclusive options. Change-Id: Ie5f3600672953f40be52de51e84717c8912ddaf8 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* image: Trivial style changesStephen Finucane2022-06-301-191/+321
| | | | | Change-Id: I35b7b8a80609916eb47357af4398789788d66382 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* Fix: create image from volume commandwhoami-rajat2022-06-301-2/+16
| | | | | | | | | | | | | | | | | | Currently the command ``openstack image create --volume`` calls cinderclient to upload the volume to image service (glance) but OSC passes ``visibility`` and ``protected`` fields which are only available in microversion 3.1 or greater. This generates an error if the user is using volume microversion < 3.1 and wants to create an image from volume. This patch fixes that by only passing ``visibility`` and ``protected`` fields when the volume microversion is 3.1 or greater and fail otherwise i.e. the following 3 cases: 1) visibility/protected argument + mv >= 3.1 = pass 2) visibility/protected argument + mv < 3.1 = fail 3) not visibility/protected argument + any mv = pass Story: 2010060 Task: 45511 Change-Id: I568a0ea0af8f7f82b16d49a6a1bb0391b99c50dc
* Allow users to list all imagesCyril Roelandt2022-06-071-0/+9
| | | | | | | | Add a "--all" option to "openstack image list", which allows the user to list all of the images. Story: 2010071 Change-Id: I56a2e4846d0380d07803305fb830d1a43dfd71b3
* Allow to filter multiple tags for image listDmitriy Rabotyagov2022-05-161-2/+4
| | | | | | | | | Currently in case of passing `--tag` several times, only last one will be picked up for the filtering. In the meanwhile Glance allow option to be repeated multiple times to filter based on the multiple tags. Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/789827 Change-Id: I7379d0b0014f0e3d13b02ee5ec6b642a7a5aa7d1
* Stop using private _is_uuid_like methodPavlo Shchelokovskyy2022-04-201-2/+2
| | | | | | | | | | | | | | | currently this double-private method of a dependency library is used in several places (openstack.cloud._utils._is_uuid_like) openstacksdk deliberatly chose not to depend on oslo.utils to keep dependenies to the minimum, so it just copied several methods from it, including the is_uuid_like. python-openstackclient however already depends on oslo.utils, so using the public method from oslo.utils should be preferred and more stable. Change-Id: I578ffa36ffb00c9d47ee12a149313201973edd32
* image: Sanity check the 'SetImage' commandStephen Finucane2021-11-171-40/+50
| | | | | | | | | This was a very difficult command to grok, due to the layering on of additional features over the years. Make this a little easier to follow by grouping related logic and making use of argparse features. Change-Id: I4e1a0aed09ea5d6a8c26ec3e888c9c7b6cefc25a Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* Remove 'get_osc_show_columns_for_sdk_resource' duplicatesStephen Finucane2021-10-212-10/+10
| | | | | | | | | | | | There were a number of 'get_osc_show_columns_for_sdk_resource' defined in-tree. However, osc-lib has provided this method for some time (since 2.2.0, June 2020 [1] - our minimum version is currently 2.3.0) so there's no need to provide our own copies. Remove them. [1] https://github.com/openstack/osc-lib/commit/29a0c5a5 Change-Id: I25695f4f9a379dd691b7eaa1e3247164668ae77e Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* openstack image create: honor protection/visibility flagsCyril Roelandt2021-05-051-0/+2
| | | | | | | | The --protected, --unprotected, --public, --shared, --community, --private flags were ignored when using --volume. Change-Id: Id5c05ef7d7bb0a04b9d7a9d821e544e1ff7b3d28 Story: 2008882
* Implements hide imageValery Tschopp2021-03-251-0/+27
| | | | | | | | | openstack image set [--hidden|--unhidden] IMAGE openstack image list --hidden Task: 41734 Story: 2008581 Change-Id: Ie84f10c0f7aa2e7b7f78bfadc70132a10673866e
* Merge "image: Unset properties rather than setting to None"Zuul2021-01-061-1/+1
|\
| * image: Unset properties rather than setting to NoneStephen Finucane2020-12-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, we attempt to unset an image property by setting it to None. This doesn't work for known properties and is rightly rejected by the Glance API with the following error: BadRequestException: 400: Client Error for url: http://172.20.4.87/image/v2/images/368c5751-2b0b-4a38-a255-fd146fe52d31, Bad Request The solution is to actually unset the field by deleting it. Change-Id: Ie156bedbe0f9244f82c81401679706f484caf9aa Signed-off-by: Stephen Finucane <sfinucan@redhat.com> Story: #2008463 Task: #41493
* | Add support '--progress' option for 'image create'youngho choi2021-01-041-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | openstack-client doesn’t support the upload progress bar. This patch shows progressbar when create image if you added '--progress' option like a python-glanceclient. like this. [=============================>] 100% +------------------+---------------------------+ | Field | Value | +------------------+---------------------------+ | container_format | bare | | created_at | 2020-09-06T20:44:40Z | ... How to use Add the'--progress' option on the 'openstack image create' command. Code was written by referring to 'python-glanceclient' project on stable/ussuri branch Change-Id: Ic3035b49da10b6555066eee607a14a5b73797c00 task: 40003 story: 2007777
* | Add project field in image list subcommandokozachenko2020-12-151-0/+15
|/ | | | | | The motivation is to filter the image by owner Change-Id: I1f08da175a06e62a844f76b0ec18cb3332efef86
* stop image downloads to memorySimon Merrick2020-11-252-2/+10
| | | | | | | | | | + Fixes issue with large images hogging memory + stream image downloads + output to stdout if file not specified Change-Id: Ia01ff9b21a2dac5d0ccf2bd58a8640e88c5cbb36 Story: 2007672 Task: 39776
* Restore behavior of image create with same name.Sam Morrison2020-10-061-1/+1
| | | | | | | | | | | With 60e7c51df4cf061ebbb435a959ad63c7d3a296bf the behaviour of `openstack image create` changed so that you can't create an image with the same name. This patch restores the previous functionality. Story: 2008229 Task: 41069 Change-Id: Ia0f4920371a918e94d1ccf9fcfcbf90ff885a455
* Merge "Fix uploading an signed image does not work if private signing key is ↵5.3.0Zuul2020-07-081-0/+6
|\ | | | | | | encrypted"
| * Fix uploading an signed image does not work if private signing key is encryptedAlexander Gräb2020-07-071-0/+6
| | | | | | | | | | | | Change-Id: Ia7c84aa7b840bf92aeb7db7246d14119eb727b03 Story: 2007890 Task: 40269
* | Expose flag for forcing use of import for imagesMonty Taylor2020-06-301-0/+11
|/ | | | | | | | | | openstacksdk added support for using image import as a fallback which is transparently supported here, but also provides an override flag to allow a user to force use of import. Expose that here. Depends-On: https://review.opendev.org/737608 Change-Id: Ied938a8f63f305305a20ace42e9f4c84b0a5c00e
* Don't look up project by id if given idDmitriy Rabotyagov2020-03-241-3/+8
| | | | | | | | | | | | There is a much deeper and systemic issue going on here, but let's start with fixing the immediate issue which is that adding a project to an image fails trying to look up project information even if the user passes the project id by id. _is_uuid_like from sdk isn't perfect, but it'll be good enough for this. Change-Id: I541416d737b961c56aa2f584c172528632fd5537
* Complete switch from glanceclient to SDK for image serviceArtem Goncharov2020-03-242-117/+79
| | | | | | | | | In https://review.opendev.org/#/c/650374/ a work has been started to switch image service support from glanceclient with all it's dependencies to the SDK version. With this change version 1 (anyway deprecated since ages) is also being switched to SDK. Change-Id: Ic391500af02a73d81d64a9e9113cca85c9e24390
* Switch image to use SDKArtem Goncharov2020-03-232-155/+195
| | | | | | | | | | | | | This is a work to switch OSC from using glanceclient to OpenStackSDK. With this change only v2 is using OpenStackSDK. V1 is still using glanceclient and will be switched in a separate change. Remove the direct depend on keystoneauth- let that flow through openstacksdk. Depends-on: https://review.opendev.org/#/c/698972 Change-Id: I36f292fb70c98f6e558f58be55d533d979c47ca7
* Replace six.iteritems() with .items()lihaijing2020-01-092-8/+7
| | | | | | | | | | | | | | | | 1. As mentioned in [1], we should avoid using six.iteritems to achieve iterators. We can use dict.items instead, as it will return iterators in PY3 as well. And dict.items/keys will more readable. 2. In py2, the performance about list should be negligible, see the link [2]. [1] https://wiki.openstack.org/wiki/Python3 [2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html Co-Authored-By: Akihiro Motoki <amotoki@gmail.com> Change-Id: I4b9edb326444264c0f6c4ad281acaac356a07e85 Implements: blueprint replace-iteritems-with-items
* Use cliff formattable columns in image commandsAkihiro Motoki2019-06-222-18/+22
| | | | | | | | | | Related functional tests are converted into JSON format. Otherwise, it is not easy to check results. Partial-Bug: #1687955 Partially implement blueprint osc-formattable-columns Change-Id: Ib82e15738544975fede0c54cc5eaf239f4c67277
* Remove deprecated image commandsDean Troyer2019-05-192-71/+8
| | | | | | | * Remove ``image create|set`` option ``--owner`` Change-Id: I1fabab98c8660eba6d0dd75e74544c6c9d432b9e Signed-off-by: Dean Troyer <dtroyer@gmail.com>
* Remove code migrated to osc-lib long agoDean Troyer2019-05-162-2/+2
| | | | | | | | | * Remove openstackclient.api.utils and use osc_lib.api.utils * Remove openstackclient.common.clientmanager.ClientManager.auth_ref * Remove openstackclient.common.commandmanager Change-Id: I67e1dbc53cc0b37967c0011bcb2fc09bdef62d94 Signed-off-by: Dean Troyer <dtroyer@gmail.com>
* Merge "Fix --limit option in image list sub-command"Zuul2019-05-081-0/+5
|\
| * Fix --limit option in image list sub-commandRadoslaw Smigielski2019-02-041-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | Client site fix of --limit option. This bugfix makes client "image list" command working again with "--limit" option. This option was ignored and even if user specified it, still list of all available images was returned. Story: 2004314 Change-Id: I30a78d65a644c9b7d23706a6637ce77bca2c2386 Depends-On: https://review.openstack.org/#/c/634776/
* | Merge "Add possibility to filter images using member_status"Zuul2019-03-071-0/+13
|\ \
| * | Add possibility to filter images using member_statusArtem Goncharov2019-02-261-0/+13
| |/ | | | | | | | | | | | | | | | | In order to see image sharing membership it is required to additionally pass member_status filter to API. Otherwise only those with status 'all' will be returned. Thus adding possibility to see images shared with project to be approved or rejected. Change-Id: Ifd6e13e5a4ef09fbc29e76d464c93fbdbb178ae4
* | Fix help message of image add projectDavid Rabel2019-02-191-1/+1
|/ | | | | | | | | | | Only with the admin role you can use the project name with 'image add project'. With the normal member role you have to use the project id instead. If you try to use the name, you don't receive an error, but it won't work. Change-Id: I2d11c07a256917d12c46a7c302c5a5e8752a1df0 Task: 29543 Story: 2002535
View Lorry Controller Status