summaryrefslogtreecommitdiff
path: root/openstackclient/tests/unit/volume
Commit message (Collapse)AuthorAgeFilesLines
* Fix: Restore output 'VolumeBackupsRestore' object is not iterablewhoami-rajat2019-08-281-2/+4
| | | | | | | | | | | | | VolumeBackupsRetore object has '_info' attribute which contains the output data of the restore command which should be returned instead of the 'VolumeBackupsRestore' object. Change-Id: I64b75649c1ac9c24e05a197f7280975564b4d386 Story: 2004740 Task: 28811 (cherry picked from commit 24255ad0dde608a19d371a27c13714098097f185) (cherry picked from commit 7882463fda77813c9e230373f0ab53c6c8574ba3)
* Use flake8-import-order pluginAkihiro Motoki2017-08-177-7/+8
| | | | | | | | | | | | | | | | In reviews we usually check import grouping but it is boring. By using flake8-import-order plugin, we can avoid this. It enforces loose checking so it sounds good to use it. This flake8 plugin is already used in tempest. Note that flake8-import-order version is pinned to avoid unexpected breakage of pep8 job. Setup for unit tests of hacking rules is tweaked to disable flake8-import-order checks. This extension assumes an actual file exists and causes hacking rule unit tests. Change-Id: I12b596820727aeeb379bee16c2bc993dee9eb637
* Fix unit test failures related to new os-client-config and osc-libAkihiro Motoki2017-07-121-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | [breakage related to os-client-config 1.28.0] os-client-config 1.28.0 add a check if filebased and envvars are both used. This check causes OSC unit test failure. OSC now instantiates OpenStackConfig twice as a workaround. The unit test mocks _load_config_file() and it returns a config dict, but os-client-config OpenStackConfig.__init__ updates the dict returned. As a result, when OpenStackConfig is instantiated second time, the mock of _load_config_file returns a modified version of the config dict. This hits the new check in os-client-config 1.28.0. This commit changes the mock to use side_effect rather than return_value to ensure the original dict is used. [breakage related to osc-lib 1.7.0] The change in osc-lib 1.7.0 added "if" logic to avoid calling get() twice. In tests.unit.volume.test_find_resource, kwargs is empty dict in find_resource(), so the second call to get() is NOT called now. Removing the second elements of side_effect addresses the unit failure. Co-Authored-By: Rui Chen <chenrui.momo@gmail.com> Change-Id: Ib9d14661b2755bbd6619e15c0d9023fbc9d27d70 Closes-Bug: #1703782 Closes-Bug: #1703783
* Replace "Display Name" by "Name" in volume listRui Chen2017-05-262-18/+126
| | | | | | | | | | | | | | | | | | Current "volume list --name" command use "display_name" as search_opts to send to cinder API, and show the result table with "Display Name" column title in osc, cinder list API support "name" as search opts too, and there is "name" attribute in volume response body, so we can replace all "Display Name" by "Name" in order to keep "volume list" command consistent with other commands, like: server list, network list and so on, only use "Name" attribute for all objects. Support a mapping for volume list -c "Display Name" (Volume v1 and v2) and volume create/show -c "display_name" (Volume v1) for minimal backward compatibility until R release. Change-Id: I120be0118e7bb30093b4237c5eeb69a9eedef077 Closes-Bug: #1657956 Depends-On: I1fb62219b092346ea380099811cbd082cae5bafe
* Fix volume qos spec listDean Troyer2017-04-282-17/+76
| | | | | | | | | | | | | | | This has been sporadically failing in functional tests due to the way the volume qos spec list command calls get_associations() for each spec. When tests run in parallel occasionally a spec from another test is present in the list returned and is deleted before the get_associations() call is made, causing a NotFound exception. We should just keep going when this occurs. * make v1 match v2 * add tests to ensure the exception is being caught and handled Closes-Bug: #1687083 Change-Id: If2d17c1deb53d293fc2c7f0c527a4e4ef6f69976
* Fix NoneType error for volume snapshot create commandHuanxuan Ao2017-04-262-33/+18
| | | | | | | | | | | | | In volume snapshot command, <volume> is the same as <snapshot-name> when --volume is not specified, but <volume> cannot be None, so when <snapshot-name> is not specified (<snapshot-name> is None), a NoneType error appears. So make <snapshot-name> no longer optional, it should be always present. Change-Id: I3d9f10753a8ef601e70816421c160598e2cc811f Closes-bug: #1659894
* Fix volume transfers request commandsDean Troyer2017-03-272-18/+94
| | | | | | | | | | | | * Fix volume transfer request accept to actually not crash when trying to call Volume API. * Fix volume transfer request accept syntax to have only one positional argument, which is the ID of the resource in the command * Change the output column order in volume transfer request list to have ID followed by Name then the remaining columns. Closes-bug: 1633582 Change-Id: I5cc005f039d171cc70859f60e7fe649b09ead229
* Merge "OSC Quota List"Jenkins2017-03-211-0/+50
|\
| * OSC Quota ListSindhu Devale2017-03-101-0/+50
| | | | | | | | | | | | | | | | Implement Neutron feature of Quota List into OpenStack Client. Change-Id: Idf941acf8d00b136776b7381b877c56d82622f57 Partially-Implements: blueprint neutron-client-quota
* | Merge "Support --no-property in "volume set" command"Jenkins2017-03-062-0/+24
|\ \
| * | Support --no-property in "volume set" commandzhiyong.dai2017-02-232-0/+24
| | | | | | | | | | | | | | | | | | | | | Add "--no-property" option to "volume set" command in v1 and v2 and update the test cases. Change-Id: Id5660f23b3b2d9aa72f4c16b19ce83f3f7ed2fa4
* | | Merge "Add Cinder v3 client support for volumes"Jenkins2017-03-011-0/+0
|\ \ \
| * | | Add Cinder v3 client support for volumesJustin A Wilson2017-02-201-0/+0
| |/ / | | | | | | | | | | | | | | | Initial Cinder v3 support Change-Id: Idd5074832e80697ed0671f06d3291dfd92dbfb08
* | | Fix properties format for volume qos in volume v1Huanxuan Ao2017-02-211-11/+10
| |/ |/| | | | | | | | | | | | | | | | | | | | | Notice that patch [1] fixed the error of properties format for volume qos in volume v2, but there is the same bug in volume v1, and the patch missed that, so fix the problem in v1 as well [1] https://review.openstack.org/#/c/421065/ Partial-Bug: #1656767 Change-Id: I156bf13d164dbd0d0a7ce394964176718c4ff0e5
* | Merge "Add "volume host failover" command"Jenkins2017-02-181-0/+31
|\ \
| * | Add "volume host failover" commandzhiyong.dai2016-11-211-0/+31
| | | | | | | | | | | | | | | | | | | | | Add "volume host failover" command in volume v2 (v2 only). Change-Id: Ia39e6d20bf5c9d3096e46f3432804a240827548d Implements: bp cinder-command-support
* | | Merge "Add "encryption-*" options in volume type commands"Jenkins2017-02-184-7/+568
|\ \ \ | |_|/ |/| |
| * | Add "encryption-*" options in volume type commandsHuanxuan Ao2017-01-144-7/+568
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add "--encryption-provider", "--encryption-cipher", "--encryption-key-size" and "--encryption-control-location" options to "volume type set" and "volume type create" commands. Add "--encryption-type" option to "volume type unset", "volume type list" and "volume type show" commands. Change-Id: I3572635d5913d971a723a62d7790ffe0f20ec39a Implements: bp cinder-command-support Closes-Bug: #1651117
* | | Merge "Support "--no-property" option in volume snapshot set"Jenkins2017-01-262-5/+71
|\ \ \
| * | | Support "--no-property" option in volume snapshot setzhiyong.dai2017-01-252-5/+71
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Supporting "--no-property" option will apply user a convenient way to clean all properties of volume snapshot in a short command, and this kind of behavior is the recommended way to devref. The patch adds "--no-property" option in "volume snapshot set" command, and update related test cases and devref document. Change-Id: I5f10cc2b5814553699920c4343995b2e11416e4e Implements: blueprint allow-overwrite-set-options
* | | | Merge "Add --project and --project-domain option to "volume snapshot list""Jenkins2017-01-251-1/+14
|\ \ \ \ | |/ / / |/| | |
| * | | Add --project and --project-domain option to "volume snapshot list"jiahui.qiang2017-01-071-1/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Add "--project" and "--project-domain" option to volume v2's "volume snapshot list" command, it will filter list result by different project. Change-Id: I7dccd6d8d9f1889fa9cb0c2d04a42d77975c645b
* | | | Error in the return of command 'volume qos create'jiahui.qiang2017-01-171-13/+15
| |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch fixed a 'volume qos create' display mistake in argument of 'specs'[1]. For command such as: $ openstack volume qos create hello [1]https://bugs.launchpad.net/python-openstackclient/+bug/1656767 Closes-bug:#1656767 Change-Id: Ia9fce833d318d9b52b97c12cfb89e2d3c5465fbe
* | | Merge "Add unit test for multi volume types delete"Jenkins2017-01-122-5/+73
|\ \ \
| * | | Add unit test for multi volume types deleteHuanxuan Ao2017-01-112-5/+73
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Missing unit test for multi volume types delete in volume v2 (v1 has been done), this patch add it. Change-Id: I5fe67196408157f8bdfe6399ba1e559cea3dc559
* | | | Merge "Add two consistency group commands"Jenkins2017-01-111-0/+206
|\ \ \ \ | |/ / / |/| | |
| * | | Add two consistency group commandszhiyong.dai2016-12-131-0/+206
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add commands: consistency group add volume consistency group remove volume in volume v2 (v2 only) Change-Id: I70ff287d3b5df78196b8f4b9e50402c471aef284 Implements: bp cinder-command-support Closes-Bug: #1613964
* | | | Fix filter error in os volume listjiahui.qiang2017-01-091-0/+117
| |/ / |/| | | | | | | | | | | | | | | | | | | | This patch fixed a bug of unable to filter volume list by '--project', '--user' in "openstack volume list". Modify uint test for 'volume list' to check parameter of list method. Change-Id: I1fc4296c4c7eca0f7a803dbfd5e15e3bc0d6403f
* | | Add one test for "backup set" commandzhiyong.dai2016-12-191-0/+24
| |/ |/| | | | | | | | | | | The former tests for "backup set" command miss a test for '--description' option. In this patch, one relative test is added. Change-Id: Ie755d56a68a666d48751ab1ad20c8edb50e69b94
* | Merge "Add --default option to "volume type list""Jenkins2016-12-181-1/+26
|\ \
| * | Add --default option to "volume type list"jiahui.qiang2016-12-061-1/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | Add "--default" option to volume v2's "type list" command, it will show which volume type the volume service has set as default. Implements: bp cinder-command-support Change-Id: Iae7ebc633ebe5554cc88390a84361887ec211fb2
* | | Merge "Add some options to "volume create" command"Jenkins2016-12-162-0/+284
|\ \ \ | |/ / |/| |
| * | Add some options to "volume create" commandjiahui.qiang2016-12-062-0/+284
| |/ | | | | | | | | | | | | | | Add "--bootable", "--non-bootable", "--read-only" and "--read-write" options to "volume create" command for setting some attributes at the time of crration. Change-Id: I71b4e9fccb4ee0ab1a90e7179d6d2d34dbbae909 Implements: bp cinder-command-support
* | Add "--remote-source" option to "volume snapshot create" commandHuanxuan Ao2016-12-121-0/+28
|/ | | | | | | | | | | Add "--remote-source" option to "volume snapshot create" command to support creating snapshot from an existing remote snapshot in volume v2 (v2 only), also add the doc, unit tests and release note. Change-Id: I9e5fad4f0db5b44d528eb6b930edbc816e392c3a Implements: bp cinder-command-support Closes-Bug: #1618676 Co-Authored-By: Sheel Rana <ranasheel2000@gmail.com>
* Merge "Add '--force' option to 'volume snapshot delete' command"Jenkins2016-12-081-3/+20
|\
| * Add '--force' option to 'volume snapshot delete' commandHuanxuan Ao2016-12-081-3/+20
| | | | | | | | | | | | | | | | | | Add '--force' option to 'volume snapshot delete' command in volume v2 (v2 only) to allow delete in state other than error or available. Change-Id: Ie8991e9a630d7c7e9ac6c6870aed787bbcebacf2 Closes-Bug: #1597195
* | Merge "Add "consistency group set" command"Jenkins2016-12-081-0/+64
|\ \
| * | Add "consistency group set" commandzhiyong.dai2016-12-061-0/+64
| |/ | | | | | | | | | | | | | | Add "consistency group set" command in volume v2 (v2 only). Change-Id: I53116015388b7a4b0e15813f52c1246166bb0fc1 Implements: bp cinder-command-support Partial-Bug: #1613964
* | Merge "Fix description errors in volume fakes"Jenkins2016-12-081-3/+3
|\ \
| * | Fix description errors in volume fakesjiahui.qiang2016-11-271-3/+3
| |/ | | | | | | | | | | | | In volumev2 fakes.py. Description of some 'get_*' methods is incorrect. the error will mislead the user. this patch has already fixed it. Change-Id: I048e3c2b625c7b54ab19f2b923d4970427f277ff
* | Merge "Add options to "volume snapshot list" command"Jenkins2016-12-082-7/+192
|\ \
| * | Add options to "volume snapshot list" commandjiahui.qiang2016-11-262-7/+192
| |/ | | | | | | | | | | | | | | Add "--name", "--status" and "--volume" options to "volume snapshot list" command for filtering results. Change-Id: I72db1abce7701f31598deec34801a4d1f5713870 Closes-Bug:#1645252
* | Merge "Add "consistency-group-snapshot" option to consistency group create"Jenkins2016-12-081-0/+39
|\ \
| * | Add "consistency-group-snapshot" option to consistency group createHuanxuan Ao2016-12-071-0/+39
| |/ | | | | | | | | | | | | | | | | | | | | Add "consistency-group-snapshot" option to "consistency group create" command to support for creating consistency group from existing consistency group snapshot Implements: bp cinder-command-support Partial-Bug: #1613964 Change-Id: I54c265d38299f4973945ba99e30042bcf47859c0
* | Add "volume host set" commandjiahui.qiang2016-11-251-0/+86
|/ | | | | | | | Add "volume host set" command in volume v2 to support freeze(disable) and thaw(enable) the specified cinder-volume host Change-Id: Iee1604d72f9eccd9e327b0ef8d345909a733a647 Implements: bp cinder-command-support
* Merge "Refactor "snapshot" commands"Jenkins2016-12-032-24/+77
|\
| * Refactor "snapshot" commandsHuanxuan Ao2016-11-032-24/+77
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1.change the command name ``snapshot create/delete/list/ show/set/unset`` to ``volume snapshot create/delete/list/ show/set/unset``. 2.change the optional parameter "--name <name>" to a positional parameter "<snapshot-name>"; Change the positional parameter "<volume>" to a optional parameter "--volume <volume>" Change-Id: If03276ecdf6f0d96893d5ecf91c2aaa64929cff3 Implements: bp backup-snapshot-renamed-for-volume-resource Co-Authored-By: Sheel Rana <ranasheel2000@gmail.com>
* | Add "consistency group show" commanddaizhiyong2016-12-021-0/+43
| | | | | | | | | | | | | | | | Add "consistency group show" command in volume v2 (v2 only). Change-Id: If496eba2955c0aacd52600bb6fba39690ddd90cb Implements: bp cinder-command-support Partial-Bug: #1613964
* | Add "consistency group delete" commandzhiyong.dai2016-12-022-0/+125
| | | | | | | | | | | | | | | | Add "consistency group delete" command in volume v2 (v2 only). Change-Id: Ieebc2417df0d45a578d5617bad245d7863f09190 Implements: bp cinder-command-support Partial-Bug: #1613964
* | Merge "Add "--type" and "--retype-policy" options to "volume set" command"Jenkins2016-12-021-0/+66
|\ \
View Lorry Controller Status