summaryrefslogtreecommitdiff
path: root/openstackclient/tests
Commit message (Collapse)AuthorAgeFilesLines
* Make set/unset commands in compute/image/common return normally when nothing ↵Tang Chen2016-06-212-6/+13
| | | | | | | | | | specified After this patch, all set/unset commands will return normally when nothing specified. Change-Id: Id94d0329faa1a674006a9aae901f834b41917317 Close-bug: #1588588
* Merge "Error handling of "router delete" command"Jenkins2016-06-201-7/+59
|\
| * Error handling of "router delete" commandHuanxuan Ao2016-06-201-7/+59
| | | | | | | | | | | | | | | | "Router delete" command supports multi deletion but no error handling. This patch add the error handling follow the rule in doc/source/command-error.rst Change-Id: I3376d957b4dc28d8282599dc909ecc5ed2b5f46a
* | Merge "Add "--network-segment" option to "subnet create""Jenkins2016-06-202-15/+84
|\ \
| * | Add "--network-segment" option to "subnet create"Richard Theis2016-06-132-15/+84
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add "--network-segment" option to the "subnet create" command. This is a beta command option and subject to change. Use global option "--os-beta-command" to enable this option. This patch set also provides a devref update for beta command options. Change-Id: I4d0fbe079b2a873307364c41c22ce9ba88e632e6 Partially-Implements: blueprint routed-networks
* | | Merge "Standardize logger usage"Jenkins2016-06-201-9/+6
|\ \ \
| * | | Standardize logger usageTang Chen2016-06-201-9/+6
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use file logger for all command specific logs. This patch also fixes some usage that doesn't follow rules in: http://docs.openstack.org/developer/oslo.i18n/guidelines.html After this patch, all self.log and self.app.log will be standardized to LOG(). NOTE: In shell.py, we got the log in class OpenStackShell, which is also known as self.app.log in other classes. This logger is used to record non-command-specific logs. So we leave it as-is. Change-Id: I114f73ee6c7e84593d71e724bc1ad00d343c1896 Implements: blueprint log-usage
* | | Merge "Fix console url show command broken in microversion case"Jenkins2016-06-201-0/+149
|\ \ \
| * | | Fix console url show command broken in microversion caseRui Chen2016-06-161-0/+149
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The response data of nova get_xxx_console API is changed from "console" to "remote_console" in microversion 2.6, and nova server side API schema verify the spice vnc type to "spice-html5", update OSC code to apply these change so that OSC can work in different nova microversion cases. Change-Id: I3bb4fe057e656209d00d2bb308ac3f7f837cb03f Closes-Bug: #1590318
* | | | Use osc_lib in server_image.pyTang Chen2016-06-201-2/+3
| |/ / |/| | | | | | | | | | | | | | | | | server_image.py is a newly created file. So I think we forgot to use osc_lib in it. Change-Id: Ieda13438662ea55b03f549108aac63c18b9af913
* | | Merge "Do not prompt for scope options with default scoped tokens"Jenkins2016-06-171-5/+5
|\ \ \
| * | | Do not prompt for scope options with default scoped tokensDolph Mathews2016-06-171-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This changes the scope validation to occur after a token has already been created. Previous flow: 1. Validate authentication options. 2. Validate authorization options if the command requires a scope. 3. Create a token (using authentication + authorization options) 4. Run command. This means that scope was being checked, even if a default scope was applied in step 3 by Keystone. New flow: 1. Validate authentication options. 2. Create token (using authentication + authorization options) 3 Validate authorization options if the command requires a scope and the token is not scoped. 4. Run command. Change-Id: Idae368a11249f425b14b891fc68b4176e2b3e981 Closes-Bug: 1592062
* | | | Merge "Modify unit tests of compute agent delete"Jenkins2016-06-171-0/+10
|\ \ \ \ | |/ / / |/| | |
| * | | Modify unit tests of compute agent deletesunyajing2016-06-081-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | add no-input test to ``compute agent delete`` unit tests. Change-Id: Iee22b75c9a9431e57cb634dc28a5efa9b43b7369
* | | | Merge "Make set/unset command in identity and image pass normally when ↵Jenkins2016-06-173-0/+82
|\ \ \ \ | | | | | | | | | | | | | | | nothing specified"
| * | | | Make set/unset command in identity and image pass normally when nothing ↵sunyajing2016-06-173-0/+82
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | specified Also update its unit tests. Change-Id: I82b90658b0d4247cdc9a650f14aceda640a32059 Partial-bug: #1588588
* | | | | Merge "Support bulk deletion for delete commands in networkv2"Jenkins2016-06-163-15/+156
|\ \ \ \ \
| * | | | | Support bulk deletion for delete commands in networkv2Huanxuan Ao2016-06-163-15/+156
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch support bulk deletion for delete commands below: 1.subnet delete 2.subnet pool delete Up to now, all the delete commands in networkv2 support bulk deletion. Change-Id: I63f6d1d02bad1fcc26e72b7028b53958a68ce2dc Partially-Implements: blueprint multi-argument-network Partial-Bug: #1592906
* | | | | Merge "Move server image create command to its own resource file."Jenkins2016-06-162-144/+227
|\ \ \ \ \
| * | | | | Move server image create command to its own resource file.Dean Troyer2016-06-032-144/+227
| | | | | | | | | | | | | | | | | | | | | | | | Change-Id: If37e82072bd7a32b81bfb1a8bb048f018dd5b04f
* | | | | | Finish osc-lib transition for command.pyDean Troyer2016-06-151-1/+1
| |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://review.openstack.org/#/c/328318/ was the transition of openstackclient/common/command.py to osc-lib but it was incomplete; https://review.openstack.org/#/c/329885/ started to fix it but was also incomplete. Third time is charm? Change-Id: Ib6c0266155c2155ae59067ce7b15bebca1e375e8
* | | | | Merge "Support bulk deletion for commands that exist in both network and ↵Jenkins2016-06-155-42/+413
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | compute."
| * | | | | Support bulk deletion for commands that exist in both network and compute.Huanxuan Ao2016-06-155-42/+413
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some delete commands in networkv2 are exist in both network and compute, They can use NetworkAndComputeDeleteclass to supprot bulk deletion and error handling and the codes are similar, so I change them all in this patch. The changed commands including: 1.floating ip delete 2.security group delete 3.security group rule delete Also, I update unit tests and docs for these commands in this patch. Change-Id: I6c94c3d10ba579ddd9b14d17673c821e3481fd8a Partially-Implements: blueprint multi-argument-network
* | | | | | Merge "Support compute service force down/up"Jenkins2016-06-151-4/+98
|\ \ \ \ \ \
| * | | | | | Support compute service force down/upRui Chen2016-06-141-4/+98
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Aims to evacuate servers from compute host as soon as possible, operators might set the compute service force down manually. Novaclient support the behavior, this patch support it in OSC. Change-Id: I22ff1c5d670c449771fdcb3f4f39cd82f428531a Closes-Bug: #1589348
* | | | | | | Add default IP version and fix help messages for "ip availability list"Huanxuan Ao2016-06-151-2/+5
| |/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There was not a default IP version in "ip availability list" command, if we used this command without "--ip-version" option, the output was different from the outputs with the option "--ip-version 4" and "--ip-version 6" and it is not right. This patch add default IP version (default is 4) in ``ip availability list`` command and make this command work properly without ``--ip-version`` option. And also fix the help message. Change-Id: Idc08ab6eaf05946eb2ab59bfb3d4497a383d987d Closes-Bug: #1592761
* | | | | | Merge "Standardize logger usage in volume"Jenkins2016-06-151-8/+11
|\ \ \ \ \ \
| * | | | | | Standardize logger usage in volumeTang Chen2016-06-141-8/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | self.app.log is the logger in class OpenStackShell, which should be used to record logs that have nothing to do with any specific command. So, use the file logger instead. This patch also fixes some usage that doesn't follow rules in: http://docs.openstack.org/developer/oslo.i18n/guidelines.html 1. add variables to logger as an argument 2. do not wrap variables with str() Change-Id: I248861a38a4de0412a080046aa7a6f6473c3e082 Implements: blueprint log-usage
* | | | | | | Merge "Fix foundation copyrights"Jenkins2016-06-141-1/+1
|\ \ \ \ \ \ \
| * | | | | | | Fix foundation copyrightsDean Troyer2016-06-141-1/+1
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The OpenStack LLC copyrights date from before OpenStack was transferred to the foundation. These appear to be getting copy-pasted to new files so at least should reflect the correct entity. Change-Id: I02953d752cb24ead6aa4ad8bfe257a48317c9f13
* | | | | | | Merge "Fix errors in ``set/unset flavor`` unit tests"Jenkins2016-06-141-9/+20
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | |
| * | | | | | Fix errors in ``set/unset flavor`` unit testsTang Chen2016-06-141-9/+20
| | |_|/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1. We should assert flavor.set_keys() is called correctly or not called in ``set flavor`` unit tests. 2. Commit c7e6973ff50ff84af9ad55f7bdaeeea83ae40f0b from me removed test_flavor_unset_no_project which used to test if --project was specified as '', and assert CommandError was raised, which is incorrect. So I removed it. But after looking into the code, I think we should not remove it, but specify nothing after --project, and assert ParserException was raised. So in this patch, we fix it as so. ('--project', '') --> ('--project') assert CommandError --> assert ParserException Change-Id: Ifd33c72d5b7581aaabffb09e9b5e38ecc67e18c0
* | | | | | Merge "osc-lib: timing"Jenkins2016-06-141-94/+0
|\ \ \ \ \ \ | |_|/ / / / |/| | | | |
| * | | | | osc-lib: timingDean Troyer2016-06-131-94/+0
| | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I3fe27d98efa5090e084c676f7f8e6dad0157ed21
* | | | | | Merge "Fix image delete multiple arguments error"Jenkins2016-06-141-0/+31
|\ \ \ \ \ \ | |_|/ / / / |/| | | | |
| * | | | | Fix image delete multiple arguments errorsunyajing2016-06-131-0/+31
| | |_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix image delete command, support processing multiple arguments delete error. Fix doc/source/command-errors.rst, make the msg format correct. Change-Id: Icbe347fe077bc148bf71ea8f7399b0e934b7cdf9 Partially-Implements: blueprint multi-argument-image
* | | | | Merge "osc-lib: command"Jenkins2016-06-141-1/+1
|\ \ \ \ \ | | |/ / / | |/| | |
| * | | | osc-lib: commandDean Troyer2016-06-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Leave command.py and test_command.py as a sanity check during the deprecation period. Change-Id: I24e1b755cbfbcbcaeb5273ec0c9706b82384fc85
* | | | | Merge "osc-lib: parseractions"Jenkins2016-06-141-0/+3
|\ \ \ \ \ | |/ / / /
| * | | | osc-lib: parseractionsDean Troyer2016-06-131-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Leave parseractions.py and test_parseractions.py as a sanity check during the deprecation period. Change-Id: I1a7469b6d872284e0276502a1a287bc0b87f8f83
* | | | | Merge "osc-lib: logs"Jenkins2016-06-141-6/+9
|\ \ \ \ \ | |/ / / /
| * | | | osc-lib: logsDean Troyer2016-06-131-6/+9
| | | | | | | | | | | | | | | | | | | | Change-Id: I2a4d40cd72cc22e97a600751ae29c2309ebed28b
* | | | | Merge "Fix errors in flavor unit tests"Jenkins2016-06-141-24/+9
|\ \ \ \ \ | |/ / / / |/| | | |
| * | | | Fix errors in flavor unit testsTang Chen2016-06-131-24/+9
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch fixes the problems below: 1. flavor.unset_keys() is not checked in flavor unit tests. So check them in the tests. 2. test_flavor_unset_no_project makes no sense. It is OK to specify ``--project ''`` without raising any exception. It can pass because in the test, we set nither project nor property. So remove this test. Change-Id: I04e537349936343b6d8c85b06bc6d0ba6bd41d6f
* | | | osc-lib: utilsDean Troyer2016-06-1324-434/+41
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use osc-lib directly for utils. Leave openstackclient.common.utils for deprecation period. Change-Id: I5bd9579abc4e07f45219ccd0565626e6667472f7
* | | | osc-lib: exceptionsDean Troyer2016-06-1323-26/+46
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use osc-lib directly for exceptions. Leave openstackclient.common.exceptions for deprecation period. Change-Id: Iea3e862302372e1b31ccd27f69db59b4953ca828
* | | | Moving authentication from keystoneclient to keystoneauthNavid Pustchi2016-06-099-69/+237
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently OpenStackClient uses keystoneclient for authentication. This change will update OpenStackClient to use keystoneauth for authentication. All dependant test have been updated. Updating how auth_ref is set in the tests to use KSA fixtures had some racy side-effects. The user_role_list tests failed when they picked up an auth_ref that was a fixture. This exposed a weakness in ListUserRole that needed to be fixed at the same time re handling of unscoped tokens and options. Change-Id: I4ddb2dbbb3bf2ab37494468eaf65cef9213a6e00 Closes-Bug: 1533369
* | | Merge "Make set/unset commands in network return normally when nothing ↵Jenkins2016-06-096-15/+50
|\ \ \ | | | | | | | | | | | | specified"
| * | | Make set/unset commands in network return normally when nothing specifiedTang Chen2016-06-086-15/+50
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | set/unset commands should ends up normally instead of raising an exception when nothing is specified to modify. The main reason is: When nothing is specified, the command sets/unsets nothing, which is a normal behavior, and ends up normally. No API call fails. No error happens. This patch also adds a releasenote for both network, and volume commands that fix patch has been merged. Change-Id: I78c348066078decd350417a431f3b8bea8fcf9ef Partial-bug: #1588588
* | | | Clean up fakes.py in volumev2Huanxuan Ao2016-06-081-188/+0
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | All of volumev2 fake classes are completed. Now the unit tests of volumev2 are using fake classes so that the old codes are useless and can be removed. Change-Id: I502a8a0b0404975744d3b208af3e95c8692e6c47