| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
| |
some "dest" argument is useless because they are
the same as the option name. So remove them.
Change-Id: Idd37e8816cf8b0833c94a5e741fdfe56602551f9
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
self.app.log is the logger in class OpenStackShell,
which should be used to record logs that have nothing
to do with any specific command.
So, use the file logger instead.
This patch also fixes some usage that doesn't follow
rules in:
http://docs.openstack.org/developer/oslo.i18n/guidelines.html
1. add variables to logger as an argument
2. do not wrap variables with str()
Change-Id: I248861a38a4de0412a080046aa7a6f6473c3e082
Implements: blueprint log-usage
|
| |
|
|
|
|
|
| |
Leave command.py and test_command.py as a sanity check during the
deprecation period.
Change-Id: I24e1b755cbfbcbcaeb5273ec0c9706b82384fc85
|
| |
|
|
|
|
|
| |
Leave parseractions.py and test_parseractions.py as a sanity check during the
deprecation period.
Change-Id: I1a7469b6d872284e0276502a1a287bc0b87f8f83
|
| |
|
|
|
|
|
|
| |
Use osc-lib directly for utils.
Leave openstackclient.common.utils for deprecation period.
Change-Id: I5bd9579abc4e07f45219ccd0565626e6667472f7
|
| |
|
|
|
|
|
|
|
|
|
| |
set/unset commands should ends up normally instead of
logging an error when nothing is specified to modify.
The main reason is: When nothing is specified, the
command sets/unsets nothing, which is a normal behavior,
and ends up normally. No API call fails. No error happens.
Change-Id: Ib03a512650e5da90aa1ef38019772448383d0d33
Partial-bug: #1588588
|
| |
|
|
| |
Change-Id: I98fbc959034fe0530966291643b381855801de20
|
| |
|
|
|
|
|
|
|
| |
This formats the volume command help text consistent with the rest of OSC,
adds some reference targets and some explanation text to some commands.
No functional changes have been made, only cosmetic/help output.
Change-Id: Ib86ec3ca58bdea5f33078ced3ec3583b2be0e89a
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Previously each command logs take_action parameters explicitly
by using @utils.log_method decorator or log.debug().
Some commands have no logging.
This commit calls a logger in the base class and
drops all logging definition from individual commands.
Closes-Bug: #1532294
Change-Id: I43cd0290a4353c68c075bade9571c940733da1be
|
| |
|
| |
Change-Id: I3526ecd202d0908d91305a066ad72d03cee794b5
|
| |
|
|
|
|
| |
"volume" should be "attachments".
Change-Id: I41c797f0c7cccb2727e9e6cd6424ea2f740624b7
|
| |
|
|
|
|
|
|
|
|
| |
* Add volume list tests for v1 (a copy of the v2 tests)
* Converts volume v2 tests to use Identity v3 so domains can be tested
* Add volume list (v2) tests for new options
* Re-orders volume list options (both v1 and v2) to match
* MArks the new volume list (v2) options as v2-only in doc
Change-Id: I2181b2c48cfde2147d7d0ef135322df8a81e7ce8
|
| |
|
|
|
|
|
|
|
| |
Instead of duplicating the same log statement throughout
the code, the same logic can be provided by a shared decorator
that abstracts away the logging capability and unifies it behind
a common function instead.
Change-Id: Icc63bced7347c8bbf0299a4c5821425a10892a79
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
The three commands below
openstack volume unset
openstack snapshot unset
openstack volume type unset
Should have --property as a required argument,
not optional. The reason is the command will not work
without --property.
Closes-Bug: #1475872
Change-Id: Ib9e29392472db38982cc2817af2dd5055f5a01ca
|
| |
|
|
|
|
|
| |
Keeping the option --snapshot-id hidden for backward compatibility.
Change-Id: Iefa0aed9be255a5626a9bbb7db77911ef5ca8595
Closes-Bug: #1418742
|
| |
|
|
|
|
|
| |
Added test for Volume Set as well.
Change-Id: I8e6794f67b160ca328fcafa8f1d67138b4f3becd
Closes-Bug: #1415182
|
| |
|
|
|
|
|
|
| |
Create a --size option for volume set, so the user may extend
a volume's size.
Change-Id: Ic8d3396d788a14ea1e10bf1da73edfd7f5d85070
Closes-Bug: #1413954
|
| |
|
|
| |
Change-Id: Id1e500d5fb19ffdeb0d1bde9e22c3143c0873d0c
|
| |\ |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
Previously, no data was being returned for the 'attached to' field
when listing volumes. Dig into the the returned array to format
the column.
Change-Id: Iebd79e5ddcb4a335703d9b2675aa7128995de918
Closes-Bug: #1404931
|
| |/
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is part1, add support for these objects:
compute.server
imagev1.image
imagev2.image
network.network
volume.volume
volume.backup
volume.snapshot
Closes-Bug: #1400597
Change-Id: Ice21fee85203a8a55417e0ead8b509b8fd6705c1
|
| |
|
|
|
|
|
| |
'volume create --image' should allow an image name to be used.
Closes-Bug: #1383333
Change-Id: I996d46db321eef2d75c3d19b480319f8a78c09b3
|
| |
|
|
| |
Change-Id: I2b21bc904e35c1cc50da369d148e607fe3e8cf90
|
| |
|
|
|
|
|
|
| |
There are files containing string format arguments inside
logging messages. Using logging function parameters should
be preferred.
Change-Id: Ic749ac9eb55564ed631d57055a5a4dfc3aebd169
|
| |
|
|
|
|
|
| |
This makes it consistent with the other --type options in OSC. Also
add a few more volume_create tests.
Change-Id: I50ef927932cabf157ecdfd6c4faa1914b4fdf413
|
| |
|
|
|
|
|
|
|
|
| |
This fixes some errors and inconsistencies I found reviewing the
help strings:
* Capitalize help strings
* Add missing space between words (in multi-line strings)
* Improve wording
Change-Id: I2fb31ab4191c330146e31c1a9651115a6657769a
|
| |
|
|
|
|
|
|
|
| |
This required https://review.openstack.org/26323 in keystoneclient,
merged long ago...
Also adds some tests for 'volume create'
Change-Id: I55bededbc20b5dcf2833c59eb2b6b069703d8a9a
|
| |
|
|
|
|
|
| |
Mostly options and help strings:
* image, server, project usage, volume
Change-Id: I788b0660f8c2daacde53c20a72dd1afc60cf5159
|
| |
|
|
|
|
|
|
|
|
|
| |
* use six.iteritems()
* replace basestring with six.string_types
* convert print statements to functions (they're all debugging and should
be removed eventually anyway)
* clean up OpenStack copyright: LLC -> Foundation
Change-Id: Icb14212bcb408e63816bfec3922a697bc1a6c946
|
| |
|
|
|
|
|
|
|
|
| |
* Reformat default dict output to key='value' using utils.format_dict()
* Changes utils.get_item_properties() to pass the specific field to
the formatter function rather than the entire resource object, this
allows the formatter to handle multiple attributes.
* Updates server, volume, volume type commands
Change-Id: I90eebf6b84ae200532f09cd925f371598ea54a64
|
| |
|
|
|
|
|
|
|
|
|
| |
As discussed in https://review.openstack.org/#/c/36352/ for each
command, we were setting api = identity or volume... etc,
this was for an old way of calling commands that are is no longer
used.
Also removed openstackclient/common/command.py
Change-Id: I2705f35d343f2ae729dc22d6aed0b852b2f8ca19
|
| |
|
|
|
|
|
|
|
|
|
| |
Basic cleanups:
* change metadata to property
* add new KeyValueAction to parse the property options
* multiple properties can be set using multiple --property args
* consistent formatting
* do lookups for volume args
Change-Id: Ib6c43f01ad46b395aee8c61e886f42e2a5f5573e
|
| |
|
|
| |
Change-Id: I454cbe685dc5afa0a09ecc976a90d6eb6bc57d14
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Now able to pass metadata to the create method,
as well as update it with set, and remove it with unset.
I'm currently passing it as an optional param like the following:
--meta-data=key1=value1
which seems weird, what about
--meta-data=key1:value1
I'd have to update type too if that is the case.
Change-Id: I0fc8398768da015c1f53c5c564c68a2cfb53e778
|
| |
|
|
|
|
| |
Added --name, --all-tenants, and --status as search params
Change-Id: Ibaa2a7f6862c2ff7dbe24f6bea971db3e70bc120
|
| |
|
|
|
|
|
|
|
| |
Again, looking thorouhgly through cinders commands, i noticed
an force-delete command, which was for volumes only.
Decided it would work best as an optional argument for the
regular delete case
Change-Id: I9de6040ea0ad71c2a9c8edc7be18779d39e7ede0
|
|
|
fix with dtroyer's comments
rebase
fix with dhellmann's comments
create/list/delete/show/set for volume commands
Change-Id: Id8236685d815dbf73873bab2363d82274a9aa556
|