summaryrefslogtreecommitdiff
path: root/openstackclient/volume/v1
Commit message (Collapse)AuthorAgeFilesLines
* Merge "Fix faulthy state argument choice"5.1.0Zuul2020-03-241-2/+2
|\
| * Fix faulthy state argument choiceBram Verschueren2019-12-191-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | The correct state name for a failing volume snapshot deletion is 'error_deleting' instead of 'error-deleting'. [1] [1] https://opendev.org/openstack/cinder/src/commit/89d6a5042fcb2ede5a0b1112d72fae805ea52fcd/cinder/objects/fields.py#L126 Task: #37844 Story: #2007037 Change-Id: Ia99900ece4f1cd29769b22ddaa3965789d719556
* | Replace six.iteritems() with .items()lihaijing2020-01-096-19/+13
|/ | | | | | | | | | | | | | | | 1. As mentioned in [1], we should avoid using six.iteritems to achieve iterators. We can use dict.items instead, as it will return iterators in PY3 as well. And dict.items/keys will more readable. 2. In py2, the performance about list should be negligible, see the link [2]. [1] https://wiki.openstack.org/wiki/Python3 [2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html Co-Authored-By: Akihiro Motoki <amotoki@gmail.com> Change-Id: I4b9edb326444264c0f6c4ad281acaac356a07e85 Implements: blueprint replace-iteritems-with-items
* Use cliff formattable columns in volume v1 commandsAkihiro Motoki2019-06-225-67/+167
| | | | | | | Partial-Bug: #1687955 Partially implement blueprint osc-formattable-columns Change-Id: Ib4c5798171e32a8ddc08a37ee1d416e366a71d76
* Remove deprecated volume commands and argsSean McGinnis2019-05-203-423/+2
| | | | | | | | | | | | | | | | | | | | | The following were deprecated over two years ago and can now be removed: * Remove ``backup`` commands in favor of ``volume backup`` * Remove ``snapshot`` commands in favor of ``volume snapshot`` * Remove ``volume create`` options ``--project``, ``--user`` and ``--multi-attach`` * Use of an auth-key positional argument in volume transfers * ``volume transfer request`` no longer accepts 'auth_key' as a positional arg, ``--auth-key`` is now required Internal (non-user-visible) * Rename backup.py to volume_backup.py for Volume v1 and v2, update tests These are backwards incompatible changes and will require a major version bump after they are merged. Change-Id: I94aa7a9824e44f9585ffb45e5e7637b9588539b4 Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com> Signed-off-by: Dean Troyer <dtroyer@gmail.com>
* Update help text for encryption providerBrianna Poulos2018-02-231-4/+4
| | | | | | | | | The volume encryption provider no longer uses class names. Instead, 'luks' and 'plain' are used. This patch updates the help text for the volume encryption provider to use the new encryption provider format constants. Change-Id: I2911098505a99658e04ac4008e5f3e857db81f95
* Replace "Display Name" by "Name" in volume listRui Chen2017-05-261-4/+20
| | | | | | | | | | | | | | | | | | Current "volume list --name" command use "display_name" as search_opts to send to cinder API, and show the result table with "Display Name" column title in osc, cinder list API support "name" as search opts too, and there is "name" attribute in volume response body, so we can replace all "Display Name" by "Name" in order to keep "volume list" command consistent with other commands, like: server list, network list and so on, only use "Name" attribute for all objects. Support a mapping for volume list -c "Display Name" (Volume v1 and v2) and volume create/show -c "display_name" (Volume v1) for minimal backward compatibility until R release. Change-Id: I120be0118e7bb30093b4237c5eeb69a9eedef077 Closes-Bug: #1657956 Depends-On: I1fb62219b092346ea380099811cbd082cae5bafe
* Fix volume qos spec listDean Troyer2017-04-281-5/+14
| | | | | | | | | | | | | | | This has been sporadically failing in functional tests due to the way the volume qos spec list command calls get_associations() for each spec. When tests run in parallel occasionally a spec from another test is present in the list returned and is deleted before the get_associations() call is made, causing a NotFound exception. We should just keep going when this occurs. * make v1 match v2 * add tests to ensure the exception is being caught and handled Closes-Bug: #1687083 Change-Id: If2d17c1deb53d293fc2c7f0c527a4e4ef6f69976
* Fix NoneType error for volume snapshot create commandHuanxuan Ao2017-04-261-2/+1
| | | | | | | | | | | | | In volume snapshot command, <volume> is the same as <snapshot-name> when --volume is not specified, but <volume> cannot be None, so when <snapshot-name> is not specified (<snapshot-name> is None), a NoneType error appears. So make <snapshot-name> no longer optional, it should be always present. Change-Id: I3d9f10753a8ef601e70816421c160598e2cc811f Closes-bug: #1659894
* Help/docs cleanups: marker, limit, ip-address metavarsDean Troyer2017-04-041-1/+1
| | | | | | | | | | | | Cleanup help strings and docs for clarity and to keep things consistent: * --limit metavar should be <num-resource> to indicate what is being counted * --marker metavar should be <resource> or <resource-id> to indicate the type of value being specified * <*-ip-address> metavars should be just <ip-address> as there is no difference in format between fixed and floating IPs * Move all occurances of '(name or ID)' to end of help text Change-Id: I2c31746ed6ded3845244e03e57d809f8bc0e6b9d
* Fix volume transfers request commandsDean Troyer2017-03-271-18/+57
| | | | | | | | | | | | * Fix volume transfer request accept to actually not crash when trying to call Volume API. * Fix volume transfer request accept syntax to have only one positional argument, which is the ID of the resource in the command * Change the output column order in volume transfer request list to have ID followed by Name then the remaining columns. Closes-bug: 1633582 Change-Id: I5cc005f039d171cc70859f60e7fe649b09ead229
* Merge "Support --no-property in "volume set" command"Jenkins2017-03-061-0/+18
|\
| * Support --no-property in "volume set" commandzhiyong.dai2017-02-231-0/+18
| | | | | | | | | | | | | | Add "--no-property" option to "volume set" command in v1 and v2 and update the test cases. Change-Id: Id5660f23b3b2d9aa72f4c16b19ce83f3f7ed2fa4
* | Fix properties format for volume qos in volume v1Huanxuan Ao2017-02-211-3/+8
| | | | | | | | | | | | | | | | | | | | | | | | Notice that patch [1] fixed the error of properties format for volume qos in volume v2, but there is the same bug in volume v1, and the patch missed that, so fix the problem in v1 as well [1] https://review.openstack.org/#/c/421065/ Partial-Bug: #1656767 Change-Id: I156bf13d164dbd0d0a7ce394964176718c4ff0e5
* | Merge "Add "encryption-*" options in volume type commands"Jenkins2017-02-181-8/+213
|\ \ | |/ |/|
| * Add "encryption-*" options in volume type commandsHuanxuan Ao2017-01-141-8/+213
| | | | | | | | | | | | | | | | | | | | | | | | Add "--encryption-provider", "--encryption-cipher", "--encryption-key-size" and "--encryption-control-location" options to "volume type set" and "volume type create" commands. Add "--encryption-type" option to "volume type unset", "volume type list" and "volume type show" commands. Change-Id: I3572635d5913d971a723a62d7790ffe0f20ec39a Implements: bp cinder-command-support Closes-Bug: #1651117
* | Support "--no-property" option in volume snapshot setzhiyong.dai2017-01-251-0/+20
|/ | | | | | | | | | | Supporting "--no-property" option will apply user a convenient way to clean all properties of volume snapshot in a short command, and this kind of behavior is the recommended way to devref. The patch adds "--no-property" option in "volume snapshot set" command, and update related test cases and devref document. Change-Id: I5f10cc2b5814553699920c4343995b2e11416e4e Implements: blueprint allow-overwrite-set-options
* Update the description formatzhiyong.dai2017-01-031-6/+6
| | | | | | | | In network_qos_rule_type.py, network_service_provider.py, server.py and volume_snapshot.py, the description format is using """ """. In this patch, the former format is replaced with "_description = _( )". Change-Id: I6863b01d3534e033df745070037ee45286745c92
* Add some options to "volume create" commandjiahui.qiang2016-12-061-0/+38
| | | | | | | | Add "--bootable", "--non-bootable", "--read-only" and "--read-write" options to "volume create" command for setting some attributes at the time of crration. Change-Id: I71b4e9fccb4ee0ab1a90e7179d6d2d34dbbae909 Implements: bp cinder-command-support
* Add options to "volume snapshot list" commandjiahui.qiang2016-11-261-2/+32
| | | | | | | | Add "--name", "--status" and "--volume" options to "volume snapshot list" command for filtering results. Change-Id: I72db1abce7701f31598deec34801a4d1f5713870 Closes-Bug:#1645252
* Merge "Refactor "snapshot" commands"Jenkins2016-12-032-0/+323
|\
| * Refactor "snapshot" commandsHuanxuan Ao2016-11-032-0/+323
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1.change the command name ``snapshot create/delete/list/ show/set/unset`` to ``volume snapshot create/delete/list/ show/set/unset``. 2.change the optional parameter "--name <name>" to a positional parameter "<snapshot-name>"; Change the positional parameter "<volume>" to a optional parameter "--volume <volume>" Change-Id: If03276ecdf6f0d96893d5ecf91c2aaa64929cff3 Implements: bp backup-snapshot-renamed-for-volume-resource Co-Authored-By: Sheel Rana <ranasheel2000@gmail.com>
* | Add "Is Public" column in volume type listHuanxuan Ao2016-11-221-3/+3
| | | | | | | | | | | | | | | | | | | | I think admin users will like to see the "Is Public" column in volume type list since they can know the volume type is public or private, so add "Is Public" column in volume type list Change-Id: I3f6e297a7adf82a275debbd87d2c4da415aa1360 Closes-Bug: #1643861
* | translate all command help strings3.4.0Steve Martinelli2016-11-177-44/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Leverage the new cliff command class attribute (_description) to get the help of a command, this allows us to mark strings for translation. We could not do this before since the help was grabbed from the docstring. This also depends on a new release of cliff and a bump to the minimum level in osc's requirements. Closes-Bug: 1636209 Depends-On: Id915f6aa7d95a0ff3dc6e2ceaac5decb3f3bf0da Change-Id: I8673080bb5625e8e3c499feaefd42dfc7121e96f
* | Merge "Add "--read-only" and "--read-write" options in "volume set""Jenkins2016-11-101-12/+52
|\ \
| * | Add "--read-only" and "--read-write" options in "volume set"Huanxuan Ao2016-10-181-12/+52
| |/ | | | | | | | | | | | | | | Add "--read-only" and "--read-write" options in "volume set" command to set volume access mode. Implements: bp cinder-command-support Change-Id: I76ba85c7d3ff0eb026a9cbd794368d8b2b0d17fe
* | Merge "Add "volume migrate" command"Jenkins2016-11-101-0/+31
|\ \
| * | Add "volume migrate" commandHuanxuan Ao2016-10-181-0/+31
| |/ | | | | | | | | | | | | | | Add "volume migrate" command in volume v1 and v2 to support migrating volume to a new host Change-Id: Ie4e6037171a31a872006a13f9fd1e15eaa627c26 Implements: bp cinder-command-support
* | Add 'all-projects' option to 'volume backup list'Jordan Pittier2016-11-081-0/+7
| | | | | | | | | | | | | | Similar to what 'volume list --all-projects' does, 'volume backup list --all-projects' list volume backups accross all projects. Change-Id: Id5dda9b5adc822c4ddfb2dda339946d3322858e2
* | Add options to "volume backup list" commandHuanxuan Ao2016-11-081-2/+34
|/ | | | | | | | | Add "--name", "--status", "--volume", "--marker" (v2 only) and "--limit" (v2 only) options to "volume backup list" command Change-Id: If20cb7650f2359d393ee314d9e055a8659c73009 Closes-Bug: #1612484 Closes-Bug: #1639712
* Add and modify options for "volume create" commandHuanxuan Ao2016-09-281-8/+22
| | | | | | | | | | | | | | 1.Add mutually exclusive options into a mutually exclusive group. 2.Add "--source-replicated", "--consistency-group", "--hint" and "multi-attach" options 3.Make --size option to be optional under some cases Closes-Bug: #1568005 Closes-Bug: #1627913 Implements: bp implement-cinder-features Co-Authored-By: Roman Vasilets <rvasilets@mirantis.com> Change-Id: I2c4c3073195d33774e477f4d7f22e383b14b41dd
* Fix unset commands to pass normally when nothing specifiedHuanxuan Ao2016-09-233-5/+0
| | | | | | | | | | | | | | | | After I found this problem appear in "volume unset", I checked all the volume command and also found some same problems. This patch fix them all. The main reason of we ignored this problem before is there was not any tests for it. So I add tests for "nothing unset" for them all to test and aviod this problem. Also, I add unit tests for all snapshot commands in volume v1 by the way in this patch. We will need more tests to avoid some ignored problem. Change-Id: I46775f24643d715e168b30785b8b531c0431a55b Partial-bug: #1588588
* Implement "volume transfer request show/accept" commandHuanxuan Ao2016-09-221-0/+49
| | | | | | | | | | | | Add "volume transfer request show" and "volume transfer accept" commands in volume v1 and v2. Also add the unit tests, docs, release note and functional tests Implements: bp cinder-command-support Co-Authored-By: Sheel Rana <ranasheel2000@gmail.com> Change-Id: I5787fc486b3401307125caa316f517b9c96a95a5
* Fix "volume unset" command pass normally when nothing specifiedHuanxuan Ao2016-09-211-2/+0
| | | | | | | | | | | | When nothing specified in "volume unset" command, there will be an error message says that the "--properties" option is required, it is unusual behaviour, this patch fix it and also add unit test for it. Also, this patch add unit test for "volume show" command by the way. Change-Id: I5b5d587670acf0af4262b8521292455bf9f60fe5 Partial-bug: #1588588
* Merge "Support mark volume as bootable in volume set"Jenkins2016-09-141-1/+17
|\
| * Support mark volume as bootable in volume setqtang2016-09-141-1/+17
| | | | | | | | | | | | | | | | Add --bootable | --non-bootable option in volume set to mark or unmark volume as bootable. Change-Id: Ifa6c2dd1642202f55b6d50e3b8614d3513d488f6 Closes-Bug:#1535704
* | Merge "Do not show "os-volume-type-access:is_public" property of volume type"Jenkins2016-09-141-3/+3
|\ \
| * | Do not show "os-volume-type-access:is_public" property of volume typeHuanxuan Ao2016-09-071-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | "os-volume-type-access:is_public" property is the same as "is_public" property in volume type object. So stop showing "os-volume-type-access:is_public" property and leave "is_public" property only. Change-Id: Ic78a9ee69b0ab356edff18cdb4c46fc24b495d2b Closes-Bug: #1620922
* | | Trivial: Rename ListTransferRequests to ListTransferRequestTang Chen2016-09-121-2/+2
| |/ |/| | | | | | | | | The class name should use plural. Change-Id: I2de2489ff9aa60c2d1bf12743cbd41f2091739ca
* | Implement "volume transfer request delete" commandHuanxuan Ao2016-09-111-0/+41
| | | | | | | | | | | | | | | | | | | | Add "volume transfer request delete" command in volume v1 and v2. Also add the unit tests, docs, release note and functional tests Change-Id: Ic3d375bc8df3312fac53c1800d75f48376b8c91c Implements: bp cinder-command-support Co-Authored-By: Sheel Rana <ranasheel2000@gmail.com>
* | Implement "volume transfer request create" commandHuanxuan Ao2016-09-111-1/+31
| | | | | | | | | | | | | | | | | | | | Add "volume transfer request create" command in volume v1 and v2. Also add the unit tests, docs, release note and functional tests Change-Id: If362df1acf214efdf6ba129cd917d33eb54e1030 Implements: bp cinder-command-support Co-Authored-By: Sheel Rana <ranasheel2000@gmail.com>
* | Merge "Error handling of multi REST API calls for "snapshot set" command"Jenkins2016-09-111-3/+17
|\ \
| * | Error handling of multi REST API calls for "snapshot set" commandHuanxuan Ao2016-09-111-4/+23
| |/ | | | | | | | | | | | | | | | | Support multi REST API calls error handling for "snapshot set" command follow the rule in doc/source/command-errors.rst. Also add a unit test for testing the error handling Change-Id: I0c6214271bc54a25b051c0a62438c3344c8b51d7
* | Merge "Add "--limit" and "--marker" options to "volume list" command"Jenkins2016-09-111-1/+11
|\ \
| * | Add "--limit" and "--marker" options to "volume list" commandHuanxuan Ao2016-09-111-1/+11
| |/ | | | | | | | | | | | | | | | | Add ``--limit`` option to ``volume list`` command in volume v1, add ``--limit`` and ``--marker`` options to ``volume list`` command in volume v2. Change-Id: I327a252aa83ed84166da99cf6aa80334e0e6dd44 Partial-Bug: #1612484
* | Support error handling for delete commands in volume v1Huanxuan Ao2016-09-114-18/+90
|/ | | | | | | | | Some delete commands in volume v1 support multi delete but do not support error handling, this patch fixes them, and this patch also refactor (or add new) unit tests for some delete commands in volume v1. Change-Id: Ia8177698f8733cfe75ea0ff00eee8fdc0820f62e
* Add "volume service set" commandHuanxuan Ao2016-08-171-0/+56
| | | | | | | | Add "volume service set" command in volume v1 and v2 (v1 is the same as v2) to disable or enable volume service. Change-Id: Ibb2db7e93b24cb2e0d2a7c28b6fd8bcc851b8d2f Closes-Bug: #1613597
* Rename backup commands in volume v1 and v2Huanxuan Ao2016-08-111-15/+101
| | | | | | | | | | | | | | | | | | | | | Backup commands are used only in volume service now, but "backup" is too generic, users may not know the commands are used for volume from the commands name. By seeing the command name, users can only see the "backup" but do not know which object the backup commands work for. It may confuse users. I think rename "backup" to "volume backup" can depict resource relation and will be helpful for users to know the commands clearly. So add new commands ``volume backup create/delete/ list/show/restore`` to replace the old commands ``backup create/delete/list/show/restore``. And also deprecate old commands. Change-Id: I4f844d9bc48573eb4d17288ce6b8a90cea00d16a Implements: bp backup-snapshot-renamed-for-volume-resource Co-Authored-By: Sheel Rana <ranasheel2000@gmail.com>
* Remove useless dest of option in volume v1&v2Huanxuan Ao2016-07-111-1/+0
| | | | | | | some "dest" argument is useless because they are the same as the option name. So remove them. Change-Id: Idd37e8816cf8b0833c94a5e741fdfe56602551f9
* Merge "Add "--force" option to "volume qos delete" command"Jenkins2016-06-281-1/+7
|\
View Lorry Controller Status