summaryrefslogtreecommitdiff
path: root/openstackclient
Commit message (Collapse)AuthorAgeFilesLines
* arguments are not locale decoded into UnicodeJohn Dennis2017-01-161-2/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When the openstackclient in Python2 passes command line arguments to a subcommand it fails to pass the arguments as text (e.g. Unicode). Instead it passes the arguments as binary data encoded using the current locales encoding. An easy way to see this is trying to pass a username with a non-ASCII character. % openstack user delete ñew No user with a name or ID of 'ñew' exists. What occurs internally is when the user data is retrieved it's it properly represented in a Unicode object. However the username pased from the command line is still a str object encoded in the locales encoding (typically UTF-8). A string comparison is attempted between the encoded data from the command line and the Unicode text found in the user representation. This seldom ends well, either the comparison fails to match or a codec error is raised. There is a hard and fast rule, all text data must be stored in Unicode objects and the conversion from binary encoded text to Unicode must occur as close to the I/O boundary as possible. Python3 enforces this behavior automatically but in Python2 it is the programmers job to do so. In the past there have been attempts to fix problems deep inside internal code by attempting to decode from UTF-8. There are two problems with this approach. First, internal code has no way to accurately know what encoding was used to encode the binary data. This is way it needs to be decoded as close to the I/O source as possible because that is the best place to know the actual encoding. Guessing UTF-8 is at best a heuristic. Second, there must be a canonical representation for data "inside" the program, you don't want dozens of individual modules, classes, methods, etc. performing conversions, instead they should be able to make the assumption in what format text is represented in, the format for text data must be Unicode. This is another reason to decode as close to the I/O as possible. In Python3 the argv strings are decoded from the locales encoding by the interpreter. By the time any Python3 code sees the argv strings they will be Unicode. However in Python2 there must be explicit code added to decode the argv strings into Unicode. The conversion of sys.argv into Unicode only occurs when argv is not passed to OpenStackShell.run(). If a caller of OpenStackShell.run() supplies their own arg it is their responsiblity to assure they are passing actual text objects. Consider this a requirement of the API. Note: This patch does not contain a unittest to exercise the behavior because it is difficult to construct a test that depends on command invocation from a shell. The general structure of the unit tests is to pass fake argv into OpenStackShell.run() as if it came from a shell. Because the new code only operates when argv is not passed and defaults to sys.argv it conflicts with the unittest design. Change-Id: I779d260744728eae8455ff9dedb6e5c09c165559 Closes-Bug: 1603494 Signed-off-by: John Dennis <jdennis@redhat.com> (cherry picked from commit 756d2fac67b4128312e1d779648e62f1458b4ffc)
* Fix SSL/TLS verification for network commandsRichard Theis2017-01-161-1/+2
| | | | | | | | | | | | The network commands ignored the --insecure and --os-cacert options and OS_CACERT environment variable which prevented them from properly completing SSL/TLS verification. This resulted in the network commands failing with "An SSL error occurred." Change-Id: I15167631ef58335e1476c16b828b079e3b0f13c1 Closes-Bug: #1560157 (cherry picked from commit b5f10f43eb9fd1a046a3e80db09d8bc8c350c218)
* Merge "Trivial: Reorder unit tests in alphabetical order in volume tests"Jenkins2016-03-032-165/+165
|\
| * Trivial: Reorder unit tests in alphabetical order in volume testsTang Chen2016-03-022-165/+165
| | | | | | | | Change-Id: I622123f68e2bb53f8767069e4a717fcc34e37b5c
* | Merge "[Image] Check return value is None in image unit tests."Jenkins2016-03-022-34/+46
|\ \
| * | [Image] Check return value is None in image unit tests.Tang Chen2016-03-022-34/+46
| |/ | | | | | | | | | | | | | | | | take_action() in commands inheriting from Command returns nothing. So we should assert the return is None in the unit tests of these commands. Change-Id: I237ea772f74fa52af2e9aacd35d4b9cfb225c94c Partial-Bug: #1550636
* | Support "network create" command in nova networkTang Chen2016-03-022-21/+160
|/ | | | | | | | | | | | This patch only provide network name and subnet setting for "network create" command. The other options, such as --project which depends on identity v2 or v3, will make the unit tests too complicated. So I prefer to implement them in other patches. Change-Id: I9ec93f0af813c8fae4170c36e16bbe8f0f53cbb6 Partial-Bug: 1543672
* Merge "Clean up unnecessary import of urlparse module"Jenkins2016-03-011-6/+1
|\
| * Clean up unnecessary import of urlparse moduleYang Hongyang2016-03-011-6/+1
| | | | | | | | | | | | | | six.moves.urllib already covers the py2 and py3 compatibility issues of urlparse module, use six.moves.urllib.parse.urlparse is enough. Change-Id: I785f4f872850e5d770fdcf4c0d3392be3978cc4a
* | Merge "Fix regression in interactive client mode"Jenkins2016-03-011-1/+1
|\ \
| * | Fix regression in interactive client modeDina Belova2016-03-011-1/+1
| |/ | | | | | | | | | | | | | | Fix typo introduced in OSprofiler intergation commit, that leaded to non-working interactive mode of the CLI client. Change-Id: If5dfc90dbbe64d4665c3e33e936f0cc674738351 Closes-Bug: 1551160
* | Merge "Trivial: Update image_list v2 docs"Jenkins2016-03-011-4/+7
|\ \ | |/ |/|
| * Trivial: Update image_list v2 docsYang Hongyang2016-03-011-4/+7
| | | | | | | | | | | | | | This api doc is clearly copied from v1, we should update it to reflact v2 API. Added 'shared' param description. Change-Id: I73d36e3a2a0448c28edab788a9340fd46177f8ef
* | Merge "TrivialOrder: Rearrange Class Names"Jenkins2016-03-012-47/+47
|\ \
| * | TrivialOrder: Rearrange Class Namesreedip2016-03-012-47/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As per the comment given by Steve Martinelli in https://review.openstack.org/#/c/278209/ , the following patch just rearranges the classes as per the Alphabetical order. TrivialFix Change-Id: Ib8f0f703df4ef7d7ee6180ff8bd8a47062ae5b0f
* | | Merge "Fix return value of "image set" command"Jenkins2016-03-011-1/+1
|\ \ \
| * | | Fix return value of "image set" commandTang Chen2016-02-291-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | "image set" command should return None. But in one path, it returns ({}, {}). This patch fixes this. Change-Id: I3847e661cb7e89863921a3f0a859d9b1a8077ede
* | | | Merge "Make SetAggregate inherit from cliff.Command"Jenkins2016-03-011-14/+14
|\ \ \ \
| * | | | Make SetAggregate inherit from cliff.CommandTang Chen2016-02-271-14/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | set/unset comamnd classes should inherit from cliff.Command class. Also, this patch adds functional tests for aggregate. And also, use utils.format_dict() to format the output of the properties dict. Change-Id: Idb50bef8990da95666960e2414dfd7c9be234bba Partial-bug: #1519503 Closes-Bug: 1546065
* | | | | Merge "Trivial: Reorder flavor op order in flavor.py"Jenkins2016-03-011-24/+24
|\ \ \ \ \
| * | | | | Trivial: Reorder flavor op order in flavor.pyYang Hongyang2016-03-011-24/+24
| | |_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | Classes should be in alphabetical order. Change-Id: I7a35c3a2dd6d36c49f0d54dec5c14609a9168bd0
* | | | | Merge "Refactor security group list to use SDK"Jenkins2016-03-015-125/+256
|\ \ \ \ \ | |_|_|_|/ |/| | | |
| * | | | Refactor security group list to use SDKRichard Theis2016-02-295-125/+256
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Refactored the 'os security group list' command to use the SDK when neutron is enabled, but continue to use the nova client when nova network is enabled. This refactor also removes the logic for displaying project names instead of project IDs when the --all-projects option is specified. This logic was removed because it is inconsistent with the other network commands. Since neutron will always display security groups across all projects for an admin, the --all-projects option is now hidden when neutron is enabled and the Project column is always displayed. Change-Id: I934a1f5084ef3c5f929d0ffd38ebf5064d799941 Partial-Bug: #1519511 Related-to: blueprint neutron-client
* | | | | Merge "fix: Exception message includes unnecessary class args"Jenkins2016-03-011-2/+2
|\ \ \ \ \
| * | | | | fix: Exception message includes unnecessary class argsJas2016-02-291-2/+2
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix misusages of ArgumentTypeError which causes a tuple of class instance and error message string to be printed rather than just the error message string itsself. Change-Id: I0e997f86bb6603930cc92e90efcb48155f62ffb5 Closes-bug: #1551426
* | | | | Merge "Subnet: Add "subnet delete" command using SDK"Jenkins2016-03-012-0/+47
|\ \ \ \ \
| * | | | | Subnet: Add "subnet delete" command using SDKreedip2016-03-012-0/+47
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch adds "subnet delete" command to osc using sdk. Change-Id: I6be27406b16909c6db2b95417355be302e218a8d Implements: blueprint neutron-client Closes-bug: #1542362
* | | | | Merge "Make SetAgent inherit from cliff.Command"Jenkins2016-03-011-3/+2
|\ \ \ \ \ | | |_|/ / | |/| | |
| * | | | Make SetAgent inherit from cliff.CommandTang Chen2016-02-271-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | set/unset command classes should inherit from cliff.Command class. Also, this patch adds functional tests for compute agent. Change-Id: I25eafffd1167f82aa0d430628c22dee7516b1e19 Partial-Bug: 1546065
* | | | | Merge "Trivial: Reorder unit tests in test_type.py"Jenkins2016-03-011-55/+58
|\ \ \ \ \ | |_|/ / / |/| | | |
| * | | | Trivial: Reorder unit tests in test_type.pyTang Chen2016-02-291-55/+58
| | |_|/ | |/| | | | | | | | | | | | | | | | | | Unit test classes should be in alphabetical order. Change-Id: Ie741e1c170d8cc361d95d036115d0952e5108088
* | | | Merge "take_action() method from command.Command shouldn't return"Jenkins2016-02-2916-43/+18
|\ \ \ \ | |_|_|/ |/| | |
| * | | take_action() method from command.Command shouldn't returnMohan Muppidi2016-02-2916-43/+18
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | command.Command and command.Showone are base classes implemented in cliff framework. Showone extends Command to allow take_action() to return data to be formatted using a user-selectable formatter. Most of the classes which are extended from Command in openstackclient/identity/v3/ in some cases return data or return nothing where it is not necessary, this commit fixes most of them. Change-Id: I84c72ea4d6680f8bdbef5449316dd9a8af8c8286 Closes-Bug: 1550892
* | | Merge "Make SetSecurityGroup inherit from cliff.Command"Jenkins2016-02-291-10/+3
|\ \ \ | | |/ | |/|
| * | Make SetSecurityGroup inherit from cliff.CommandTang Chen2016-02-271-10/+3
| | | | | | | | | | | | | | | | | | set/unset comamnd classes should inherit from cliff.Command class. Change-Id: Ie28711ac8823dc9eb13cf83877864ca436b928bc Partial-Bug: 1546065
* | | Merge "Make SetFlavor and UnsetFlavor inherit from cliff.Command"Jenkins2016-02-292-28/+10
|\ \ \ | |/ /
| * | Make SetFlavor and UnsetFlavor inherit from cliff.CommandTang Chen2016-02-272-28/+10
| | | | | | | | | | | | | | | | | | set/unset comamnd classes should inherit from cliff.Command class. Change-Id: I54e5608ac0768d7d94b7f7d516ea1948daefdc1b Partial-Bug: 1546065
* | | Merge "[Compute] Check return value is None in compute unit tests."Jenkins2016-02-293-45/+33
|\ \ \
| * | | [Compute] Check return value is None in compute unit tests.Tang Chen2016-02-273-45/+33
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | take_action() in commands inheriting from Command returns nothing. So we should assert the return is None in the unit tests of these commands. Change-Id: I953480ecff3b5beb12255d866d0e1df45f130efd Partial-Bug: #1550636
* | | Router: Add --route and --clear-routes options to "router set" commandTang Chen2016-02-272-4/+83
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | --route option is used to set routes to the router. It is used like this: --route destination=subnet,gateway=ip-address destination: destination subnet CIDR gateway: nexthop IP address --clear-routes is used to clear all routes on the router. Change-Id: I97ce4871113c684b29c98cdad4dec9cc80ed20f7 Implements: blueprint neutron-client Partial-bug: #1519503
* | | Add MultiKeyValueAction to custom parser actionTang Chen2016-02-272-0/+210
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | Class MultiKeyValueAction will be used to parse arguments like this: --route destination=xxx,gateway=xxx --route destination=yyy,gateway=yyy The result is a list like this: [{destination:xxx, gateway:xxx}, {destination:yyy, gateway:yyy}] This action also contain validation of the parameters. Change-Id: Ie3aa8635c6a13fc2e429fe6922acd681dc7244cf
* | Merge "Add shell --profile option to trigger osprofiler from CLI"Jenkins2016-02-262-0/+52
|\ \ | |/ |/|
| * Add shell --profile option to trigger osprofiler from CLIDina Belova2016-02-252-0/+52
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will allow to trigger profiling of various services that allow it currently and which APIs support is added to openstackclient. Cinder and Glance have osprofiler support already, Nova and Keystone are in progress. To use this functionality osprofiler (and its storage backend) needs to be installed in the environment. If so, you will be able to trigger profiling via the following command, for example: $ openstack --profile SECRET_KEY user list At the end of output there will be message with <trace_id>, and to plot nice HTML graphs the following command should be used: $ osprofiler trace show <trace_id> --html --out result.html Related Keystone change: https://review.openstack.org/#/c/103368/ Related Nova change: https://review.openstack.org/#/c/254703/ The similar change to the keystoneclient (https://review.openstack.org/#/c/255308/) was abandoned as new CLI extenstions are not more accepted to python-keystoneclient. Change-Id: I3d6ac613e5da70619d0a4781e5d066fde073b407
* | Merge "Defaults are ignored with flake8"Jenkins2016-02-262-2/+3
|\ \
| * | Defaults are ignored with flake8Tom Cocozzello2016-02-232-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If “ignore” is not set under flake8 in the tox.ini file there there are defaults set to be ignored. The depended patch fixes many of the problems. Change-Id: Ieed2fe1c4654e201d3fe6d40ef93e247ee736f8b Doc: http://flake8.readthedocs.org/en/latest/config.html#default Depends-On: I935ab48e7c5bac5f88ecdb3a05f73fb44fc9f41d Closes-Bug: #1548910
* | | Merge "Floating IP: Neutron support for "ip floating show" command"Jenkins2016-02-254-2/+158
|\ \ \
| * | | Floating IP: Neutron support for "ip floating show" commandTang Chen2016-02-244-2/+158
| | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I30350076621c83c758927444e5f8bcc2b7d0fc74 Partial-Bug: 1519502 Related-to: blueprint neutron-client
* | | | Merge "Fixed a bunch of spacing"Jenkins2016-02-2547-76/+183
|\ \ \ \ | | |/ / | |/| |
| * | | Fixed a bunch of spacingBrandon Palm2016-02-2347-76/+183
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Nothing too complicated here. I fixed a bunch of spacing issues that I saw in OSC. Change-Id: I935ab48e7c5bac5f88ecdb3a05f73fb44fc9f41d
* | | | Add some test cases for "server list" commandting.wang2016-02-242-27/+78
| |/ / |/| | | | | | | | | | | | | | | | | | | | Add some test cases that test 'server list' command when specifying flavor or image. Because I add some attribution to fake.py, I have to change some code in create server test. Despite all this, I think it's good for testing. Change-Id: I714deac1f6f940b790a3c20af5f7ffa724ac44d1
View Lorry Controller Status