summaryrefslogtreecommitdiff
path: root/openstackclient
Commit message (Collapse)AuthorAgeFilesLines
* Merge "Fix --image-property option in 'create server'"Zuul2020-10-012-3/+70
|\
| * Fix --image-property option in 'create server'Myeongchul Chae2020-09-102-3/+70
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There was a problem that the '-image-property' option, which can be used to create an instance, did not work as intended. I found that there were two problems with this option. First, I cannot select an image as its metadata. The second is that when there are multiple images available, the desired image may not be selected depending on the situation. This patch solves these two problems. I wrote the test case with these two problems considered together. Change-Id: Ib2745d7e067056ff4ca8bfaf6cff492d0dacb73a story: #2007860
* | Merge "Add API check for server_groups.create"Zuul2020-09-302-2/+28
|\ \
| * | Add API check for server_groups.createLewis Denny2020-08-262-2/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The policies field has been replaced with the policy field since Nova API version 2.64[1] This commit adds a check to make sure the correct field is used. [1]https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id59 Change-Id: I06d3211937d822c26070b7f8ad757c365dcbb1bb Story: #2007822 Task: #40101
* | | Merge "Add API check for server_groups.list"Zuul2020-09-303-4/+138
|\ \ \
| * | | Add API check for server_groups.listLewis Denny2020-08-213-4/+138
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The policies parameter has been replaced with the policy parameter since Nova API version 2.64[1] This commit adds a check to make sure the correct parameter is used. [1]https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id59 Change-Id: Ia37beb7790884d6d15bec45074f446e64af1a2aa Story: #2008041 Task: #40703
* | | Merge "Show words indicating booted from volume for server image"Zuul2020-09-303-8/+35
|\ \ \
| * | | Show words indicating booted from volume for server imagemelanie witt2020-08-273-8/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For a server booted from a volume, nova API does not store an image_id and instead returns an empty string. Currently, openstackclient similarly shows an empty string for Image Name and Image ID for servers booted from volumes. To aid CLI users in understanding the meaning of no image_id, we can display the string "N/A (booted from volume)" in the image field if the server was booted from a volume. Change-Id: I9c62cf6fe23b2e934dcbf5ebbf706b2705d2e424
* | | | Merge "Output correct json for security groups in 'openstack server show'"Zuul2020-09-253-21/+38
|\ \ \ \
| * | | | Output correct json for security groups in 'openstack server show'jay2020-09-143-21/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes incorrect json output for 'openstack server show -f json'. The security group json output groups all the json as one for e.g. "security_groups": "name='group1'\nname='group2'" The correct output should be "security_groups" : [{"name" : "group1"}, {"name" : "group2"}] properties and volumes_attached fields also has similar issue. Story: 2007755 Change-Id: I1b1cac716329e0530400aff782c08000b21d8e1d
* | | | | Merge "Support tagging Neutron ports on creation"Zuul2020-09-132-15/+58
|\ \ \ \ \
| * | | | | Support tagging Neutron ports on creationMiguel Lavalle2020-09-042-15/+58
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change adds support for tagging ports on creation Co-Authored-By: Slawek Kaplonski <skaplons@redhat.com> Change-Id: I3148a568664588eb2f529138f984859570c0fca1 Related-Bug: #1815933
* | | | | Merge "Add NUMA affinity policy parameter to "port""Zuul2020-09-073-0/+129
|\ \ \ \ \
| * | | | | Add NUMA affinity policy parameter to "port"Rodolfo Alonso Hernandez2020-07-313-0/+129
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Added port NUMA affinity policy parameter to "port create", "port set" and "port unset" commands. Change-Id: I48cacab275856af2911829f9b7176bb87fd039b3 Related-Bug: #1886798
* | | | | | Merge "Allow openstack flavor set to update flavor description using name"Zuul2020-09-032-1/+37
|\ \ \ \ \ \ | |_|/ / / / |/| | | | |
| * | | | | Allow openstack flavor set to update flavor description using nameGabriel Ramirez2020-06-102-1/+37
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Modified take_action() method for SetFlavor to use flavor id instead of flavor name when setting description Closes-Bug: #1844708 Story: #2007781 Task: #40019 Change-Id: If6798c89fef4c9feb4ebb460722b891f5655037d
* | | | | Merge "Bypass user and group verification in RemoveRole"Zuul2020-08-132-32/+278
|\ \ \ \ \
| * | | | | Bypass user and group verification in RemoveRoleLance Bragstad2020-08-122-32/+278
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Keystone let's users remove role assignments that reference non-existent users and groups. This is nice when keystone backs to an identity store like LDAP and users or groups are removed. Previously, openstackclient would validate the user and group existed in keystone before sending the request to delete the role assignment. This commit updates the code to bypass that validation so that users can use IDs to forcibly cleanup role assignments. Change-Id: I102b41677736bbe37a82abaa3c5b3e1faf2475d5 Story: 2006635 Task: 36848
* | | | | | Merge "Add system role assignment tests for users and groups"Zuul2020-08-061-0/+137
|\ \ \ \ \ \ | |/ / / / /
| * | | | | Add system role assignment tests for users and groupsLance Bragstad2020-07-101-0/+137
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I was writing some additional functionality and noticed these tests were missing. This commit adds tests for adding and removing system role assignments for users and groups. Change-Id: I30fdc6ec55e1eb1cfa55f4cbf92c3f001d89865f
* | | | | | Merge "Fix reverted osc-lib interface change"Zuul2020-08-031-1/+1
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | |
| * | | | | Fix reverted osc-lib interface changeRoger Luethi2020-07-231-1/+1
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The patch https://review.opendev.org/#/c/673389/ introduced a regression by changing the osc-lib interface. Two conflicting attempts to fix the regression were launched: 1) Reverting the patch. 2) The patch https://review.opendev.org/683119 changes the exception from the generic CommandError back to a specific Forbidden exception. The patch https://review.opendev.org/683118 catches this exception and passes on, i.e. re-implements the same behavior as before. The first idea was implemented, the initial patch reverted. The second idea was partially implemented. The change in python-openstackclient (683118) was merged. The change in osc-lib was approved but failed to merge because the initial change had been reverted. Now we have again a situation where the exception produced in osc-lib does not match the exception expected by the caller. It is unclear if the osc-lib interface will ever get a rebased version of https://review.opendev.org/683119 merged, so the safest way to address the issue is to also catch the exception that used to be thrown before the inital change and is again thrown after the inital change has been reverted. Change-Id: I2ea2def607ec5be112e42d53a1e660fef0cdd69c
* | | | | Delete the testcases that arent needed anymoremb711d2020-07-233-32/+0
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | The file test_examples.py has never worked since its written and and cli in the example directory are covered by other functional tests for container, flavor and object lists and they have better asserts. So, deleting the file Change-Id: Ib9af40da96e66354fe878e79a80048a58f8dd6fe
* | | | Fix compatibility issue in 5.35.3.1Felix Yan2020-07-141-1/+4
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | The offending entry point object looks like: EntryPoint(name='compute', value='openstackclient.compute.client', group='openstack.cli.base') Story: 2007917 Task: 40323 Change-Id: I0f3cc62e23efdc14203ce6645581d5ba5dbf7fa0
* | | Merge "Fix uploading an signed image does not work if private signing key is ↵5.3.0Zuul2020-07-081-0/+6
|\ \ \ | | | | | | | | | | | | encrypted"
| * | | Fix uploading an signed image does not work if private signing key is encryptedAlexander Gräb2020-07-071-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | Change-Id: Ia7c84aa7b840bf92aeb7db7246d14119eb727b03 Story: 2007890 Task: 40269
* | | | Merge "Expose flag for forcing use of import for images"Zuul2020-07-082-0/+33
|\ \ \ \
| * | | | Expose flag for forcing use of import for imagesMonty Taylor2020-06-302-0/+33
| | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | openstacksdk added support for using image import as a fallback which is transparently supported here, but also provides an override flag to allow a user to force use of import. Expose that here. Depends-On: https://review.opendev.org/737608 Change-Id: Ied938a8f63f305305a20ace42e9f4c84b0a5c00e
* | | | Merge "switch to stevedore for entry points"Zuul2020-07-071-7/+16
|\ \ \ \
| * | | | switch to stevedore for entry pointsDoug Hellmann2020-07-061-7/+16
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Importing pkg_resources scans every installed distribution to find all of the entry points. Stevedore is adding a new caching layer using importlib.metadata, which will not. Switching to the stevedore should eventually speed up load times, especially for command line apps. This change makes the switch now to ensure API compatibility. We were already using stevedore for tests, so this moves the dependency from test-requirements.txt to requirements.txt and raises the minimum version to something more recent. Change-Id: I3e3632783bc745979b6db73e610df8a77ffaceb0 Signed-off-by: Doug Hellmann <doug@doughellmann.com>
* | | | Merge "Add '--force; parameter to 'openstack quota set'"Zuul2020-07-063-0/+102
|\ \ \ \ | |/ / / |/| | |
| * | | Add '--force; parameter to 'openstack quota set'hackertron2020-04-143-0/+102
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The compute service allows us to to force set a quota, setting a quota value that is less than the amount of the resource currently consumed. Expose this feature by way of a '--force' boolean parameter. Change-Id: I1d1ac1ac46f49f64794ffc8631e166935537966c
* | | | Merge "Allow os quota list query to filter by project"Zuul2020-06-292-2/+80
|\ \ \ \
| * | | | Allow os quota list query to filter by projectJose Castro Leon2020-03-122-2/+80
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In the os quota list command, project parameter is completely ignored ending up in a request to all projects and then all quotas. This patch enables back the parameter and does a single call to quotas if specified. Change-Id: Ie17c256e2bdc307dcd94ad5be7abdbffa776d369 Story: 2007422 Task: 39043
* | | | | Merge "port: add --host to list command"Zuul2020-06-262-0/+22
|\ \ \ \ \ | |_|_|/ / |/| | | |
| * | | | port: add --host to list commandMohammed Naser2020-06-172-0/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This adds an option to allow filtering ports bound to a specific host when listing them. Change-Id: I747ed0f8b070074c51789576a158345f670fe733
* | | | | Don't display Munch objects in the outputJens Harbott2020-06-171-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When the sdk gives us a resource that contains Munch columns, drop them from the output as they are for programmatic usage only and have no use in a CLI context. Change-Id: Idd7306cd763b5a017a66e410e70e1adb02663c2a
* | | | | Revert "Format location columns in network commands"Jens Harbott (frickler)2020-06-1722-119/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 6ee7b8d138e07bfc37c5cd887f7afa49cdabb02f. Change-Id: I5f59959ba8a01aba49e29f4cb007397467344e58
* | | | | Merge "Remove os-client-config references"Zuul2020-06-111-16/+4
|\ \ \ \ \
| * | | | | Remove os-client-config referencesMonty Taylor2020-06-081-16/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We've depended on openstacksdk for config for ages now, clean up after ourselves and stop installing it in tests. Change-Id: I66b3ec2a36bc462d2f1ac151e95ccbdc946076b8
* | | | | | Merge "Make container list --all work"Zuul2020-06-092-36/+36
|\ \ \ \ \ \ | |/ / / / / |/| | | | |
| * | | | | Make container list --all workPete Zaitcev2020-05-162-36/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The caller in openstackclient/object/v1/object.py passed a keyword argument full_listing, but the eventual callee container_list() expected all_data. So, --all did not work at all. The issue passed undetected because --all did not have a test, so we added a unit test. In addition, exisiting tests were using a test set that did not look like the real container listing, so we changed LIST_CONTAINER_RESP to be realistic. Change-Id: Id0604bcab25892e43c26cd6656b2b2eef5daa69b
* | | | | | Replace assertItemsEqual with assertCountEqualAlfredo Moralejo2020-06-011-2/+2
| |_|_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | assertItemsEqual was removed from Python's unittest.TestCase in Python 3.3 [1][2]. We have been able to use them since then, because testtools required unittest2, which still included it. With testtools removing Python 2.7 support [3][4], we will lose support for assertItemsEqual, so we should switch to use assertCountEqual. [1] - https://bugs.python.org/issue17866 [2] - https://hg.python.org/cpython/rev/d9921cb6e3cd [3] - testing-cabal/testtools#286 [4] - testing-cabal/testtools#277 Change-Id: I1ad0da8deda3a8cbec384b5a9c88860a526eb48c
* | | | | Client should parse string to boolean for value 'is_domain'yanpuqing2020-05-292-0/+128
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When we use "--property" parameter, client get lists these the value is string type, but the type of the value 'is_domain' should be boolean, so we should judge it and parse it. The patch parse string to boolean for value 'is_domain'. Co-Authored-By: Lance Bragstad <lbragstad@gmail.com> Change-Id: I37c9eb854524bde3a1530bfe2e3a03810fb1a676 Task: 30039 Story: 2005246
* | | | | Cleanup: remove a useless reference to "object"Pete Zaitcev2020-05-151-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The method "object_list" does not have an argument "object", so we were using a built-in class "object" by mistake. Change-Id: I74687659223d31d3c3c119eee5874edff30634fd
* | | | | Merge "Resolve PEP8"Zuul2020-05-152-2/+1
|\ \ \ \ \
| * | | | | Resolve PEP8Pete Zaitcev2020-05-142-2/+1
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | No idea how this happened, but reviews started failing the pep8 gate job. The failures are legitimate, see the commit. I guess the pep8 tests became smarter and found these issues. Change-Id: Id9a0dad644134dafd68eed37fe8f41c583d7a619
* | | | | Correct image lookup during server rebuildAdam Harwell2020-05-042-3/+42
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The switch to using glance from the SDK accidentally used get_image directly during a server rebuild, when it should have used find_image to match existing functionality. Bug introduced in: I36f292fb70c98f6e558f58be55d533d979c47ca7 Change-Id: I2005bd40a1bd6719670c7f7854316b4f9801b140 Story: 2007620 Task: 39643
* | | | Merge "Revert "Disallow setting default on internal network""Zuul2020-04-222-39/+1
|\ \ \ \
| * | | | Revert "Disallow setting default on internal network"Vasyl Saienko2020-04-082-39/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The original patch assumes that both --external and --is-default are set in the same request and broke case when --is-default is set as an network update. The validation logic have to be moved on API side to avoid extra API calls from openstackclient. This reverts commit 962efd949feb461283a9bb4a668fbd310f80ba40. Related-Bug: #1745658 Change-Id: Idf08abb0e08a6880f89c3e9df9dd2ac82f36c432
View Lorry Controller Status