summaryrefslogtreecommitdiff
path: root/openstackclient
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | Fixed a bunch of spacingBrandon Palm2016-02-2347-76/+183
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Nothing too complicated here. I fixed a bunch of spacing issues that I saw in OSC. Change-Id: I935ab48e7c5bac5f88ecdb3a05f73fb44fc9f41d
* | | | Add some test cases for "server list" commandting.wang2016-02-242-27/+78
| |/ / |/| | | | | | | | | | | | | | | | | | | | Add some test cases that test 'server list' command when specifying flavor or image. Because I add some attribution to fake.py, I have to change some code in create server test. Despite all this, I think it's good for testing. Change-Id: I714deac1f6f940b790a3c20af5f7ffa724ac44d1
* | | Merge "Refactor network AZ exception handling"Jenkins2016-02-241-3/+2
|\ \ \
| * | | Refactor network AZ exception handlingRichard Theis2016-02-101-3/+2
| | |/ | |/| | | | | | | | | | | | | | | | | | | Exceptions that occur while getting network availability zones should not be masked as if the extension does not exist. Change-Id: I07213ec6c4d83e97261b58bf8d42417c1cdfae6a Related-Bug: #1534202
* | | Py3 replace dict.iteritems with six.iteritemsting.wang2016-02-241-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | All dict.iteritems in osc are replaced with six.iteritems except this one. So fix it to add py3 compatibility. Change-Id: I1aa51399a36e650d262d839ce2b4ec04d3f91db2
* | | Merge "Use update_parser_common() in ShowNetwork"Jenkins2016-02-231-2/+1
|\ \ \
| * | | Use update_parser_common() in ShowNetworkTang Chen2016-02-231-2/+1
| | |/ | |/| | | | | | | | | | | | | | | | ShowNetwork inherits from NetworkAndComputeCommand. So we should use update_parser_common() in it, not overwrite parent's get_parser(). Change-Id: I21bb1407962344b9800fd31caee4b2582674fe24
* | | Merge "Add "security group rule show" command"Jenkins2016-02-233-4/+208
|\ \ \
| * | | Add "security group rule show" commandRichard Theis2016-02-233-4/+208
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add the "os security group rule show" command which will use the SDK when neutron is enabled, and use the nova client when nova network is enabled. Change-Id: I41efaa4468ec15e4e86d74144cc72edc25a29024 Partial-Bug: #1519512 Implements: blueprint neutron-client
* | | | Fix wrong return value in TestDeleteFloatingIPNetworkTang Chen2016-02-231-1/+1
| |/ / |/| | | | | | | | | | | | | | delete_ip() should return None, not the fake floating IP. Change-Id: I1476189a09a94c76c90f9a3986e3ae57dc66d796
* | | Merge "Use instanceof instead of type"Jenkins2016-02-233-6/+6
|\ \ \
| * | | Use instanceof instead of typeBrandon Palm2016-02-223-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adjusted conditional statements to use instanceof when comparing variables. Instanceof supports inheritance type checking better than type. Change-Id: I4ee0004934dc2322d43ef07e797a6811e39a812c Closes-Bug: 1548530
* | | | Merge "Add functional tests for "volume" commands v2"Jenkins2016-02-232-2/+36
|\ \ \ \
| * | | | Add functional tests for "volume" commands v2Tang Chen2016-02-212-2/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The tests for v2 "volume" commands are quite similar to v1. This patch also map 'metadata' to 'properties', 'volume_type' to 'type' to align to the v1 output. Change-Id: Icf2c5463b186fc78c890ccd96453090c4a2c2eb6 Partial-bug: #1519503
* | | | | Merge "Add unit tests for 'hypervisor stats' command"Jenkins2016-02-232-0/+140
|\ \ \ \ \
| * | | | | Add unit tests for 'hypervisor stats' commandting.wang2016-02-222-0/+140
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 'hypervisor stats show' command isn't covered by unit tests, so add unit tests to test it. Change-Id: Ic355230cbdd596e848191b599803dca7f27c2ffb
* | | | | | Merge "Add "os subnet show" command using SDK"Jenkins2016-02-233-2/+111
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | |
| * | | | | Add "os subnet show" command using SDKBrad Behle2016-02-223-2/+111
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Implement the openstack client subnet show command using SDK calls. This shows the details of a specific subnet. Co-Authored-By: Terry Howe <terrylhowe@gmail.com> Partially implements: blueprint neutron-client Closes-Bug: #1542359 Change-Id: Iaf18b9e44af35ca0cd61033b468e0c60cd3b05d6
* | | | | Initialize _keys in __init__() in FakeFlavorResourceTang Chen2016-02-231-2/+5
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | _keys is defined as a class attribute in FakeFlavorResource. So when we call set_keys() to update it, it changes. And this change may bring trouble to the other tests afterward. So define and initialize it in __init__() as an object attribute. Change-Id: Ib18c03877b67e1b7c2e107f598076b928a58e4fb Closes-bug: #1548378
* | | | Merge "Add unit test for "flavor show" command"Jenkins2016-02-222-10/+89
|\ \ \ \
| * | | | Add unit test for "flavor show" commandTang Chen2016-02-202-10/+89
| |/ / / | | | | | | | | | | | | Change-Id: I1591649e5b97a885707042fcccad3335ee8c7aec
* | | | Merge "Clean redundant argument to dict.get"Jenkins2016-02-225-47/+42
|\ \ \ \
| * | | | Clean redundant argument to dict.getting.wang2016-02-215-47/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `dict.get()` returns `None` by default, if a key wasn't found. Removing `None` as second argument to avoid redundancy. Change-Id: Ia82f7469cd019509bbeccbfe54b15eeedc7bb6ea
* | | | | Merge "Refactor: Set "project_id" for FakeXXX in a consistent style"Jenkins2016-02-211-10/+9
|\ \ \ \ \ | |/ / / / |/| | | |
| * | | | Refactor: Set "project_id" for FakeXXX in a consistent styleTang Chen2016-02-201-10/+9
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | OpenStack SDK will translate "project_id" into "tenant_id" automatically when referring to "tenant_id" attribute with the name "project_id". So when faking an object returned fron SDK, we need to fake this behavior. The original way is ugly. This patch turns it into a consistent style, and give better comments. Change-Id: I0dfb1f7552fc28eb4e7ebf5c614c9f3bde79ad80
* | | | Merge "Support unscoped token request"Jenkins2016-02-2110-6/+119
|\ \ \ \
| * | | | Support unscoped token requestguang-yee2016-02-1910-6/+119
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make scope check optional for the "token issue" command as unscoped token is a valid Keystone V2/V3 API. Change-Id: Ie1cded4dbfdafd3a78c0ebdf89e3f66762509930 Closes-Bug: #1543214
* | | | | Merge "Fix Mutable default argument"Jenkins2016-02-211-2/+12
|\ \ \ \ \
| * | | | | Fix Mutable default argumentting.wang2016-02-201-2/+12
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Python’s default arguments are evaluated once when the function is defined, not each time the function is called. This means that if you use a mutable default argument (like list and dict) and mutate it, you will and have mutated that object for all future calls to the function as well. more details about this wrong usage here: http://docs.python-guide.org/en/latest/writing/gotchas/#mutable-default-arguments Change-Id: If187f16bfb305ac4fe6e4177e498a06c49c3f946
* | | | | Merge "Trivial: Rename subnet_pool.rst to subnet-pool.rst"Jenkins2016-02-201-2/+2
|\ \ \ \ \ | |_|/ / / |/| | | |
| * | | | Trivial: Rename subnet_pool.rst to subnet-pool.rstTang Chen2016-02-201-2/+2
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | File names under doc/source/command-objects/ are words connected with "-". So rename subnet_pool.rst to subnet-pool.rst to keep the consistence. Also use "display" instead of "show" in the comment to keep the consistence. Change-Id: If486f6cec34b4572a8245af865267b063c1e877d
* | | | Replace string format arguments with function parametersting.wang2016-02-204-6/+6
|/ / / | | | | | | | | | | | | | | | | | | | | | There are files containing string format arguments inside logging messages. Using logging function parameters should be preferred. Change-Id: I15b405bf4d4715263fe1e1262982467b3d4bc1f4 Closes-Bug: #1321274
* | | Merge "Subnet Pool: Add "subnet pool show" command"Jenkins2016-02-193-1/+126
|\ \ \
| * | | Subnet Pool: Add "subnet pool show" commandTang Chen2016-02-193-1/+126
| | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I8dda7bbf1e27b0ac773f62a5cd293387da96f8df Closes-Bug: 1544590 Implements: blueprint neutron-client
* | | | Merge "Don't use Mock.called_once_with that does not exist"Jenkins2016-02-191-1/+1
|\ \ \ \ | |_|/ / |/| | |
| * | | Don't use Mock.called_once_with that does not existTang Chen2016-02-191-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Class mock.Mock does not exist method "called_once_with()", it just exists method "assert_called_once_with()". "called_once_with()" does nothing because it's a mock object. In OSC, only one place is still using "called_once_with()". Fix it. Change-Id: Ib890e95d775c3fc43df80fa05c82d726e78cdac8 Partial Bug: 1544522
* | | | Merge "Use assertIsNone() instead of assertEqual(None, xxx)"Jenkins2016-02-193-7/+7
|\ \ \ \
| * | | | Use assertIsNone() instead of assertEqual(None, xxx)Tang Chen2016-02-193-7/+7
| |/ / / | | | | | | | | | | | | Change-Id: Ibbd7d6d27b2ff20304e3121fbadd5d50c1836d9b
* | | | Merge "Subnet Pool: Add "subnet pool list" command"Jenkins2016-02-193-1/+125
|\ \ \ \ | | |/ / | |/| |
| * | | Subnet Pool: Add "subnet pool list" commandTang Chen2016-02-193-1/+125
| |/ / | | | | | | | | | | | | | | | Change-Id: I7935be2488fb728ced9680d75880870e5d315655 Closes-Bug: 1544589 Implements: blueprint neutron-client
* | | Floating IP: Fix "ip floating list" in neutron networkTang Chen2016-02-193-17/+51
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The implementation of "ip floating list" in the commit below is incorrect: Change-Id: I253f66f6bc64470e1a18ffea506048eb53f67d5c This is because the FloatingIP objects returned from Nova and Neutron network are different. They need different handling. This patch fixes this problem. The output for Neutron network would be: +--------------------------------------+---------------------+------------------+------+ | ID | Floating IP Address | Fixed IP Address | Port | +--------------------------------------+---------------------+------------------+------+ | 1976df86-e66a-4f96-81bd-c6ffee6407f1 | 172.24.4.3 | None | None | +--------------------------------------+---------------------+------------------+------+ The output for Neutron network would be: +----+---------------------+------------------+-----------+--------+ | ID | Floating IP Address | Fixed IP Address | Server ID | Pool | +----+---------------------+------------------+-----------+--------+ | 1 | 172.24.4.1 | None | None | public | +----+---------------------+------------------+-----------+--------+ Change-Id: I1295e922df695414511d9a07ca4a8e2428040064 Partial-Bug: 1519502 Related-to: blueprint neutron-client
* | Merge "Subnet Pool: Add "subnet pool delete" command"Jenkins2016-02-183-0/+152
|\ \
| * | Subnet Pool: Add "subnet pool delete" commandTang Chen2016-02-183-0/+152
| | | | | | | | | | | | | | | | | | Change-Id: Ic5ba5effcaea2410421a81da8ffce7c0295179e7 Closes-Bug: 1544587 Partially implements: blueprint neutron-client
* | | Merge "Support "network show" command in nova network"Jenkins2016-02-183-5/+151
|\ \ \
| * | | Support "network show" command in nova networkTang Chen2016-02-173-5/+151
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | "network show" command is not implemented in nova network. This patch implements it. Change-Id: I1fadd890fe36c4e3ac5c9ed389b20c5b2fff8aca partial-Bug: 1543672
* | | | Merge "Support "network list" command in nova network"Jenkins2016-02-183-9/+133
|\ \ \ \ | |/ / /
| * | | Support "network list" command in nova networkTang Chen2016-02-173-9/+133
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | "network list" command is not implemented in nova network. This patch implements it. The Network object in novaclient is quite different from the one in sdk. And the output of "network list" using Nova network is also quite different from using Neutron. It is like this: # openstack network list +--------------------------------------+---------+-------------+ | ID | Name | Subnet | +--------------------------------------+---------+-------------+ | 96a98ec4-31f6-45f6-99e6-9384569b3bb5 | private | 10.0.0.0/24 | +--------------------------------------+---------+-------------+ --long and --external options have not been implemented because the attrs in Network object in novaclient is too much different. This patch also introduces a new FakeNetwork class in compute/v2/fake.py to fake nova network. Change-Id: Id1fdf81fb2fa8b39f2c76b7bae37ac4fecafd0f7 Depends-On: I1b59264cd40aaf1062f4e8db233ccb7fd0e95f0e partial-Bug: 1543672
* | | | Merge "Refactor security group rule delete to use SDK"Jenkins2016-02-186-32/+265
|\ \ \ \ | |_|/ / |/| | |
| * | | Refactor security group rule delete to use SDKRichard Theis2016-02-106-32/+265
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Refactored the 'os security group rule delete' command to use the SDK when neutron is enabled, but continue to use the nova client when nova network is enabled. This patch set also introduces new FakeSecurityGroupRule classes for testing network and compute security group rules. And fixes were made to the network FakeSecurityGroup class. Change-Id: I8d0917925aa464e8255defae95a2a2adfb6cfb75 Partial-Bug: #1519512 Related-to: blueprint neutron-client
* | | Merge "Return names in list role assignments"Jenkins2016-02-173-13/+152
|\ \ \
View Lorry Controller Status