summaryrefslogtreecommitdiff
path: root/openstackclient
Commit message (Collapse)AuthorAgeFilesLines
* Merge "Trivial: Fix incorrect comments in compute fakes.py"Jenkins2016-03-081-3/+3
|\
| * Trivial: Fix incorrect comments in compute fakes.pyTang Chen2016-03-081-3/+3
| | | | | | | | Change-Id: I18b1720af13b444527dda1ecab52e3cc8d8d9376
* | [Identity] Check return value is None in identity v3 unit testsTang Chen2016-03-089-30/+64
|/ | | | | | | | | take_action() in commands inheriting from Command returns nothing. So we should assert the return is None in the unit tests of these commands. Change-Id: I02af06b3d476aac2d93a23ef2111cdc7fa0892ec Partial-Bug: #1550636
* Merge "Add port list command"Jenkins2016-03-082-0/+68
|\
| * Add port list commandJas2016-03-072-0/+68
| | | | | | | | | | | | | | | | This patch adds the ability to list all created ports Change-Id: Ie1a48c203cabc96346a4950f21b83493d58a66a5 Partial-bug: #1519909 Partially-implements: blueprint neutron-client
* | Merge "Use _get_columns() to obtain columns in network.py"Jenkins2016-03-071-4/+4
|\ \
| * | Use _get_columns() to obtain columns in network.pyTang Chen2016-03-061-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | Objects returned by Network v2 and Compute v2 are different. When getting columns to display, Network v2 uses obj.keys(), while Compute v2 uses obj._info.keys(). But both of them could obtain the keys of the object by _get_columns(). Change-Id: I347815f2d28822a95bd6f57d429b84b7ca96e0ee
* | | Merge "Test take_action() instead of run() in unit tests"Jenkins2016-03-0711-101/+107
|\ \ \ | |_|/ |/| |
| * | Test take_action() instead of run() in unit testsTang Chen2016-03-0511-101/+107
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some of the unit tests test run(), but not take_action(). For example, in openstackclient/tests/volume/v1/test_volume.py, there is: def test_volume_set_size_smaller(self): ...... result = self.cmd.run(parsed_args) self.assertEqual(0, result) ...... run() is defined in class Command in cliff. We don't need to test it in OSC unit tests. On the contrary, we should test take_action(), which is overwritten in each command classes in OSC. Change-Id: If07e89953d40ac530f08cbb1ec05f5805171364b Closes-bug: #1553468
* | | Trivial: Remove useless returnTang Chen2016-03-079-13/+0
| | | | | | | | | | | | | | | | | | If a function returns nothing, do not add return in the end. Change-Id: I298b8717462f68d3076a1619d674775be2a94c42
* | | Merge "" openstack server image create " doesn't print proper info"Jenkins2016-03-061-5/+19
|\ \ \ | |_|/ |/| |
| * | " openstack server image create " doesn't print proper infoMohan Muppidi2016-03-031-5/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | After creating a snapshot of a running instance, a print out similar to server create is expected, but it prints out something like "_info" which is nothing related to created image. _prep_image_detail method is added to /compute/v2/server.py to enable the priting, while running the test properly. Change-Id: I4b06be959768bcdaafd9aa8df497490958bee649 Closes-Bug:1551586
* | | Merge "Refactor security group set to use SDK"Jenkins2016-03-053-41/+189
|\ \ \ | |_|/ |/| |
| * | Refactor security group set to use SDKRichard Theis2016-03-033-41/+189
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Refactored the 'os security group set' command to use the SDK when neutron is enabled, but continue to use the nova client when nova network is enabled. This patch set also fixes a compute bug which ignores name and description when set to an empty value. Change-Id: I4225179dca4aedf799e1656ec49236bdedc5e9bd Partial-Bug: #1519511 Implements: blueprint neutron-client
* | | Merge "[compute] Support restore server"Jenkins2016-03-042-0/+42
|\ \ \
| * | | [compute] Support restore serverjichenjc2016-02-232-0/+42
| | | | | | | | | | | | | | | | | | | | | | | | Server in soft-delete state can be restored, add this command. Change-Id: Id9d7246f89ae65273505f36dcb664996534ae986
* | | | Merge "Add 'port create' command"Jenkins2016-03-042-53/+316
|\ \ \ \
| * | | | Add 'port create' commandJas2016-03-042-53/+316
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch adds usage of 'port create' in CLI Change-Id: I888af50784c3b6c7ec30552ade79f05a5e974711 Partial-bug: #1519909 Partially-implements: blueprint neutron-client
* | | | | Merge "[compute] Add unit test for keypair"Jenkins2016-03-043-1/+318
|\ \ \ \ \
| * | | | | [compute] Add unit test for keypairjichenjc2016-02-233-1/+318
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | keypair do not have unit test, this patch adds it. Change-Id: Id702ccaad239b916340bb17014d1ede0a28aaec9
* | | | | | Merge "[Volume] Check return value is None in volume unit tests"Jenkins2016-03-047-46/+84
|\ \ \ \ \ \
| * | | | | | [Volume] Check return value is None in volume unit testsTang Chen2016-03-037-46/+84
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | take_action() in commands inheriting from Command returns nothing. So we should assert the return is None in the unit tests of these commands. Change-Id: Idd961a5fa3db825353700837a559621d17f782c5 Partial-Bug: #1550636
* | | | | | | Merge "Add test cases to test some commands with '--wait' and fix bug"Jenkins2016-03-042-2/+190
|\ \ \ \ \ \ \
| * | | | | | | Add test cases to test some commands with '--wait' and fix bugting.wang2016-03-022-2/+190
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | "server image create" "server rebuild" "server resize" Above 3 commands are not covered by unit test. So add some unit tests. Meanwhile, fix bug. Now that image name is an optional argument, we'd better record error messages with positional arguments instead of optional argument. So, record server name. Change-Id: I41bc025d4824dc46f63a3213d82e1528bacbbe12
* | | | | | | | Merge "Fix incorrect unit test for router"Jenkins2016-03-033-10/+18
|\ \ \ \ \ \ \ \ | |_|/ / / / / / |/| | | | | | |
| * | | | | | | Fix incorrect unit test for routerTang Chen2016-03-033-10/+18
| | |_|/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Command "router show" will display router's "tenant_id" as "project_id". But in the unit test, it checks "tenant_id", which is incorrect. This patch fix this problem, and add a _get_columns() helper function to simplify the code. Change-Id: I0087ef7dfd0130b6c47222495848c4f2b9804b1b
* | | | | | | Merge "Trivial: Reorder unit tests in alphabetical order in volume tests"Jenkins2016-03-032-165/+165
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | |
| * | | | | | Trivial: Reorder unit tests in alphabetical order in volume testsTang Chen2016-03-022-165/+165
| | |_|_|/ / | |/| | | | | | | | | | | | | | | | Change-Id: I622123f68e2bb53f8767069e4a717fcc34e37b5c
* | | | | | Merge "[Image] Check return value is None in image unit tests."Jenkins2016-03-022-34/+46
|\ \ \ \ \ \
| * | | | | | [Image] Check return value is None in image unit tests.Tang Chen2016-03-022-34/+46
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | take_action() in commands inheriting from Command returns nothing. So we should assert the return is None in the unit tests of these commands. Change-Id: I237ea772f74fa52af2e9aacd35d4b9cfb225c94c Partial-Bug: #1550636
* | | | | | Support "network create" command in nova networkTang Chen2016-03-022-21/+160
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch only provide network name and subnet setting for "network create" command. The other options, such as --project which depends on identity v2 or v3, will make the unit tests too complicated. So I prefer to implement them in other patches. Change-Id: I9ec93f0af813c8fae4170c36e16bbe8f0f53cbb6 Partial-Bug: 1543672
* | | | | Merge "Clean up unnecessary import of urlparse module"Jenkins2016-03-011-6/+1
|\ \ \ \ \
| * | | | | Clean up unnecessary import of urlparse moduleYang Hongyang2016-03-011-6/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | six.moves.urllib already covers the py2 and py3 compatibility issues of urlparse module, use six.moves.urllib.parse.urlparse is enough. Change-Id: I785f4f872850e5d770fdcf4c0d3392be3978cc4a
* | | | | | Merge "Fix regression in interactive client mode"Jenkins2016-03-011-1/+1
|\ \ \ \ \ \
| * | | | | | Fix regression in interactive client modeDina Belova2016-03-011-1/+1
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix typo introduced in OSprofiler intergation commit, that leaded to non-working interactive mode of the CLI client. Change-Id: If5dfc90dbbe64d4665c3e33e936f0cc674738351 Closes-Bug: 1551160
* | | | | | Merge "Trivial: Update image_list v2 docs"Jenkins2016-03-011-4/+7
|\ \ \ \ \ \ | |/ / / / / |/| | | | |
| * | | | | Trivial: Update image_list v2 docsYang Hongyang2016-03-011-4/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This api doc is clearly copied from v1, we should update it to reflact v2 API. Added 'shared' param description. Change-Id: I73d36e3a2a0448c28edab788a9340fd46177f8ef
* | | | | | Merge "TrivialOrder: Rearrange Class Names"Jenkins2016-03-012-47/+47
|\ \ \ \ \ \
| * | | | | | TrivialOrder: Rearrange Class Namesreedip2016-03-012-47/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As per the comment given by Steve Martinelli in https://review.openstack.org/#/c/278209/ , the following patch just rearranges the classes as per the Alphabetical order. TrivialFix Change-Id: Ib8f0f703df4ef7d7ee6180ff8bd8a47062ae5b0f
* | | | | | | Merge "Fix return value of "image set" command"Jenkins2016-03-011-1/+1
|\ \ \ \ \ \ \
| * | | | | | | Fix return value of "image set" commandTang Chen2016-02-291-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | "image set" command should return None. But in one path, it returns ({}, {}). This patch fixes this. Change-Id: I3847e661cb7e89863921a3f0a859d9b1a8077ede
* | | | | | | | Merge "Make SetAggregate inherit from cliff.Command"Jenkins2016-03-011-14/+14
|\ \ \ \ \ \ \ \
| * | | | | | | | Make SetAggregate inherit from cliff.CommandTang Chen2016-02-271-14/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | set/unset comamnd classes should inherit from cliff.Command class. Also, this patch adds functional tests for aggregate. And also, use utils.format_dict() to format the output of the properties dict. Change-Id: Idb50bef8990da95666960e2414dfd7c9be234bba Partial-bug: #1519503 Closes-Bug: 1546065
* | | | | | | | | Merge "Trivial: Reorder flavor op order in flavor.py"Jenkins2016-03-011-24/+24
|\ \ \ \ \ \ \ \ \
| * | | | | | | | | Trivial: Reorder flavor op order in flavor.pyYang Hongyang2016-03-011-24/+24
| | |_|_|/ / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Classes should be in alphabetical order. Change-Id: I7a35c3a2dd6d36c49f0d54dec5c14609a9168bd0
* | | | | | | | | Merge "Refactor security group list to use SDK"Jenkins2016-03-015-125/+256
|\ \ \ \ \ \ \ \ \ | |_|_|_|/ / / / / |/| | | | | | | |
| * | | | | | | | Refactor security group list to use SDKRichard Theis2016-02-295-125/+256
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Refactored the 'os security group list' command to use the SDK when neutron is enabled, but continue to use the nova client when nova network is enabled. This refactor also removes the logic for displaying project names instead of project IDs when the --all-projects option is specified. This logic was removed because it is inconsistent with the other network commands. Since neutron will always display security groups across all projects for an admin, the --all-projects option is now hidden when neutron is enabled and the Project column is always displayed. Change-Id: I934a1f5084ef3c5f929d0ffd38ebf5064d799941 Partial-Bug: #1519511 Related-to: blueprint neutron-client
* | | | | | | | | Merge "fix: Exception message includes unnecessary class args"Jenkins2016-03-011-2/+2
|\ \ \ \ \ \ \ \ \
| * | | | | | | | | fix: Exception message includes unnecessary class argsJas2016-02-291-2/+2
| |/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix misusages of ArgumentTypeError which causes a tuple of class instance and error message string to be printed rather than just the error message string itsself. Change-Id: I0e997f86bb6603930cc92e90efcb48155f62ffb5 Closes-bug: #1551426
* | | | | | | | | Merge "Subnet: Add "subnet delete" command using SDK"Jenkins2016-03-012-0/+47
|\ \ \ \ \ \ \ \ \ | |_|_|_|_|_|_|_|/ |/| | | | | | | |
View Lorry Controller Status