summaryrefslogtreecommitdiff
path: root/openstackclient
Commit message (Collapse)AuthorAgeFilesLines
* Cleanup: remove a useless reference to "object"Pete Zaitcev2020-05-151-1/+1
| | | | | | | The method "object_list" does not have an argument "object", so we were using a built-in class "object" by mistake. Change-Id: I74687659223d31d3c3c119eee5874edff30634fd
* Merge "Resolve PEP8"Zuul2020-05-152-2/+1
|\
| * Resolve PEP8Pete Zaitcev2020-05-142-2/+1
| | | | | | | | | | | | | | | | No idea how this happened, but reviews started failing the pep8 gate job. The failures are legitimate, see the commit. I guess the pep8 tests became smarter and found these issues. Change-Id: Id9a0dad644134dafd68eed37fe8f41c583d7a619
* | Correct image lookup during server rebuildAdam Harwell2020-05-042-3/+42
|/ | | | | | | | | | | | The switch to using glance from the SDK accidentally used get_image directly during a server rebuild, when it should have used find_image to match existing functionality. Bug introduced in: I36f292fb70c98f6e558f58be55d533d979c47ca7 Change-Id: I2005bd40a1bd6719670c7f7854316b4f9801b140 Story: 2007620 Task: 39643
* Merge "Revert "Disallow setting default on internal network""Zuul2020-04-222-39/+1
|\
| * Revert "Disallow setting default on internal network"Vasyl Saienko2020-04-082-39/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | The original patch assumes that both --external and --is-default are set in the same request and broke case when --is-default is set as an network update. The validation logic have to be moved on API side to avoid extra API calls from openstackclient. This reverts commit 962efd949feb461283a9bb4a668fbd310f80ba40. Related-Bug: #1745658 Change-Id: Idf08abb0e08a6880f89c3e9df9dd2ac82f36c432
* | Merge "Use unittest.mock instead of third party mock"Zuul2020-04-171-1/+1
|\ \
| * | Use unittest.mock instead of third party mockSean McGinnis2020-04-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Now that we no longer support py27, we can use the standard library unittest.mock module instead of the third party mock lib. Change-Id: Ibd39328c27b68190e2edbf1f52fcea52db3ae791 Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
* | | Merge "Add resource option immutable"Zuul2020-04-177-11/+474
|\ \ \
| * | | Add resource option immutableVishakha Agarwal2020-04-087-11/+474
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch adds the --immutable and --no-immutable option to the role, project and domain CLI. Related-Patch: https://review.opendev.org/#/c/712182/ Change-Id: I9c3bdd741f28bf558267fb217818d947597ce13e
* | | | Merge "Add 'subnetpool' type support to rbac commands"Zuul2020-04-152-5/+14
|\ \ \ \
| * | | | Add 'subnetpool' type support to rbac commandsIgor Malinovskiy2020-04-092-5/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: Id6e528ebd1bf21ca142e60052d28371f97f629ac Partial-Bug: #1862032 Depends-On: https://review.opendev.org/710755
* | | | | Merge "Add 'address_scope' type support to network rbac commands"Zuul2020-04-102-52/+35
|\ \ \ \ \ | |/ / / /
| * | | | Add 'address_scope' type support to network rbac commandsIgor Malinovskiy2020-03-262-52/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I6a4b7219934805c1bbd1e88fcc670ae231d9ac37 Partial-Bug: #1862968 Depends-On: https://review.opendev.org/709122
* | | | | Merge "Support for stateless security groups"Zuul2020-04-084-1/+48
|\ \ \ \ \ | |_|_|_|/ |/| | | |
| * | | | Support for stateless security groupsTom Stappaerts2020-03-314-1/+48
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add support for stateful attribute of security groups, using --stateful and --no-stateful flag on security group. This allows a user to create security groups with stateful false. Change-Id: Ifd20b5fc47fd0ea0bb5aeda84820dcc0fb1e8847 Blueprint: stateless-security-groups Depends-On: https://review.opendev.org/711513/
* | | | | Add description field to portforwarding NAT rulespedro2020-04-023-1/+35
| |_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add the `description` field to Floating IP Port Forwardings Depends-On: https://review.opendev.org/#/c/705038/ Change-Id: I6477368e32570c96cacddba4f86455262e533277 Implements: blueprint portforwarding-description Closes-Bug: #1850818
* | | | Merge "Add command: router add/remove route --route"Zuul2020-04-013-3/+277
|\ \ \ \ | |_|_|/ |/| | |
| * | | Add command: router add/remove route --routeBence Romsics2020-03-303-3/+277
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add commands to osc to call the two new API methods introduced by new Neutron extension: extraroute-atomic. Bump our openstacksdk requirement to >=0.38.0 which contains the corresponding sdk change. The lower-constraints of dogpile.cache and keystoneauth1 are bumped because of requirements bumps in openstacksdk. The lower-constraint of decorator is bumped because of problem already fixed by amotoki here: https://review.opendev.org/701706 Change-Id: Ia9b9c216f1d1161ebedac31594a2c464d77f4ae2 Depends-On: https://review.opendev.org/674324 Partial-Bug: #1826396 (rfe) Related-Change: https://review.opendev.org/655680 (spec)
* | | Adding options to user cliVishakha Agarwal2020-03-263-1/+974
|/ / | | | | | | | | | | | | | | | | | | | | | | | | User options [1] can be set by making POST and PATCH request for /v3/users API calls but cannot by openstack CLI because of no user options defined in create and update user CLI [2]. This patch adds the user options [1] in create user and update user CLI. [1] https://docs.openstack.org/keystone/latest/admin/resource-options.html#multi-factor-auth-rules [2] https://docs.openstack.org/api-ref/identity/v3/#create-user Change-Id: I4e41bae2e8cfbe92d52b14d856991bedcd44164f
* | Merge "Don't look up project by id if given id"5.2.0Zuul2020-03-251-3/+8
|\ \
| * | Don't look up project by id if given idDmitriy Rabotyagov2020-03-241-3/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There is a much deeper and systemic issue going on here, but let's start with fixing the immediate issue which is that adding a project to an image fails trying to look up project information even if the user passes the project id by id. _is_uuid_like from sdk isn't perfect, but it'll be good enough for this. Change-Id: I541416d737b961c56aa2f584c172528632fd5537
* | | Merge "Complete switch from glanceclient to SDK for image service"Zuul2020-03-254-228/+151
|\ \ \ | |/ /
| * | Complete switch from glanceclient to SDK for image serviceArtem Goncharov2020-03-244-228/+151
| | | | | | | | | | | | | | | | | | | | | | | | | | | In https://review.opendev.org/#/c/650374/ a work has been started to switch image service support from glanceclient with all it's dependencies to the SDK version. With this change version 1 (anyway deprecated since ages) is also being switched to SDK. Change-Id: Ic391500af02a73d81d64a9e9113cca85c9e24390
* | | Merge "Switch image to use SDK"Zuul2020-03-2513-553/+652
|\ \ \ | |/ /
| * | Switch image to use SDKArtem Goncharov2020-03-2313-553/+652
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a work to switch OSC from using glanceclient to OpenStackSDK. With this change only v2 is using OpenStackSDK. V1 is still using glanceclient and will be switched in a separate change. Remove the direct depend on keystoneauth- let that flow through openstacksdk. Depends-on: https://review.opendev.org/#/c/698972 Change-Id: I36f292fb70c98f6e558f58be55d533d979c47ca7
* | | Merge "Fix faulthy state argument choice"5.1.0Zuul2020-03-244-6/+24
|\ \ \
| * | | Fix faulthy state argument choiceBram Verschueren2019-12-194-6/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The correct state name for a failing volume snapshot deletion is 'error_deleting' instead of 'error-deleting'. [1] [1] https://opendev.org/openstack/cinder/src/commit/89d6a5042fcb2ede5a0b1112d72fae805ea52fcd/cinder/objects/fields.py#L126 Task: #37844 Story: #2007037 Change-Id: Ia99900ece4f1cd29769b22ddaa3965789d719556
* | | | Merge "Add unit tests and release note for dns_publish_fixed_ip"Zuul2020-03-241-0/+38
|\ \ \ \
| * | | | Add unit tests and release note for dns_publish_fixed_ipDean Troyer2020-01-141-0/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Follow-up to https://review.opendev.org/#/c/679834/ which added the options and lacked both a release note and minimal option-handling unit tests. Change-Id: Ibb2820add9b2fedaf5a8b1a77babf043f6641724 Signed-off-by: Dean Troyer <dtroyer@gmail.com>
* | | | | Merge "Honor endpoint override from config for volume"Zuul2020-03-241-0/+4
|\ \ \ \ \
| * | | | | Honor endpoint override from config for volumeMonty Taylor2020-03-241-0/+4
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I'm guessing we should do this for everyone, but we have volume on the brain right now. Rackspace is in the weird situation where they do support v2 but only have v1 in the catalog (wut) So we need to override the block-storage enpdoint by config. To do that, we need to actually honor the config setting over here in OSC. NOTE: We need to systemically overhaul how we're injesting config over here - because there's too much variation. But we can leave that for another day. Story: 2007459 Task: 39137 Change-Id: Ifddf1ddd5abaa768ab18049c09d18bc269f3a4f5
* | | | | Merge "Add "fields" parameter to ListSecurityGroup query"Zuul2020-03-242-6/+15
|\ \ \ \ \
| * | | | | Add "fields" parameter to ListSecurityGroup queryRodolfo Alonso Hernandez2020-03-122-6/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This new query parameter will allow to send a query sending the "fields" parameter. This "fields" parameter contains the needed API fields, translated into OVO fields in Neutron server, that require to be retrieved from the DB. As commented in the related bug, the OSC "list" command only prints five parameters, none of them the security group rules. In systems with a reasonable amount of security groups, skipping the unnecessary rule load can save a lot of time. Depends-On: https://review.opendev.org/#/c/710820/ Change-Id: I16f48e292997d029d68f66365db949b9f4b5a0c8 Closes-Bug: #1865223
* | | | | | Merge "Fix network segment range "_get_ranges" function"Zuul2020-03-232-2/+15
|\ \ \ \ \ \ | |_|/ / / / |/| | | | |
| * | | | | Fix network segment range "_get_ranges" functionRodolfo Alonso Hernandez2020-03-232-2/+15
| | |_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This function should return an ordered set of ranges based on an unordered list of numbers (int or str). Change-Id: I918c8befc51236cc33d96a5c88fb6eafdd143e9c Story: 2007341 Task: 38878
* | | | | Merge "Now we can add description for role creation in OSC"Zuul2020-03-205-3/+120
|\ \ \ \ \
| * | | | | Now we can add description for role creation in OSCM V P Nitesh2018-09-185-3/+120
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now user can add the description when user create's the role using OSC ``openstack role create`` command. User can add the description by adding `--description <Description>` to OSC ``openstack role create`` command. Co-Authored-By: Deepak Mourya<deepakmoriya7@gmail.com> Change-Id: I858e004c3b29c687b6a39c8a1ed5fb029eb19c67 Depends-on: I230af9cc833af13064636b5d9a7ce6334c3f6e9a Closes-Bug: #1669080
* | | | | | Allow setting floating IP descriptionDaniel Strong2020-03-182-0/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: If664bfe3c9fdcb69c7046eb16c5d32602d1b3262 Story: 2007439 Task: 39094
* | | | | | Merge "Add storage policy option to create container command"Zuul2020-03-134-2/+111
|\ \ \ \ \ \
| * | | | | | Add storage policy option to create container commandSimon Merrick2020-02-194-2/+111
| | |/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | + Add CLI option to specify swift storage policy + Add CLI flag to specify container uses public read ACLS + Show storage policy in container show data Change-Id: I08ffa0d98bd39d467aa415771675f59bd77768ff
* | | | | | Merge "Add qos_network_policy_id to network port tests"Zuul2020-03-132-0/+3
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | |
| * | | | | Add qos_network_policy_id to network port testsRodolfo Alonso Hernandez2020-02-182-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Added "qos_network_policy_id" to "port show" command. Because this is just a read-only parameter and is read from the SDK port definition, this patch only modifies the corresponding tests. This patch is adding this new parameter to the test bench. Change-Id: Ice7423e0e0b98a39cc36622b70eae5a8493a037c Closes-Bug: #1851362
* | | | | | Disallow setting default on internal networkHongbin Lu2020-03-092-1/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The ``--default`` option should be only used for external network. Default internal network is not currently supported so we disallow it for now. Change-Id: Ia9d39b40e1e041d7bda0f6a27d058e382b572e1a Closes-Bug: #1745658
* | | | | | Merge "Fix copypaste errors in access rule command"Zuul2020-03-031-2/+2
|\ \ \ \ \ \ | |_|/ / / / |/| | | | |
| * | | | | Fix copypaste errors in access rule commandColleen Murphy2020-01-211-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Access rules are access rules, not application credentials. Change-Id: I74d05f11ec186283e5a86d92dcbfe4eb24130eee
* | | | | | Use 'KeyValueAppendAction' from osc-libStephen Finucane2020-02-031-31/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Does what it says on the tin. This action was added to osc-lib in change If73cab759fa09bddf1ff519923c5972c3b2052b1. Change-Id: I51efaa096bb26e297d99634c5d9cca34c0919074 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | | | | Stop silently ignoring invalid 'server create --hint' optionsStephen Finucane2020-02-032-12/+61
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The '--hint' option for 'server create' expects a key-value pair like so: openstack server create --hint group=245e1dfe-2d0e-4139-80a9-fce124948896 ... However, the command doesn't complain if this isn't the case, meaning typos like the below aren't indicated to the user: openstack server create --hint 245e1dfe-2d0e-4139-80a9-fce124948896 Due to how we'd implemented this here, this ultimately results in us POSTing the following as part of the body to 'os-servers': { ... "OS-SCH-HNT:scheduler_hints": { "245e1dfe-2d0e-4139-80a9-fce124948896": null } ... } Which is unfortunately allowed and ignored by nova due to the use of 'additionalProperties' in the schema [1] Do what we do for loads of other options and explicitly fail on invalid values. This involves adding a new argparse action since none of those defined in osc-lib work for us. This is included here to ease backporting of the fix but will be moved to osc-lib in a future patch. [1] https://github.com/openstack/nova/blob/19.0.0/nova/api/openstack/compute/schemas/servers.py#L142-L146 Change-Id: I9e96d2978912c8dfeadae4a782c481a17cd7e348 Signed-off-by: Stephen Finucane <sfinucan@redhat.com> Story: #2006628 Task: #36840 Related-Bug: #1845322
* | | | | Add support for app cred access rulesColleen Murphy2020-01-175-9/+468
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit introduces the --access-rules option for 'application credential create' as well as new 'access rule' commands for listing, showing, and deleting access rules. bp whitelist-extension-for-app-creds Change-Id: I04834b2874ec2a70da456a380b5bef03a392effa
* | | | | Switch to using osc_lib.utils.tagsMichael Johnson2020-01-148-151/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch updates the network modules to use the new osc_lib.utils.tags module and removes the in tree _tag.py version. A previous patch[1] moves the _tag.py code to osc-lib to allow other projects to leverage the code. [1] https://review.opendev.org/662859 Change-Id: Id0c34029e327de50c5fd2732bae5fbf45bbd16ee
View Lorry Controller Status