From 61a40343fdbb89a1c6404ab03fcfd84daee31c9e Mon Sep 17 00:00:00 2001 From: Dean Troyer Date: Wed, 21 Jan 2015 15:02:58 -0600 Subject: Add filter to image list * Hides previously broken --page-size option * Adds --property to image list for filtering on properties * Adds Visibility, Protected, Owner, Properties/Tags to --long output * Adds api.utils.simple_filter() for selecting matches out of a list of objects * Adds tests for all of the above * Updates image docs There are additional filtering options to be added in later reviews. Change-Id: I32feff0ad61aae749b33621c817658d7dc90c3aa Closes-bug: 1401902 --- openstackclient/api/image_v2.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'openstackclient/api/image_v2.py') diff --git a/openstackclient/api/image_v2.py b/openstackclient/api/image_v2.py index c5c78431..37c2ed83 100644 --- a/openstackclient/api/image_v2.py +++ b/openstackclient/api/image_v2.py @@ -30,6 +30,7 @@ class APIv2(image_v1.APIv1): detailed=False, public=False, private=False, + shared=False, **filter ): """Get available images @@ -49,17 +50,17 @@ class APIv2(image_v1.APIv1): both public and private images which is the same set as all images. http://docs.openstack.org/api/openstack-image-service/2.0/content/list-images.html - - TODO(dtroyer): Implement filtering """ - if public == private: - # No filtering for both False and both True cases + if not public and not private and not shared: + # No filtering for all False filter.pop('visibility', None) elif public: filter['visibility'] = 'public' elif private: filter['visibility'] = 'private' + elif shared: + filter['visibility'] = 'shared' url = "/images" if detailed: -- cgit v1.2.1