From 258c1102cc6b93a860bcd7cc083d4e14ae0025ce Mon Sep 17 00:00:00 2001
From: Akihiro Motoki <motoki@da.jp.nec.com>
Date: Sun, 10 Jan 2016 21:54:53 +0900
Subject: log take_action parameters in a single place

Previously each command logs take_action parameters explicitly
by using @utils.log_method decorator or log.debug().
Some commands have no logging.

This commit calls a logger in the base class and
drops all logging definition from individual commands.

Closes-Bug: #1532294
Change-Id: I43cd0290a4353c68c075bade9571c940733da1be
---
 openstackclient/identity/v2_0/project.py | 29 ++++-------------------------
 1 file changed, 4 insertions(+), 25 deletions(-)

(limited to 'openstackclient/identity/v2_0/project.py')

diff --git a/openstackclient/identity/v2_0/project.py b/openstackclient/identity/v2_0/project.py
index 4330c79c..9e26c308 100644
--- a/openstackclient/identity/v2_0/project.py
+++ b/openstackclient/identity/v2_0/project.py
@@ -15,24 +15,19 @@
 
 """Identity v2 Project action implementations"""
 
-import logging
 import six
 
-from cliff import command
-from cliff import lister
-from cliff import show
 from keystoneauth1 import exceptions as ks_exc
 
+from openstackclient.common import command
 from openstackclient.common import parseractions
 from openstackclient.common import utils
 from openstackclient.i18n import _  # noqa
 
 
-class CreateProject(show.ShowOne):
+class CreateProject(command.ShowOne):
     """Create new project"""
 
-    log = logging.getLogger(__name__ + '.CreateProject')
-
     def get_parser(self, prog_name):
         parser = super(CreateProject, self).get_parser(prog_name)
         parser.add_argument(
@@ -70,7 +65,6 @@ class CreateProject(show.ShowOne):
         )
         return parser
 
-    @utils.log_method(log)
     def take_action(self, parsed_args):
         identity_client = self.app.client_manager.identity
 
@@ -106,8 +100,6 @@ class CreateProject(show.ShowOne):
 class DeleteProject(command.Command):
     """Delete project(s)"""
 
-    log = logging.getLogger(__name__ + '.DeleteProject')
-
     def get_parser(self, prog_name):
         parser = super(DeleteProject, self).get_parser(prog_name)
         parser.add_argument(
@@ -118,7 +110,6 @@ class DeleteProject(command.Command):
         )
         return parser
 
-    @utils.log_method(log)
     def take_action(self, parsed_args):
         identity_client = self.app.client_manager.identity
 
@@ -131,11 +122,9 @@ class DeleteProject(command.Command):
         return
 
 
-class ListProject(lister.Lister):
+class ListProject(command.Lister):
     """List projects"""
 
-    log = logging.getLogger(__name__ + '.ListProject')
-
     def get_parser(self, prog_name):
         parser = super(ListProject, self).get_parser(prog_name)
         parser.add_argument(
@@ -146,7 +135,6 @@ class ListProject(lister.Lister):
         )
         return parser
 
-    @utils.log_method(log)
     def take_action(self, parsed_args):
         if parsed_args.long:
             columns = ('ID', 'Name', 'Description', 'Enabled')
@@ -163,8 +151,6 @@ class ListProject(lister.Lister):
 class SetProject(command.Command):
     """Set project properties"""
 
-    log = logging.getLogger(__name__ + '.SetProject')
-
     def get_parser(self, prog_name):
         parser = super(SetProject, self).get_parser(prog_name)
         parser.add_argument(
@@ -202,7 +188,6 @@ class SetProject(command.Command):
         )
         return parser
 
-    @utils.log_method(log)
     def take_action(self, parsed_args):
         identity_client = self.app.client_manager.identity
 
@@ -240,11 +225,9 @@ class SetProject(command.Command):
         return
 
 
-class ShowProject(show.ShowOne):
+class ShowProject(command.ShowOne):
     """Display project details"""
 
-    log = logging.getLogger(__name__ + '.ShowProject')
-
     def get_parser(self, prog_name):
         parser = super(ShowProject, self).get_parser(prog_name)
         parser.add_argument(
@@ -253,7 +236,6 @@ class ShowProject(show.ShowOne):
             help=_('Project to display (name or ID)'))
         return parser
 
-    @utils.log_method(log)
     def take_action(self, parsed_args):
         identity_client = self.app.client_manager.identity
 
@@ -303,8 +285,6 @@ class ShowProject(show.ShowOne):
 class UnsetProject(command.Command):
     """Unset project properties"""
 
-    log = logging.getLogger(__name__ + '.UnsetProject')
-
     def get_parser(self, prog_name):
         parser = super(UnsetProject, self).get_parser(prog_name)
         parser.add_argument(
@@ -323,7 +303,6 @@ class UnsetProject(command.Command):
         )
         return parser
 
-    @utils.log_method(log)
     def take_action(self, parsed_args):
         identity_client = self.app.client_manager.identity
         project = utils.find_resource(
-- 
cgit v1.2.1