From e3270cdfd8fce895b8f32b8e23e48399be6ac85c Mon Sep 17 00:00:00 2001 From: Tang Chen Date: Fri, 3 Jun 2016 12:21:45 +0800 Subject: Make set/unset commands in network return normally when nothing specified set/unset commands should ends up normally instead of raising an exception when nothing is specified to modify. The main reason is: When nothing is specified, the command sets/unsets nothing, which is a normal behavior, and ends up normally. No API call fails. No error happens. This patch also adds a releasenote for both network, and volume commands that fix patch has been merged. Change-Id: I78c348066078decd350417a431f3b8bea8fcf9ef Partial-bug: #1588588 --- openstackclient/network/v2/port.py | 3 --- 1 file changed, 3 deletions(-) (limited to 'openstackclient/network/v2/port.py') diff --git a/openstackclient/network/v2/port.py b/openstackclient/network/v2/port.py index 7ef3964b..b117897a 100644 --- a/openstackclient/network/v2/port.py +++ b/openstackclient/network/v2/port.py @@ -426,9 +426,6 @@ class SetPort(command.Command): elif parsed_args.no_fixed_ip: attrs['fixed_ips'] = [] - if attrs == {}: - msg = _("Nothing specified to be set") - raise exceptions.CommandError(msg) client.update_port(obj, **attrs) -- cgit v1.2.1