From 402c9a21b347509520be206e28ee7d0ef4004b92 Mon Sep 17 00:00:00 2001 From: yanpuqing Date: Wed, 13 Jun 2018 05:21:53 -0400 Subject: Do not require port argument when updating floating IP When setting floating ip other properties, port argument is force to use. The patch modifies the command, when setting floating ip other properties, like tags, no need port argument. Change-Id: I908712c8913f32d3dd5fdfefe7347277d72f66de Story: 1751431 Task: 13865 --- openstackclient/network/v2/floating_ip.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) (limited to 'openstackclient/network/v2') diff --git a/openstackclient/network/v2/floating_ip.py b/openstackclient/network/v2/floating_ip.py index f51baed5..2f0e7403 100644 --- a/openstackclient/network/v2/floating_ip.py +++ b/openstackclient/network/v2/floating_ip.py @@ -416,11 +416,10 @@ class SetFloatingIP(command.Command): parser.add_argument( 'floating_ip', metavar='', - help=_("Floating IP to associate (IP address or ID)")) + help=_("Floating IP to modify (IP address or ID)")) parser.add_argument( '--port', metavar='', - required=True, help=_("Associate the floating IP with port (name or ID)")), parser.add_argument( '--fixed-ip-address', @@ -452,9 +451,11 @@ class SetFloatingIP(command.Command): parsed_args.floating_ip, ignore_missing=False, ) - port = client.find_port(parsed_args.port, - ignore_missing=False) - attrs['port_id'] = port.id + if parsed_args.port: + port = client.find_port(parsed_args.port, + ignore_missing=False) + attrs['port_id'] = port.id + if parsed_args.fixed_ip_address: attrs['fixed_ip_address'] = parsed_args.fixed_ip_address -- cgit v1.2.1