From b33ee3daf6eebc74fb176b1f2d8018e0e2214377 Mon Sep 17 00:00:00 2001 From: Michael McCune Date: Thu, 28 Apr 2016 15:15:57 -0400 Subject: remove assert in favor an if/else the assert usage in the NonNegativeAction has the potential to allow unexpected behavior when the python is byte-compiled with optimization turned on. Changes * remove assert in favor of if/else in NonNegativeAction class * add type specifier to parser arguments for non-negative actions * correct tests for new int based values Change-Id: I093e7440b8beff4f179e2c4ed81daff82704c40e Closes-Bug: #1576375 --- openstackclient/network/v2/subnet_pool.py | 3 +++ 1 file changed, 3 insertions(+) (limited to 'openstackclient/network') diff --git a/openstackclient/network/v2/subnet_pool.py b/openstackclient/network/v2/subnet_pool.py index 435db2e1..f1174dda 100644 --- a/openstackclient/network/v2/subnet_pool.py +++ b/openstackclient/network/v2/subnet_pool.py @@ -91,6 +91,7 @@ def _add_prefix_options(parser, for_create=False): parser.add_argument( '--default-prefix-length', metavar='', + type=int, action=parseractions.NonNegativeAction, help=_("Set subnet pool default prefix length") ) @@ -98,11 +99,13 @@ def _add_prefix_options(parser, for_create=False): '--min-prefix-length', metavar='', action=parseractions.NonNegativeAction, + type=int, help=_("Set subnet pool minimum prefix length") ) parser.add_argument( '--max-prefix-length', metavar='', + type=int, action=parseractions.NonNegativeAction, help=_("Set subnet pool maximum prefix length") ) -- cgit v1.2.1