From f1345dc06f91177ced17f102bcdaaa126fe12568 Mon Sep 17 00:00:00 2001
From: Bence Romsics <bence.romsics@ericsson.com>
Date: Tue, 7 Mar 2017 15:54:31 +0100
Subject: Make MAC address of port updatable

openstackclient does not allow the update of a port's MAC address.
However this is possible in neutron API (though by default policy
it is an admin-only operation). Allow it in openstackclient too.

Change-Id: Ibd9e0a6fbd1d0d461b8a8daee24dbb7c3f929df6
Closes-Bug: #1670707
---
 openstackclient/network/v2/port.py | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

(limited to 'openstackclient/network')

diff --git a/openstackclient/network/v2/port.py b/openstackclient/network/v2/port.py
index 6117175e..eced93ce 100644
--- a/openstackclient/network/v2/port.py
+++ b/openstackclient/network/v2/port.py
@@ -130,6 +130,8 @@ def _get_attrs(client_manager, parsed_args):
         attrs['binding:vnic_type'] = parsed_args.vnic_type
     if parsed_args.host:
         attrs['binding:host_id'] = parsed_args.host
+    if parsed_args.mac_address is not None:
+        attrs['mac_address'] = parsed_args.mac_address
 
     if parsed_args.dns_name is not None:
         attrs['dns_name'] = parsed_args.dns_name
@@ -138,8 +140,6 @@ def _get_attrs(client_manager, parsed_args):
         attrs['name'] = str(parsed_args.name)
     # The remaining options do not support 'port set' command, so they require
     # additional check
-    if 'mac_address' in parsed_args and parsed_args.mac_address is not None:
-        attrs['mac_address'] = parsed_args.mac_address
     if 'network' in parsed_args and parsed_args.network is not None:
         attrs['network_id'] = parsed_args.network
     if 'project' in parsed_args and parsed_args.project is not None:
@@ -234,6 +234,11 @@ def _add_updatable_args(parser):
         metavar='<device-id>',
         help=argparse.SUPPRESS,
     )
+    parser.add_argument(
+        '--mac-address',
+        metavar='<mac-address>',
+        help=_("MAC address of this port (admin only)")
+    )
     parser.add_argument(
         '--device-owner',
         metavar='<device-owner>',
@@ -324,11 +329,6 @@ class CreatePort(command.ShowOne):
             action='store_true',
             help=_("Disable port")
         )
-        parser.add_argument(
-            '--mac-address',
-            metavar='<mac-address>',
-            help=_("MAC address of this port")
-        )
         parser.add_argument(
             '--project',
             metavar='<project>',
-- 
cgit v1.2.1