From ac1d86c34333780e30b9393d155ae84a769ac222 Mon Sep 17 00:00:00 2001
From: Tang Chen <chen.tang@easystack.cn>
Date: Wed, 25 May 2016 11:12:57 +0800
Subject: Refactor SetService --enable/disable option

This patch changes the following:

1. --enable/disable option should follow the rules
   in the doc below:
   http://docs.openstack.org/developer/python-openstackclient/command-options.html#boolean-options

2. "--disable-resion" is specified but not "--disable",
   an exception is raised instead of igoring
   "--disable-reason" option.

Change-Id: I92e9234111e661bfe7119a8e19389a87c874ab0c
---
 openstackclient/tests/compute/v2/test_service.py | 57 +++++++++++-------------
 1 file changed, 26 insertions(+), 31 deletions(-)

(limited to 'openstackclient/tests/compute')

diff --git a/openstackclient/tests/compute/v2/test_service.py b/openstackclient/tests/compute/v2/test_service.py
index 7a5a840f..cf534978 100644
--- a/openstackclient/tests/compute/v2/test_service.py
+++ b/openstackclient/tests/compute/v2/test_service.py
@@ -13,8 +13,7 @@
 #   under the License.
 #
 
-import mock
-
+from openstackclient.common import exceptions
 from openstackclient.compute.v2 import service
 from openstackclient.tests.compute.v2 import fakes as compute_fakes
 
@@ -128,6 +127,23 @@ class TestServiceSet(TestService):
 
         self.cmd = service.SetService(self.app, None)
 
+    def test_set_nothing(self):
+        arglist = [
+            self.service.host,
+            self.service.binary,
+        ]
+        verifylist = [
+            ('host', self.service.host),
+            ('service', self.service.binary),
+        ]
+        parsed_args = self.check_parser(self.cmd, arglist, verifylist)
+        result = self.cmd.take_action(parsed_args)
+
+        self.service_mock.enable.assert_not_called()
+        self.service_mock.disable.assert_not_called()
+        self.service_mock.disable_log_reason.assert_not_called()
+        self.assertIsNone(result)
+
     def test_service_set_enable(self):
         arglist = [
             '--enable',
@@ -135,7 +151,7 @@ class TestServiceSet(TestService):
             self.service.binary,
         ]
         verifylist = [
-            ('enabled', True),
+            ('enable', True),
             ('host', self.service.host),
             ('service', self.service.binary),
         ]
@@ -156,7 +172,7 @@ class TestServiceSet(TestService):
             self.service.binary,
         ]
         verifylist = [
-            ('enabled', False),
+            ('disable', True),
             ('host', self.service.host),
             ('service', self.service.binary),
         ]
@@ -179,7 +195,7 @@ class TestServiceSet(TestService):
             self.service.binary,
         ]
         verifylist = [
-            ('enabled', False),
+            ('disable', True),
             ('disable_reason', reason),
             ('host', self.service.host),
             ('service', self.service.binary),
@@ -203,24 +219,13 @@ class TestServiceSet(TestService):
             self.service.binary,
         ]
         verifylist = [
-            ('enabled', True),
             ('disable_reason', reason),
             ('host', self.service.host),
             ('service', self.service.binary),
         ]
         parsed_args = self.check_parser(self.cmd, arglist, verifylist)
-
-        with mock.patch.object(self.cmd.log, 'info') as mock_log:
-            result = self.cmd.take_action(parsed_args)
-
-            msg = "argument --disable-reason has been ignored"
-            mock_log.assert_called_once_with(msg)
-
-        self.service_mock.enable.assert_called_with(
-            self.service.host,
-            self.service.binary
-        )
-        self.assertIsNone(result)
+        self.assertRaises(exceptions.CommandError, self.cmd.take_action,
+                          parsed_args)
 
     def test_service_set_enable_with_disable_reason(self):
         reason = 'earthquake'
@@ -231,21 +236,11 @@ class TestServiceSet(TestService):
             self.service.binary,
         ]
         verifylist = [
-            ('enabled', True),
+            ('enable', True),
             ('disable_reason', reason),
             ('host', self.service.host),
             ('service', self.service.binary),
         ]
         parsed_args = self.check_parser(self.cmd, arglist, verifylist)
-
-        with mock.patch.object(self.cmd.log, 'info') as mock_log:
-            result = self.cmd.take_action(parsed_args)
-
-            msg = "argument --disable-reason has been ignored"
-            mock_log.assert_called_once_with(msg)
-
-        self.service_mock.enable.assert_called_with(
-            self.service.host,
-            self.service.binary
-        )
-        self.assertIsNone(result)
+        self.assertRaises(exceptions.CommandError, self.cmd.take_action,
+                          parsed_args)
-- 
cgit v1.2.1