From cfcb750a97af1ab82b425532437456c22dcebad9 Mon Sep 17 00:00:00 2001 From: Tang Chen Date: Sun, 14 Feb 2016 18:43:19 +0800 Subject: Use assertRaises() to check if an exception is raised In some test cases, try/except is used to check if an exception has been raised. We should use assertRaises() instead. Change-Id: I15c8e757dcab77fd6f895feb018184e1eb7e617b --- openstackclient/tests/compute/v2/test_server.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'openstackclient/tests/compute') diff --git a/openstackclient/tests/compute/v2/test_server.py b/openstackclient/tests/compute/v2/test_server.py index a80eaf51..95188522 100644 --- a/openstackclient/tests/compute/v2/test_server.py +++ b/openstackclient/tests/compute/v2/test_server.py @@ -143,11 +143,10 @@ class TestServerCreate(TestServer): verifylist = [ ('server_name', self.new_server.name), ] - try: - # Missing required args should bail here - self.check_parser(self.cmd, arglist, verifylist) - except utils.ParserException: - pass + + # Missing required args should bail here + self.assertRaises(utils.ParserException, self.check_parser, + self.cmd, arglist, verifylist) def test_server_create_minimal(self): arglist = [ -- cgit v1.2.1