From 8628e52de7412e57e13238ad1ba7113deb6a2e1b Mon Sep 17 00:00:00 2001
From: Vishakha Agarwal <agarwalvishakha18@gmail.com>
Date: Tue, 21 Jul 2020 18:24:58 +0530
Subject: Add name and enabled param in ListDomain parser

when doing openstack domain list --name xyz_id,
and openstack domain list --enabled CLI raising
error unrecognized arguments, whereas in api-ref
document [1], user can pass name and enabled as
optional query param. This addresses the above
issue, by adding param --name and --enabled in
parser of ListDomain.

[1]https://docs.openstack.org/api-ref/identity/v3/?expanded=list-domains-detail#list-domains

Change-Id: I3cdb511d3c7059ddfb802ca025188d8976c9302c
---
 .../tests/unit/identity/v3/test_domain.py          | 55 ++++++++++++++++++++++
 1 file changed, 55 insertions(+)

(limited to 'openstackclient/tests/unit')

diff --git a/openstackclient/tests/unit/identity/v3/test_domain.py b/openstackclient/tests/unit/identity/v3/test_domain.py
index 46f389e8..c39f1bd3 100644
--- a/openstackclient/tests/unit/identity/v3/test_domain.py
+++ b/openstackclient/tests/unit/identity/v3/test_domain.py
@@ -293,6 +293,61 @@ class TestDomainList(TestDomain):
         ), )
         self.assertEqual(datalist, tuple(data))
 
+    def test_domain_list_with_option_name(self):
+        arglist = ['--name',
+                   self.domain.name]
+        verifylist = [
+            ('name', self.domain.name)
+        ]
+        parsed_args = self.check_parser(self.cmd, arglist, verifylist)
+
+        # In base command class Lister in cliff, abstract method take_action()
+        # returns a tuple containing the column names and an iterable
+        # containing the data to be listed.
+        columns, data = self.cmd.take_action(parsed_args)
+
+        kwargs = {
+            'name': self.domain.name
+        }
+        self.domains_mock.list.assert_called_with(**kwargs)
+
+        collist = ('ID', 'Name', 'Enabled', 'Description')
+        self.assertEqual(collist, columns)
+        datalist = ((
+            self.domain.id,
+            self.domain.name,
+            True,
+            self.domain.description,
+        ), )
+        self.assertEqual(datalist, tuple(data))
+
+    def test_domain_list_with_option_enabled(self):
+        arglist = ['--enabled']
+        verifylist = [
+            ('enabled', True)
+        ]
+        parsed_args = self.check_parser(self.cmd, arglist, verifylist)
+
+        # In base command class Lister in cliff, abstract method take_action()
+        # returns a tuple containing the column names and an iterable
+        # containing the data to be listed.
+        columns, data = self.cmd.take_action(parsed_args)
+
+        kwargs = {
+            'enabled': True
+        }
+        self.domains_mock.list.assert_called_with(**kwargs)
+
+        collist = ('ID', 'Name', 'Enabled', 'Description')
+        self.assertEqual(collist, columns)
+        datalist = ((
+            self.domain.id,
+            self.domain.name,
+            True,
+            self.domain.description,
+        ), )
+        self.assertEqual(datalist, tuple(data))
+
 
 class TestDomainSet(TestDomain):
 
-- 
cgit v1.2.1