From eb793dc8c6a8bd30e612f19f30808528b10eb344 Mon Sep 17 00:00:00 2001 From: Reedip Date: Thu, 23 Feb 2017 08:05:00 -0500 Subject: Add default-quota to subnet pool commands Add --default-quota option to subnet pool create and set commands. Setting default-quota back to None may break the current Neutron behavior, therefore support for Unset command is not provided in this patch. Neutron API: https://github.com/openstack/neutron/blob/a0e0e8b6686b847a4963a6aa6a3224b5768544e6/neutron/api/v2/attributes.py#L239 Closes-Bug: #1667294 Change-Id: Ia4e7c23a49e91a090133c729353cdb8e62bc5674 --- .../tests/unit/network/v2/test_subnet_pool.py | 42 +++++++++++++++++++++- 1 file changed, 41 insertions(+), 1 deletion(-) (limited to 'openstackclient/tests/unit') diff --git a/openstackclient/tests/unit/network/v2/test_subnet_pool.py b/openstackclient/tests/unit/network/v2/test_subnet_pool.py index f12537e7..80a57bbb 100644 --- a/openstackclient/tests/unit/network/v2/test_subnet_pool.py +++ b/openstackclient/tests/unit/network/v2/test_subnet_pool.py @@ -270,6 +270,27 @@ class TestCreateSubnetPool(TestSubnetPool): self.assertEqual(self.columns, columns) self.assertEqual(self.data, data) + def test_create_with_default_quota(self): + arglist = [ + '--pool-prefix', '10.0.10.0/24', + '--default-quota', '10', + self._subnet_pool.name, + ] + verifylist = [ + ('prefixes', ['10.0.10.0/24']), + ('default_quota', 10), + ('name', self._subnet_pool.name), + ] + parsed_args = self.check_parser(self.cmd, arglist, verifylist) + columns, data = (self.cmd.take_action(parsed_args)) + self.network.create_subnet_pool.assert_called_once_with(**{ + 'name': self._subnet_pool.name, + 'prefixes': ['10.0.10.0/24'], + 'default_quota': 10, + }) + self.assertEqual(self.columns, columns) + self.assertEqual(self.data, data) + class TestDeleteSubnetPool(TestSubnetPool): @@ -567,7 +588,9 @@ class TestListSubnetPool(TestSubnetPool): class TestSetSubnetPool(TestSubnetPool): # The subnet_pool to set. - _subnet_pool = network_fakes.FakeSubnetPool.create_one_subnet_pool() + _subnet_pool = network_fakes.FakeSubnetPool.create_one_subnet_pool( + {'default_quota': 10}, + ) _address_scope = network_fakes.FakeAddressScope.create_one_address_scope() @@ -794,6 +817,23 @@ class TestSetSubnetPool(TestSubnetPool): self._subnet_pool, **attrs) self.assertIsNone(result) + def test_set_with_default_quota(self): + arglist = [ + '--default-quota', '20', + self._subnet_pool.name, + ] + verifylist = [ + ('default_quota', 20), + ('subnet_pool', self._subnet_pool.name), + ] + parsed_args = self.check_parser(self.cmd, arglist, verifylist) + result = self.cmd.take_action(parsed_args) + self.network.update_subnet_pool.assert_called_once_with( + self._subnet_pool, + **{'default_quota': 20, } + ) + self.assertIsNone(result) + class TestShowSubnetPool(TestSubnetPool): -- cgit v1.2.1