From c2c3f2e0f23f857aa2c8ce17e310996e90ea9b54 Mon Sep 17 00:00:00 2001 From: Dean Troyer Date: Fri, 16 Jan 2015 10:54:00 -0600 Subject: Update service clist commands for v2 and v3 Changes to the 'service list' commands for Identity v2 and v3: * Document support for --long * Add Description to v3 output with --long * v3 output is now (ID, Name, Type), with (Description, Enabled) added with --long * Change v2 output to match v3 output, with the absense of Enabled. * Update doc to match Closes-Bug: #1411337 Change-Id: I999e3df22f61350cdeba63bbb7d01145c2ffeeaf --- .../tests/identity/v2_0/test_service.py | 3 ++- openstackclient/tests/identity/v3/test_service.py | 26 +++++++++++++++++++++- 2 files changed, 27 insertions(+), 2 deletions(-) (limited to 'openstackclient/tests') diff --git a/openstackclient/tests/identity/v2_0/test_service.py b/openstackclient/tests/identity/v2_0/test_service.py index a0adea4e..73606585 100644 --- a/openstackclient/tests/identity/v2_0/test_service.py +++ b/openstackclient/tests/identity/v2_0/test_service.py @@ -235,11 +235,12 @@ class TestServiceList(TestService): self.services_mock.list.assert_called_with() - collist = ('ID', 'Name') + collist = ('ID', 'Name', 'Type') self.assertEqual(columns, collist) datalist = (( identity_fakes.service_id, identity_fakes.service_name, + identity_fakes.service_type, ), ) self.assertEqual(tuple(data), datalist) diff --git a/openstackclient/tests/identity/v3/test_service.py b/openstackclient/tests/identity/v3/test_service.py index 5e4dc585..7766a29c 100644 --- a/openstackclient/tests/identity/v3/test_service.py +++ b/openstackclient/tests/identity/v3/test_service.py @@ -247,12 +247,36 @@ class TestServiceList(TestService): self.services_mock.list.assert_called_with() - collist = ('ID', 'Name', 'Type', 'Enabled') + collist = ('ID', 'Name', 'Type') self.assertEqual(columns, collist) datalist = (( identity_fakes.service_id, identity_fakes.service_name, identity_fakes.service_type, + ), ) + self.assertEqual(tuple(data), datalist) + + def test_service_list_long(self): + arglist = [ + '--long', + ] + verifylist = [ + ('long', True), + ] + parsed_args = self.check_parser(self.cmd, arglist, verifylist) + + # DisplayCommandBase.take_action() returns two tuples + columns, data = self.cmd.take_action(parsed_args) + + self.services_mock.list.assert_called_with() + + collist = ('ID', 'Name', 'Type', 'Description', 'Enabled') + self.assertEqual(columns, collist) + datalist = (( + identity_fakes.service_id, + identity_fakes.service_name, + identity_fakes.service_type, + identity_fakes.service_description, True, ), ) self.assertEqual(tuple(data), datalist) -- cgit v1.2.1