From ab0b1fe885ee0a210a58008b631521025be7f3eb Mon Sep 17 00:00:00 2001
From: Stephen Finucane <sfinucan@redhat.com>
Date: Tue, 13 Oct 2020 15:35:21 +0100
Subject: Validate 'server group create --policy' option

We were documenting that some of these policies were only supported with
specific microversions, however, we weren't actually enforcing that,
leading to a poor user experience. Correct this.

Change-Id: Ic3c555226a220efd9b0f27edffccf6c4c95c2747
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
---
 .../tests/unit/compute/v2/test_server_group.py     | 43 ++++++++++++++++++++++
 1 file changed, 43 insertions(+)

(limited to 'openstackclient/tests')

diff --git a/openstackclient/tests/unit/compute/v2/test_server_group.py b/openstackclient/tests/unit/compute/v2/test_server_group.py
index 359cd2bd..bf0ea0ba 100644
--- a/openstackclient/tests/unit/compute/v2/test_server_group.py
+++ b/openstackclient/tests/unit/compute/v2/test_server_group.py
@@ -90,6 +90,28 @@ class TestServerGroupCreate(TestServerGroup):
         self.cmd = server_group.CreateServerGroup(self.app, None)
 
     def test_server_group_create(self):
+        arglist = [
+            '--policy', 'anti-affinity',
+            'affinity_group',
+        ]
+        verifylist = [
+            ('policy', 'anti-affinity'),
+            ('name', 'affinity_group'),
+        ]
+        parsed_args = self.check_parser(self.cmd, arglist, verifylist)
+        columns, data = self.cmd.take_action(parsed_args)
+        self.server_groups_mock.create.assert_called_once_with(
+            name=parsed_args.name,
+            policies=[parsed_args.policy],
+        )
+
+        self.assertEqual(self.columns, columns)
+        self.assertEqual(self.data, data)
+
+    def test_server_group_create_with_soft_policies(self):
+        self.app.client_manager.compute.api_version = api_versions.APIVersion(
+            '2.15')
+
         arglist = [
             '--policy', 'soft-anti-affinity',
             'affinity_group',
@@ -108,6 +130,27 @@ class TestServerGroupCreate(TestServerGroup):
         self.assertEqual(self.columns, columns)
         self.assertEqual(self.data, data)
 
+    def test_server_group_create_with_soft_policies_pre_v215(self):
+        self.app.client_manager.compute.api_version = api_versions.APIVersion(
+            '2.14')
+
+        arglist = [
+            '--policy', 'soft-anti-affinity',
+            'affinity_group',
+        ]
+        verifylist = [
+            ('policy', 'soft-anti-affinity'),
+            ('name', 'affinity_group'),
+        ]
+        parsed_args = self.check_parser(self.cmd, arglist, verifylist)
+        ex = self.assertRaises(
+            exceptions.CommandError,
+            self.cmd.take_action,
+            parsed_args)
+        self.assertIn(
+            '--os-compute-api-version 2.15 or greater is required',
+            str(ex))
+
     def test_server_group_create_v264(self):
         self.app.client_manager.compute.api_version = api_versions.APIVersion(
             '2.64')
-- 
cgit v1.2.1