As part of the first community-wide goal [1], teams were asked to remove the openstack/common package of their projects if one existed. This was a byproduct of the old oslo-incubator form of syncing common functionality. The package, apiclient, was moved to a top level location and cliutils was moved to the common module. There are no oslo specific libraries, the recommended solution is to move it in tree and maintain it there. Specifically in this patch, I also rearranged some of the imports to make them match up with the hacking guidelines while I was re-ordering them for the refactor anyway. Lastly, the apiclient/fake_client.py was deleted since it was not used. [1] http://governance.openstack.org/goals/ocata/remove-incubated-oslo-code.html Change-Id: Ib7b691240b819c9c91b100ca47ffaba75b281c78
"# flake8: noqa" option disables all checks for the whole file. To disable one line we should use "# noqa". Change-Id: Iea2fbf239c7f11bc0cc8788bcc4b8abc862339be Closes-bug: #1540254
Implements log file retrieval from the guest agent. The contents of the log file are pushed up to a swift container as a series of objects that represent a subset of the lines in the log. The following trove CLI commands are implemented: trove log-list <instance> : lists log files available on guest trove log-enable <instance> <log> : enables writing to log file trove log-disable <instance> <log>: disables writing to log file trove log-publish <instance> <log>: publishes updates to swift container trove log-discard <instance> <log>: discards published logs trove log-tail <instance> <log> : displays last lines of log trove log-save <instance> <log> : saves the entire log to a file Change-Id: Ic15c455747b9f1966d83d7034c9b748ca5e2cce9 Co-Authored-By: Morgan Jones <morgan@tesora.com> Co-Authored-By: Alex Tomic <atomic@tesora.com> Co-Authored-By: Peter Stachowski <peter@tesora.com>
* E265 block comment should start with '# ' * E128 continuation line under-indented for visual indent * E713 test for membership should be 'not in' Tested with pep8 version 1.5.6 (2014-04-14). Change-Id: If2853c79bea91ebef5cd97dff66788b46b174a9a
horizon handles troveclient.ClientException as a recoverable error, with troveclient defined via "from troveclient import exceptions as troveclient". this patch imports oslo's apiclient exceptions in troveclient/exceptions.py to ensure all ClientExceptions are considered recoverable. also removes unused exceptions that were unnecessarily ported from the compat version of the client. this fix is necessary to avoid seeing the generic error message of "Error: There was an error submitting the form. Please try again." in horizon vs. the explicit error message. Change-Id: I94c8ec0289821ccd365d6689488a3e25877c1560 Closes-Bug: #1292033
No need to set tabstop tons of times, this can be set in your vimrc file instead. More disucssion: http://openstack.10931.n7.nabble.com/Remove-vim-modelines-td21780.html Change-Id: I45766d91f0c0b3622bbdc7dc5517497c87ebee8c Closes-Bug: #1229324
Fixed misspelling of common words found by the 'misspellings' tool. Change-Id: I8e03379f92b62fd4856bbc74b7e4641226a403d3 Closes-Bug: #1257531
There are a few checks that already pass: - F401 - unused imports of modules - F403 - ‘from module import *’ used; unable to detect undefined names And there are two (H401 and H403) that can be made passing easily. Enable gating on all of them. Change-Id: I9d3c49ecea1b2171d194ab6cc751316c252081e8
* Added HP copyrights as appropriate Change-Id: If4f30b0caf03b16f5fb4f54185ba80d9fa41d0b0
The new client adheres to the standards of the other clients now. It prints out tables, uses ENVVAR's for auth, no longer stores pickled json in a login token, uses openstack common, and moves the cli operations into a v1 module for the future of trove when it has a v2 api. Please note for compatibility, the troveclient.compat module has the old cli. In order to deploy it, amend the setup.cfg to include the compat module. implements blueprint cli-compliance-upgrade Change-Id: Ie69d9dbc75ce90496da316244c97acca1877a327