summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAnatol Belski <ab@php.net>2014-12-17 05:29:36 +0100
committerAnatol Belski <ab@php.net>2014-12-17 05:29:36 +0100
commit4acc56d5b2378b2296b94690a545af67f6775e5a (patch)
treecc3846311cf990c44a181f40583fb907a8420f9f
parent2eef2abee5e89e77c88a9c5732bc95fab27d3404 (diff)
parentcf84bf53ea13ef70dd6145a743e093b0d3156332 (diff)
downloadphp-git-4acc56d5b2378b2296b94690a545af67f6775e5a.tar.gz
Merge remote-tracking branch 'origin/master' into native-tls
* origin/master: fix unserializer patch move this entry to the correct version add missing NEWS entry add missing NEWS entry Updated or skipped certain 32-bit tests add NEWS entry for #68594 5.4.37 add more BC breaks update news add CVE add missing test file Fix bug #68594 - Use after free vulnerability in unserialize() Fix typo Hash value must not zero?
-rw-r--r--UPGRADING5
-rw-r--r--Zend/tests/bug43128.phpt1
-rw-r--r--Zend/zend_string.h2
-rw-r--r--ext/bcmath/tests/bug60377.phpt3
-rw-r--r--ext/curl/tests/curl_version_variation1.phpt3
-rw-r--r--ext/exif/tests/exif_tagname_variation1.phpt4
-rw-r--r--ext/gd/tests/imagecolorallocate_variation2.phpt1
-rw-r--r--ext/gd/tests/imagecolorallocate_variation4.phpt3
-rw-r--r--ext/intl/tests/bug53512.phpt4
-rw-r--r--ext/intl/tests/bug61487.phpt4
-rw-r--r--ext/intl/tests/collator_get_locale2.phpt1
-rw-r--r--ext/intl/tests/dateformat_get_locale.phpt4
-rw-r--r--ext/intl/tests/formatter_get_set_symbol2.phpt1
-rw-r--r--ext/mbstring/tests/mb_encode_mimeheader_variation5.phpt1
-rw-r--r--ext/mbstring/tests/mb_split_variation3.phpt3
-rw-r--r--ext/mbstring/tests/mb_stripos_variation3.phpt1
-rw-r--r--ext/mbstring/tests/mb_strpos_variation3.phpt1
-rw-r--r--ext/mbstring/tests/mb_strripos_variation3_Bug45923.phpt1
-rw-r--r--ext/standard/tests/serialize/bug68594.phpt23
-rw-r--r--ext/standard/var_unserializer.c85
-rw-r--r--ext/standard/var_unserializer.re20
-rw-r--r--ext/zlib/tests/gzfile_variation11.phpt3
-rw-r--r--ext/zlib/tests/gzopen_variation3.phpt3
-rw-r--r--ext/zlib/tests/readgzfile_variation11.phpt3
24 files changed, 109 insertions, 71 deletions
diff --git a/UPGRADING b/UPGRADING
index d2be2afd5d..1ce98194bf 100644
--- a/UPGRADING
+++ b/UPGRADING
@@ -42,6 +42,11 @@ PHP X.Y UPGRADE NOTES
It will now produce 2, not 1.
. Function parameters with duplicate name are not allowed anymore. Definitions
like “function foo($x,$x) {}” will lead to compile time error.
+ . Indirect variable, property and method references are now interpreted with
+ left-to-right semantics. See details in:
+ https://wiki.php.net/rfc/uniform_variable_syntax#semantic_differences_in_existing_syntax
+ . The global keyword now only accepts simple variables. See details in:
+ https://wiki.php.net/rfc/uniform_variable_syntax#global_keyword_takes_only_simple_variables
- DBA
. dba_delete() now returns false if the key was not found for the inifile
diff --git a/Zend/tests/bug43128.phpt b/Zend/tests/bug43128.phpt
index 629f46c594..65806fc5c4 100644
--- a/Zend/tests/bug43128.phpt
+++ b/Zend/tests/bug43128.phpt
@@ -15,5 +15,6 @@ eval("class $a {}");
if ($a instanceof $a); // Segmentation fault
new $a; // Segmentation fault
echo "ok\n";
+?>
--EXPECT--
ok
diff --git a/Zend/zend_string.h b/Zend/zend_string.h
index 247991bcdd..bd871e29e2 100644
--- a/Zend/zend_string.h
+++ b/Zend/zend_string.h
@@ -279,6 +279,8 @@ static zend_always_inline zend_ulong zend_inline_hash_func(const char *str, size
case 0: break;
EMPTY_SWITCH_DEFAULT_CASE()
}
+
+ ZEND_ASSERT(hash != 0);
return hash;
}
diff --git a/ext/bcmath/tests/bug60377.phpt b/ext/bcmath/tests/bug60377.phpt
index 7c42002917..af7f7d44fd 100644
--- a/ext/bcmath/tests/bug60377.phpt
+++ b/ext/bcmath/tests/bug60377.phpt
@@ -1,7 +1,8 @@
--TEST--
bcscale related problem on 64bits platforms
--SKIPIF--
-<?php if(!extension_loaded("bcmath")) print "skip"; ?>
+<?php if(!extension_loaded("bcmath")) die("skip");
+if (PHP_INT_SIZE != 8) die("skip: 64-bit only"); ?>
--FILE--
<?php
$var48 = bcscale(634314234334311);
diff --git a/ext/curl/tests/curl_version_variation1.phpt b/ext/curl/tests/curl_version_variation1.phpt
index 927b4ac317..8b9554e5aa 100644
--- a/ext/curl/tests/curl_version_variation1.phpt
+++ b/ext/curl/tests/curl_version_variation1.phpt
@@ -1,7 +1,8 @@
--TEST--
Test curl_version() function : usage variations - test values for $ascii argument
--SKIPIF--
-<?php if (!extension_loaded("curl")) exit("skip curl extension not loaded"); ?>
+<?php if (!extension_loaded("curl")) exit("skip curl extension not loaded");
+if (PHP_INT_SIZE != 8) die('skip 64-bit only'); ?>
--FILE--
<?php
diff --git a/ext/exif/tests/exif_tagname_variation1.phpt b/ext/exif/tests/exif_tagname_variation1.phpt
index 0f9c135420..efa227ec7e 100644
--- a/ext/exif/tests/exif_tagname_variation1.phpt
+++ b/ext/exif/tests/exif_tagname_variation1.phpt
@@ -1,7 +1,9 @@
--TEST--
Test exif_tagname() function : usage variations - different types for index argument
--SKIPIF--
-<?php if (!extension_loaded('exif')) print 'skip exif extension not available';?>
+<?php if (!extension_loaded('exif')) print 'skip exif extension not available';
+if (PHP_INT_SIZE != 8) die('skip 64-bit only');
+?>
--FILE--
<?php
diff --git a/ext/gd/tests/imagecolorallocate_variation2.phpt b/ext/gd/tests/imagecolorallocate_variation2.phpt
index bd9dc984d1..84ff9e26ff 100644
--- a/ext/gd/tests/imagecolorallocate_variation2.phpt
+++ b/ext/gd/tests/imagecolorallocate_variation2.phpt
@@ -8,6 +8,7 @@ if(!extension_loaded('gd')) {
if(!function_exists('imagecreatetruecolor')) {
die('skip imagecreatetruecolor function is not available');
}
+if (PHP_INT_SIZE != 8) die('skip 64-bit only');
?>
--FILE--
<?php
diff --git a/ext/gd/tests/imagecolorallocate_variation4.phpt b/ext/gd/tests/imagecolorallocate_variation4.phpt
index 328a4cd3b2..8b82d01a87 100644
--- a/ext/gd/tests/imagecolorallocate_variation4.phpt
+++ b/ext/gd/tests/imagecolorallocate_variation4.phpt
@@ -8,6 +8,7 @@ if(!extension_loaded('gd')) {
if(!function_exists('imagecreatetruecolor')) {
die('skip imagecreatetruecolor function is not available');
}
+if (PHP_INT_SIZE != 8) die('skip 64-bit only');
?>
--FILE--
<?php
@@ -210,4 +211,4 @@ int(657920)
Warning: imagecolorallocate() expects parameter 4 to be long, resource given in %s on line %d
NULL
-===DONE=== \ No newline at end of file
+===DONE===
diff --git a/ext/intl/tests/bug53512.phpt b/ext/intl/tests/bug53512.phpt
index a1b1dcf37a..0de2c49a20 100644
--- a/ext/intl/tests/bug53512.phpt
+++ b/ext/intl/tests/bug53512.phpt
@@ -1,7 +1,9 @@
--TEST--
Bug #53512 (NumberFormatter::setSymbol crash on bogus $attr values)
--SKIPIF--
-<?php if( !extension_loaded( 'intl' ) ) print 'skip'; ?>
+<?php if( !extension_loaded( 'intl' ) ) die('skip');
+if (PHP_INT_SIZE != 8) die('skip 64-bit only');
+?>
--FILE--
<?php
diff --git a/ext/intl/tests/bug61487.phpt b/ext/intl/tests/bug61487.phpt
index 361debe408..2270b25cce 100644
--- a/ext/intl/tests/bug61487.phpt
+++ b/ext/intl/tests/bug61487.phpt
@@ -1,7 +1,9 @@
--TEST--
grapheme() str[i]pos limits
--SKIPIF--
-<?php if( !extension_loaded( 'intl' ) ) print 'skip'; ?>
+<?php if( !extension_loaded( 'intl' ) ) die('skip');
+if (PHP_INT_SIZE != 8) die('skip 64-bit only');
+?>
--FILE--
<?php
var_dump(grapheme_stripos(1,1,2147483648));
diff --git a/ext/intl/tests/collator_get_locale2.phpt b/ext/intl/tests/collator_get_locale2.phpt
index 798c7927f6..e9a9f2653d 100644
--- a/ext/intl/tests/collator_get_locale2.phpt
+++ b/ext/intl/tests/collator_get_locale2.phpt
@@ -3,6 +3,7 @@ get_locale() icu >= 4.8
--SKIPIF--
<?php if( !extension_loaded( 'intl' ) ) print 'skip'; ?>
<?php if(version_compare(INTL_ICU_VERSION, '4.8') < 0) print 'skip'; ?>
+<?php if (PHP_INT_SIZE != 8) die('skip 64-bit only'); ?>
--FILE--
<?php
diff --git a/ext/intl/tests/dateformat_get_locale.phpt b/ext/intl/tests/dateformat_get_locale.phpt
index 17fcca3551..48b7daa8d4 100644
--- a/ext/intl/tests/dateformat_get_locale.phpt
+++ b/ext/intl/tests/dateformat_get_locale.phpt
@@ -1,7 +1,9 @@
--TEST--
datefmt_get_locale_code()
--SKIPIF--
-<?php if( !extension_loaded( 'intl' ) ) print 'skip'; ?>
+<?php if( !extension_loaded( 'intl' ) ) die('skip');
+if (PHP_INT_SIZE != 8) die('skip 64-bit only');
+?>
--FILE--
<?php
diff --git a/ext/intl/tests/formatter_get_set_symbol2.phpt b/ext/intl/tests/formatter_get_set_symbol2.phpt
index 769713b97d..3f982cd063 100644
--- a/ext/intl/tests/formatter_get_set_symbol2.phpt
+++ b/ext/intl/tests/formatter_get_set_symbol2.phpt
@@ -3,6 +3,7 @@ numfmt_get/set_symbol() icu >= 4.8
--SKIPIF--
<?php if( !extension_loaded( 'intl' ) ) print 'skip'; ?>
<?php if(version_compare(INTL_ICU_VERSION, '4.8') < 0) print 'skip'; ?>
+<?php if (PHP_INT_SIZE != 8) die('skip 64-bit only'); ?>
--FILE--
<?php
diff --git a/ext/mbstring/tests/mb_encode_mimeheader_variation5.phpt b/ext/mbstring/tests/mb_encode_mimeheader_variation5.phpt
index d57bc1061a..4833cd5df6 100644
--- a/ext/mbstring/tests/mb_encode_mimeheader_variation5.phpt
+++ b/ext/mbstring/tests/mb_encode_mimeheader_variation5.phpt
@@ -4,6 +4,7 @@ Test mb_encode_mimeheader() function : usage variations - Pass different data ty
<?php
extension_loaded('mbstring') or die('skip');
function_exists('mb_encode_mimeheader') or die("skip mb_encode_mimeheader() is not available in this build");
+if (PHP_INT_SIZE != 8) die('skip 64-bit only');
?>
--FILE--
<?php
diff --git a/ext/mbstring/tests/mb_split_variation3.phpt b/ext/mbstring/tests/mb_split_variation3.phpt
index 5422b169cd..ec20c53640 100644
--- a/ext/mbstring/tests/mb_split_variation3.phpt
+++ b/ext/mbstring/tests/mb_split_variation3.phpt
@@ -4,6 +4,7 @@ Test mb_split() function : usage variations - different parameter types for lim
<?php
extension_loaded('mbstring') or die('skip');
function_exists('mb_split') or die("skip mb_split() is not available in this build");
+if (PHP_INT_SIZE != 8) die('skip 64-bit only');
?>
--FILE--
<?php
@@ -328,4 +329,4 @@ array(1) {
Warning: mb_split() expects parameter 3 to be long, resource given in %s on line %d
bool(false)
-Done \ No newline at end of file
+Done
diff --git a/ext/mbstring/tests/mb_stripos_variation3.phpt b/ext/mbstring/tests/mb_stripos_variation3.phpt
index decf02e883..122a599a58 100644
--- a/ext/mbstring/tests/mb_stripos_variation3.phpt
+++ b/ext/mbstring/tests/mb_stripos_variation3.phpt
@@ -4,6 +4,7 @@ Test mb_stripos() function : usage variations - pass different data types as $of
<?php
extension_loaded('mbstring') or die('skip');
function_exists('mb_stripos') or die("skip mb_stripos() is not available in this build");
+if (PHP_INT_SIZE != 8) die('skip 64-bit only');
?>
--FILE--
<?php
diff --git a/ext/mbstring/tests/mb_strpos_variation3.phpt b/ext/mbstring/tests/mb_strpos_variation3.phpt
index ff69b8c6f8..ac78b62b54 100644
--- a/ext/mbstring/tests/mb_strpos_variation3.phpt
+++ b/ext/mbstring/tests/mb_strpos_variation3.phpt
@@ -4,6 +4,7 @@ Test mb_strpos() function : usage variations - pass different data types as $off
<?php
extension_loaded('mbstring') or die('skip');
function_exists('mb_strpos') or die("skip mb_strpos() is not available in this build");
+if (PHP_INT_SIZE != 8) die('skip 64-bit only');
?>
--FILE--
<?php
diff --git a/ext/mbstring/tests/mb_strripos_variation3_Bug45923.phpt b/ext/mbstring/tests/mb_strripos_variation3_Bug45923.phpt
index 8f4370f4b8..c7e17be2ec 100644
--- a/ext/mbstring/tests/mb_strripos_variation3_Bug45923.phpt
+++ b/ext/mbstring/tests/mb_strripos_variation3_Bug45923.phpt
@@ -4,6 +4,7 @@ Test mb_strripos() function : usage variations - pass different data types as $o
<?php
extension_loaded('mbstring') or die('skip');
function_exists('mb_strripos') or die("skip mb_strripos() is not available in this build");
+if (PHP_INT_SIZE != 8) die('skip 64-bit only');
?>
--FILE--
<?php
diff --git a/ext/standard/tests/serialize/bug68594.phpt b/ext/standard/tests/serialize/bug68594.phpt
new file mode 100644
index 0000000000..60fc7a76ab
--- /dev/null
+++ b/ext/standard/tests/serialize/bug68594.phpt
@@ -0,0 +1,23 @@
+--TEST--
+Bug #68545 Use after free vulnerability in unserialize()
+--FILE--
+<?php
+for ($i=4; $i<100; $i++) {
+ $m = new StdClass();
+
+ $u = array(1);
+
+ $m->aaa = array(1,2,&$u,4,5);
+ $m->bbb = 1;
+ $m->ccc = &$u;
+ $m->ddd = str_repeat("A", $i);
+
+ $z = serialize($m);
+ $z = str_replace("bbb", "aaa", $z);
+ $y = unserialize($z);
+ $z = serialize($y);
+}
+?>
+===DONE===
+--EXPECTF--
+===DONE===
diff --git a/ext/standard/var_unserializer.c b/ext/standard/var_unserializer.c
index 74a86ca5a7..bcd00a6eba 100644
--- a/ext/standard/var_unserializer.c
+++ b/ext/standard/var_unserializer.c
@@ -1,4 +1,4 @@
-/* Generated by re2c 0.13.5 */
+/* Generated by re2c 0.13.7.5 */
#line 1 "ext/standard/var_unserializer.re"
/*
+----------------------------------------------------------------------+
@@ -362,21 +362,13 @@ static inline int process_nested_data(UNSERIALIZE_PARAMETER, HashTable *ht, zend
} else {
/* object properties should include no integers */
convert_to_string(&key);
-//???
-#if 1
- data = zend_hash_update_ind(ht, Z_STR(key), &d);
-#else
- if ((data = zend_hash_find(ht, Z_STR(key))) != NULL) {
- if (Z_TYPE_P(data) == IS_INDIRECT) {
- data = Z_INDIRECT_P(data);
+ if ((old_data = zend_hash_find(ht, Z_STR(key))) != NULL) {
+ if (Z_TYPE_P(old_data) == IS_INDIRECT) {
+ old_data = Z_INDIRECT_P(old_data);
}
- zval_ptr_dtor(data);
-//??? var_push_dtor(var_hash, data);
- ZVAL_UNDEF(data);
- } else {
- data = zend_hash_update(ht, Z_STR(key), &d);
- }
-#endif
+ var_push_dtor(var_hash, old_data);
+ }
+ data = zend_hash_update_ind(ht, Z_STR(key), &d);
}
zval_dtor(&key);
@@ -515,7 +507,7 @@ PHPAPI int php_var_unserialize_ex(UNSERIALIZE_PARAMETER)
start = cursor;
-#line 519 "ext/standard/var_unserializer.c"
+#line 511 "ext/standard/var_unserializer.c"
{
YYCTYPE yych;
static const unsigned char yybm[] = {
@@ -575,9 +567,9 @@ yy2:
yych = *(YYMARKER = ++YYCURSOR);
if (yych == ':') goto yy95;
yy3:
-#line 866 "ext/standard/var_unserializer.re"
+#line 858 "ext/standard/var_unserializer.re"
{ return 0; }
-#line 581 "ext/standard/var_unserializer.c"
+#line 573 "ext/standard/var_unserializer.c"
yy4:
yych = *(YYMARKER = ++YYCURSOR);
if (yych == ':') goto yy89;
@@ -620,13 +612,13 @@ yy13:
goto yy3;
yy14:
++YYCURSOR;
-#line 860 "ext/standard/var_unserializer.re"
+#line 852 "ext/standard/var_unserializer.re"
{
/* this is the case where we have less data than planned */
php_error_docref(NULL, E_NOTICE, "Unexpected end of serialized data");
return 0; /* not sure if it should be 0 or 1 here? */
}
-#line 630 "ext/standard/var_unserializer.c"
+#line 622 "ext/standard/var_unserializer.c"
yy16:
yych = *++YYCURSOR;
goto yy3;
@@ -652,11 +644,12 @@ yy20:
if (yybm[0+yych] & 128) {
goto yy20;
}
- if (yych != ':') goto yy18;
+ if (yych <= '/') goto yy18;
+ if (yych >= ';') goto yy18;
yych = *++YYCURSOR;
if (yych != '"') goto yy18;
++YYCURSOR;
-#line 715 "ext/standard/var_unserializer.re"
+#line 707 "ext/standard/var_unserializer.re"
{
size_t len, len2, len3, maxlen;
zend_long elements;
@@ -801,7 +794,7 @@ yy20:
return object_common2(UNSERIALIZE_PASSTHRU, elements);
}
-#line 805 "ext/standard/var_unserializer.c"
+#line 798 "ext/standard/var_unserializer.c"
yy25:
yych = *++YYCURSOR;
if (yych <= ',') {
@@ -826,7 +819,7 @@ yy27:
yych = *++YYCURSOR;
if (yych != '"') goto yy18;
++YYCURSOR;
-#line 707 "ext/standard/var_unserializer.re"
+#line 699 "ext/standard/var_unserializer.re"
{
//??? INIT_PZVAL(rval);
@@ -834,7 +827,7 @@ yy27:
return object_common2(UNSERIALIZE_PASSTHRU,
object_common1(UNSERIALIZE_PASSTHRU, ZEND_STANDARD_CLASS_DEF_PTR));
}
-#line 838 "ext/standard/var_unserializer.c"
+#line 831 "ext/standard/var_unserializer.c"
yy32:
yych = *++YYCURSOR;
if (yych == '+') goto yy33;
@@ -855,7 +848,7 @@ yy34:
yych = *++YYCURSOR;
if (yych != '{') goto yy18;
++YYCURSOR;
-#line 686 "ext/standard/var_unserializer.re"
+#line 678 "ext/standard/var_unserializer.re"
{
zend_long elements = parse_iv(start + 2);
/* use iv() not uiv() in order to check data range */
@@ -876,7 +869,7 @@ yy34:
return finish_nested_data(UNSERIALIZE_PASSTHRU);
}
-#line 880 "ext/standard/var_unserializer.c"
+#line 873 "ext/standard/var_unserializer.c"
yy39:
yych = *++YYCURSOR;
if (yych == '+') goto yy40;
@@ -897,7 +890,7 @@ yy41:
yych = *++YYCURSOR;
if (yych != '"') goto yy18;
++YYCURSOR;
-#line 658 "ext/standard/var_unserializer.re"
+#line 650 "ext/standard/var_unserializer.re"
{
size_t len, maxlen;
zend_string *str;
@@ -925,7 +918,7 @@ yy41:
ZVAL_STR(rval, str);
return 1;
}
-#line 929 "ext/standard/var_unserializer.c"
+#line 922 "ext/standard/var_unserializer.c"
yy46:
yych = *++YYCURSOR;
if (yych == '+') goto yy47;
@@ -946,7 +939,7 @@ yy48:
yych = *++YYCURSOR;
if (yych != '"') goto yy18;
++YYCURSOR;
-#line 631 "ext/standard/var_unserializer.re"
+#line 623 "ext/standard/var_unserializer.re"
{
size_t len, maxlen;
char *str;
@@ -973,7 +966,7 @@ yy48:
ZVAL_STRINGL(rval, str, len);
return 1;
}
-#line 977 "ext/standard/var_unserializer.c"
+#line 970 "ext/standard/var_unserializer.c"
yy53:
yych = *++YYCURSOR;
if (yych <= '/') {
@@ -1061,7 +1054,7 @@ yy61:
}
yy63:
++YYCURSOR;
-#line 622 "ext/standard/var_unserializer.re"
+#line 614 "ext/standard/var_unserializer.re"
{
#if SIZEOF_ZEND_LONG == 4
use_double:
@@ -1070,7 +1063,7 @@ use_double:
ZVAL_DOUBLE(rval, zend_strtod((const char *)start + 2, NULL));
return 1;
}
-#line 1074 "ext/standard/var_unserializer.c"
+#line 1067 "ext/standard/var_unserializer.c"
yy65:
yych = *++YYCURSOR;
if (yych <= ',') {
@@ -1129,7 +1122,7 @@ yy73:
yych = *++YYCURSOR;
if (yych != ';') goto yy18;
++YYCURSOR;
-#line 606 "ext/standard/var_unserializer.re"
+#line 598 "ext/standard/var_unserializer.re"
{
*p = YYCURSOR;
@@ -1145,7 +1138,7 @@ yy73:
return 1;
}
-#line 1149 "ext/standard/var_unserializer.c"
+#line 1142 "ext/standard/var_unserializer.c"
yy76:
yych = *++YYCURSOR;
if (yych == 'N') goto yy73;
@@ -1172,7 +1165,7 @@ yy79:
if (yych <= '9') goto yy79;
if (yych != ';') goto yy18;
++YYCURSOR;
-#line 580 "ext/standard/var_unserializer.re"
+#line 572 "ext/standard/var_unserializer.re"
{
#if SIZEOF_ZEND_LONG == 4
int digits = YYCURSOR - start - 3;
@@ -1198,7 +1191,7 @@ yy79:
ZVAL_LONG(rval, parse_iv(start + 2));
return 1;
}
-#line 1202 "ext/standard/var_unserializer.c"
+#line 1195 "ext/standard/var_unserializer.c"
yy83:
yych = *++YYCURSOR;
if (yych <= '/') goto yy18;
@@ -1206,22 +1199,22 @@ yy83:
yych = *++YYCURSOR;
if (yych != ';') goto yy18;
++YYCURSOR;
-#line 574 "ext/standard/var_unserializer.re"
+#line 566 "ext/standard/var_unserializer.re"
{
*p = YYCURSOR;
ZVAL_BOOL(rval, parse_iv(start + 2));
return 1;
}
-#line 1216 "ext/standard/var_unserializer.c"
+#line 1209 "ext/standard/var_unserializer.c"
yy87:
++YYCURSOR;
-#line 568 "ext/standard/var_unserializer.re"
+#line 560 "ext/standard/var_unserializer.re"
{
*p = YYCURSOR;
ZVAL_NULL(rval);
return 1;
}
-#line 1225 "ext/standard/var_unserializer.c"
+#line 1218 "ext/standard/var_unserializer.c"
yy89:
yych = *++YYCURSOR;
if (yych <= ',') {
@@ -1244,7 +1237,7 @@ yy91:
if (yych <= '9') goto yy91;
if (yych != ';') goto yy18;
++YYCURSOR;
-#line 545 "ext/standard/var_unserializer.re"
+#line 537 "ext/standard/var_unserializer.re"
{
zend_long id;
@@ -1267,7 +1260,7 @@ yy91:
return 1;
}
-#line 1271 "ext/standard/var_unserializer.c"
+#line 1264 "ext/standard/var_unserializer.c"
yy95:
yych = *++YYCURSOR;
if (yych <= ',') {
@@ -1290,7 +1283,7 @@ yy97:
if (yych <= '9') goto yy97;
if (yych != ';') goto yy18;
++YYCURSOR;
-#line 523 "ext/standard/var_unserializer.re"
+#line 515 "ext/standard/var_unserializer.re"
{
zend_long id;
@@ -1312,9 +1305,9 @@ yy97:
return 1;
}
-#line 1316 "ext/standard/var_unserializer.c"
+#line 1309 "ext/standard/var_unserializer.c"
}
-#line 868 "ext/standard/var_unserializer.re"
+#line 860 "ext/standard/var_unserializer.re"
return 0;
diff --git a/ext/standard/var_unserializer.re b/ext/standard/var_unserializer.re
index dc72d7051b..0efd6347de 100644
--- a/ext/standard/var_unserializer.re
+++ b/ext/standard/var_unserializer.re
@@ -366,21 +366,13 @@ static inline int process_nested_data(UNSERIALIZE_PARAMETER, HashTable *ht, zend
} else {
/* object properties should include no integers */
convert_to_string(&key);
-//???
-#if 1
- data = zend_hash_update_ind(ht, Z_STR(key), &d);
-#else
- if ((data = zend_hash_find(ht, Z_STR(key))) != NULL) {
- if (Z_TYPE_P(data) == IS_INDIRECT) {
- data = Z_INDIRECT_P(data);
+ if ((old_data = zend_hash_find(ht, Z_STR(key))) != NULL) {
+ if (Z_TYPE_P(old_data) == IS_INDIRECT) {
+ old_data = Z_INDIRECT_P(old_data);
}
- zval_ptr_dtor(data);
-//??? var_push_dtor(var_hash, data);
- ZVAL_UNDEF(data);
- } else {
- data = zend_hash_update(ht, Z_STR(key), &d);
- }
-#endif
+ var_push_dtor(var_hash, old_data);
+ }
+ data = zend_hash_update_ind(ht, Z_STR(key), &d);
}
zval_dtor(&key);
diff --git a/ext/zlib/tests/gzfile_variation11.phpt b/ext/zlib/tests/gzfile_variation11.phpt
index a3585e5420..ba25bf570f 100644
--- a/ext/zlib/tests/gzfile_variation11.phpt
+++ b/ext/zlib/tests/gzfile_variation11.phpt
@@ -3,6 +3,7 @@ Test function gzfile() by substituting argument 2 with float values.
--SKIPIF--
<?php
if (!extension_loaded('zlib')) die ('skip zlib extension not available in this build');
+if (PHP_INT_SIZE != 8) die('skip 64-bit only');
?>
--FILE--
<?php
@@ -126,4 +127,4 @@ array(6) {
string(39) "and I know that it descends down on me
"
}
-===DONE=== \ No newline at end of file
+===DONE===
diff --git a/ext/zlib/tests/gzopen_variation3.phpt b/ext/zlib/tests/gzopen_variation3.phpt
index 59e45a893c..0210a75905 100644
--- a/ext/zlib/tests/gzopen_variation3.phpt
+++ b/ext/zlib/tests/gzopen_variation3.phpt
@@ -4,7 +4,8 @@ Test gzopen() function : usage variation
<?php
if (!extension_loaded("zlib")) {
print "skip - zlib extension not loaded";
-}
+}
+if (PHP_INT_SIZE != 8) die('skip 64-bit only');
?>
--FILE--
<?php
diff --git a/ext/zlib/tests/readgzfile_variation11.phpt b/ext/zlib/tests/readgzfile_variation11.phpt
index 01dc78721d..6dd9c2ff39 100644
--- a/ext/zlib/tests/readgzfile_variation11.phpt
+++ b/ext/zlib/tests/readgzfile_variation11.phpt
@@ -3,6 +3,7 @@ Test function readgzfile() by substituting argument 2 with float values.
--SKIPIF--
<?php
if (!extension_loaded('zlib')) die ('skip zlib extension not available in this build');
+if (PHP_INT_SIZE != 8) die('skip 64-bit only');
?>
--FILE--
<?php
@@ -61,4 +62,4 @@ Destiny who cares
as it turns around
and I know that it descends down on me
int(176)
-===DONE=== \ No newline at end of file
+===DONE===