diff options
| author | Scott MacVicar <scottmac@php.net> | 2011-05-10 19:09:24 +0000 |
|---|---|---|
| committer | Scott MacVicar <scottmac@php.net> | 2011-05-10 19:09:24 +0000 |
| commit | cab76530e7ccb9b20fac1f6304a09f87380563c2 (patch) | |
| tree | d31df896b071a43c4cf0136ef8d4c8dd6bdf7ee5 | |
| parent | a7dbf5a29e1b20b69f913370ab361919b4fc0006 (diff) | |
| download | php-git-cab76530e7ccb9b20fac1f6304a09f87380563c2.tar.gz | |
Turns out that more than 1% of users clocks are more than a year out of date, this causes cookies to never get deleted since the date is in the future.
I can only guess its due to batteries on the motherboard being dead.
| -rw-r--r-- | ext/standard/head.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/ext/standard/head.c b/ext/standard/head.c index 7ecf9b9ecd..edaf767463 100644 --- a/ext/standard/head.c +++ b/ext/standard/head.c @@ -115,10 +115,9 @@ PHPAPI int php_setcookie(char *name, int name_len, char *value, int value_len, t /* * MSIE doesn't delete a cookie when you set it to a null value * so in order to force cookies to be deleted, even on MSIE, we - * pick an expiry date 1 year and 1 second in the past + * pick an expiry date in the past */ - time_t t = time(NULL) - 31536001; - dt = php_format_date("D, d-M-Y H:i:s T", sizeof("D, d-M-Y H:i:s T")-1, t, 0 TSRMLS_CC); + dt = php_format_date("D, d-M-Y H:i:s T", sizeof("D, d-M-Y H:i:s T")-1, 1, 0 TSRMLS_CC); snprintf(cookie, len + 100, "Set-Cookie: %s=deleted; expires=%s", name, dt); efree(dt); } else { |