Refactoring ext/intl (incompleted)

1 files changed, 10 insertions, 5 deletions

diff --git a/ext/intl/timezone/timezone_class.h b/ext/intl/timezone/timezone_class.h
index a638f6dbf4..71de20c09e 100644
--- a/ext/intl/timezone/timezone_class.h
+++ b/ext/intl/timezone/timezone_class.h
@@ -32,8 +32,6 @@ typedef void TimeZone;
 #endif
 
 typedef struct {
-	zend_object		zo;
-
 	// 	error handling
 	intl_error		err;
 
@@ -42,8 +40,15 @@ typedef struct {
 
 	//whether to delete the timezone on object free
 	zend_bool		should_delete;
+
+	zend_object		zo;
 } TimeZone_object;
 
+static inline TimeZone_object *php_intl_timezone_fetch_object(zend_object *obj) {
+	return (TimeZone_object *)((char*)(obj) - XtOffsetOf(TimeZone_object, zo));
+}
+#define Z_INTL_TIMEZONE_P(zv) php_intl_timezone_fetch_object(Z_OBJ_P(zv))
+
 #define TIMEZONE_ERROR(to)						(to)->err
 #define TIMEZONE_ERROR_P(to)					&(TIMEZONE_ERROR(to))
 
@@ -51,7 +56,7 @@ typedef struct {
 #define TIMEZONE_ERROR_CODE_P(co)				&(INTL_ERROR_CODE(TIMEZONE_ERROR(to)))
 
 #define TIMEZONE_METHOD_INIT_VARS				INTL_METHOD_INIT_VARS(TimeZone, to)
-#define TIMEZONE_METHOD_FETCH_OBJECT_NO_CHECK	INTL_METHOD_FETCH_OBJECT(TimeZone, to)
+#define TIMEZONE_METHOD_FETCH_OBJECT_NO_CHECK	INTL_METHOD_FETCH_OBJECT(INTL_TIMEZONE, to)
 #define TIMEZONE_METHOD_FETCH_OBJECT\
 	TIMEZONE_METHOD_FETCH_OBJECT_NO_CHECK; \
 	if (to->utimezone == NULL) { \
@@ -59,8 +64,8 @@ typedef struct {
 		RETURN_FALSE; \
 	}
 
-zval *timezone_convert_to_datetimezone(const TimeZone *timeZone, intl_error *outside_error, const char *func TSRMLS_DC);
-TimeZone *timezone_process_timezone_argument(zval **zv_timezone, intl_error *error, const char *func TSRMLS_DC);
+zval *timezone_convert_to_datetimezone(const TimeZone *timeZone, intl_error *outside_error, const char *func, zval *ret TSRMLS_DC);
+TimeZone *timezone_process_timezone_argument(zval *zv_timezone, intl_error *error, const char *func TSRMLS_DC);
 
 void timezone_object_construct(const TimeZone *zone, zval *object, int owned TSRMLS_DC);