diff options
| author | Antony Dovgal <tony2001@php.net> | 2006-03-29 14:28:43 +0000 |
|---|---|---|
| committer | Antony Dovgal <tony2001@php.net> | 2006-03-29 14:28:43 +0000 |
| commit | 59b8592c8cb51599147f990ad8b61d8d02cfce05 (patch) | |
| tree | 9bf669097b48484400efe53cb52ff567c51ff8e7 /ext/mysqli/mysqli.c | |
| parent | 697c652001257e04a5af0f047017fe20f62ee969 (diff) | |
| download | php-git-59b8592c8cb51599147f990ad8b61d8d02cfce05.tar.gz | |
fix bug #36898 (__set() leaks in classes extending internal ones)
Added:
ZEND_API void zend_object_std_init(zend_object *object, zend_class_entry *ce TSRMLS_DC)
ZEND_API void zend_object_std_dtor(zend_object *object TSRMLS_DC)
to initialize and destroy zend_object structs
Diffstat (limited to 'ext/mysqli/mysqli.c')
| -rw-r--r-- | ext/mysqli/mysqli.c | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/ext/mysqli/mysqli.c b/ext/mysqli/mysqli.c index 3e369922c8..4a17ad5387 100644 --- a/ext/mysqli/mysqli.c +++ b/ext/mysqli/mysqli.c @@ -123,8 +123,9 @@ void php_clear_mysql(MY_MYSQL *mysql) { static void mysqli_objects_free_storage(zend_object *object TSRMLS_DC) { mysqli_object *intern = (mysqli_object *)object; - - zend_objects_free_object_storage(&(intern->zo) TSRMLS_CC); + + zend_object_std_dtor(&intern->zo TSRMLS_CC); + efree(intern); } /* }}} */ @@ -332,8 +333,6 @@ PHP_MYSQLI_EXPORT(zend_object_value) mysqli_objects_new(zend_class_entry *class_ intern = emalloc(sizeof(mysqli_object)); memset(intern, 0, sizeof(mysqli_object)); - intern->zo.ce = class_type; - intern->zo.guards = NULL; intern->ptr = NULL; intern->prop_handler = NULL; @@ -345,8 +344,7 @@ PHP_MYSQLI_EXPORT(zend_object_value) mysqli_objects_new(zend_class_entry *class_ zend_hash_find(&classes, mysqli_base_class->name, mysqli_base_class->name_length + 1, (void **) &intern->prop_handler); - ALLOC_HASHTABLE(intern->zo.properties); - zend_hash_init(intern->zo.properties, 0, NULL, ZVAL_PTR_DTOR, 0); + zend_object_std_init(&intern->std, class_type TSRMLS_CC); zend_hash_copy(intern->zo.properties, &class_type->default_properties, (copy_ctor_func_t) zval_add_ref, (void *) &tmp, sizeof(zval *)); |
