Merge mysqlnd_field_hash_key structure into st_mysqlnd_field.

1 files changed, 6 insertions, 16 deletions

diff --git a/ext/mysqlnd/mysqlnd_result_meta.c b/ext/mysqlnd/mysqlnd_result_meta.c
index 1db22f507d..1b2f4ddc33 100644
--- a/ext/mysqlnd/mysqlnd_result_meta.c
+++ b/ext/mysqlnd/mysqlnd_result_meta.c
@@ -87,8 +87,8 @@ MYSQLND_METHOD(mysqlnd_res_meta, read_metadata)(MYSQLND_RES_METADATA * const met
 		}
 
 		/* For BC we have to check whether the key is numeric and use it like this */
-		if ((meta->zend_hash_keys[i].is_numeric = ZEND_HANDLE_NUMERIC(field_packet.metadata->sname, idx))) {
-			meta->zend_hash_keys[i].key = idx;
+		if ((meta->fields[i].is_numeric = ZEND_HANDLE_NUMERIC(field_packet.metadata->sname, idx))) {
+			meta->fields[i].num_key = idx;
 		}
 	}
 	PACKET_FREE(&field_packet);
@@ -116,11 +116,6 @@ MYSQLND_METHOD(mysqlnd_res_meta, free)(MYSQLND_RES_METADATA * meta)
 		meta->fields = NULL;
 	}
 
-	if (meta->zend_hash_keys) {
-		DBG_INF("Freeing zend_hash_keys");
-		mnd_efree(meta->zend_hash_keys);
-		meta->zend_hash_keys = NULL;
-	}
 	DBG_INF("Freeing metadata structure");
 	mnd_efree(meta);
 
@@ -138,7 +133,6 @@ MYSQLND_METHOD(mysqlnd_res_meta, clone_metadata)(const MYSQLND_RES_METADATA * co
 	MYSQLND_RES_METADATA * new_meta = NULL;
 	MYSQLND_FIELD * new_fields;
 	MYSQLND_FIELD * orig_fields = meta->fields;
-	size_t len = meta->field_count * sizeof(struct mysqlnd_field_hash_key);
 
 	DBG_ENTER("mysqlnd_res_meta::clone_metadata");
 
@@ -153,12 +147,6 @@ MYSQLND_METHOD(mysqlnd_res_meta, clone_metadata)(const MYSQLND_RES_METADATA * co
 		goto oom;
 	}
 
-	new_meta->zend_hash_keys = mnd_emalloc(len);
-	if (!new_meta->zend_hash_keys) {
-		goto oom;
-	}
-	memcpy(new_meta->zend_hash_keys, meta->zend_hash_keys, len);
-
 	/*
 	  This will copy also the strings and the root, which we will have
 	  to adjust in the loop
@@ -180,6 +168,9 @@ MYSQLND_METHOD(mysqlnd_res_meta, clone_metadata)(const MYSQLND_RES_METADATA * co
 			new_fields[i].name_length = ZSTR_LEN(new_fields[i].sname);
 		}
 
+		new_fields[i].is_numeric = orig_fields[i].is_numeric;
+		new_fields[i].num_key = orig_fields[i].num_key;
+
 		if (orig_fields[i].org_name && orig_fields[i].org_name != mysqlnd_empty_string) {
 			new_fields[i].org_name = new_fields[i].root +
 				(orig_fields[i].org_name - orig_fields[i].root);
@@ -316,8 +307,7 @@ mysqlnd_result_meta_init(unsigned int field_count)
 		ret->field_count = field_count;
 		/* +1 is to have empty marker at the end */
 		ret->fields = mnd_ecalloc(field_count + 1, sizeof(MYSQLND_FIELD));
-		ret->zend_hash_keys = mnd_ecalloc(field_count, sizeof(struct mysqlnd_field_hash_key));
-		if (!ret->fields || !ret->zend_hash_keys) {
+		if (!ret->fields) {
 			break;
 		}
 		DBG_INF_FMT("meta=%p", ret);