summaryrefslogtreecommitdiff
path: root/ext/sockets/conversions.c
diff options
context:
space:
mode:
authorNikita Popov <nikita.ppv@gmail.com>2019-02-26 15:32:18 +0100
committerNikita Popov <nikita.ppv@gmail.com>2019-06-05 14:25:07 +0200
commita31f46421d7bf6f55dd9ac5876b8e2eacf7e0708 (patch)
tree24ffd7c5ae5e321c3994048fdd0fd9f68ae7457c /ext/sockets/conversions.c
parent528aa7932a839fc6319979c34aa372805d8dc41c (diff)
downloadphp-git-a31f46421d7bf6f55dd9ac5876b8e2eacf7e0708.tar.gz
Allow exceptions in __toString()
RFC: https://wiki.php.net/rfc/tostring_exceptions And convert some object to string conversion related recoverable fatal errors into Error exceptions. Improve exception safety of internal code performing string conversions.
Diffstat (limited to 'ext/sockets/conversions.c')
-rw-r--r--ext/sockets/conversions.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/ext/sockets/conversions.c b/ext/sockets/conversions.c
index a9f287a8ea..f24e0926ce 100644
--- a/ext/sockets/conversions.c
+++ b/ext/sockets/conversions.c
@@ -332,7 +332,10 @@ double_case:
zend_long lval;
double dval;
- convert_to_string(&lzval);
+ if (!try_convert_to_string(&lzval)) {
+ ctx->err.has_error = 1;
+ break;
+ }
switch (is_numeric_string(Z_STRVAL(lzval), Z_STRLEN(lzval), &lval, &dval, 0)) {
case IS_DOUBLE: