summaryrefslogtreecommitdiff
path: root/ext
diff options
context:
space:
mode:
authorChris Wright <daverandom@php.net>2014-08-27 16:01:18 +0100
committerChris Wright <daverandom@php.net>2014-08-27 16:01:18 +0100
commit30a73658c63a91c413305a4c4d49882fda4dab3e (patch)
treec469bb31d9c2a2729a4397b02ed0740170538c6f /ext
parent7fac56e0729385bbd2bb040f06a20a697d9de5fd (diff)
parent32be79dcfa1bc5af8682d9f512da68c5b3e2cbf3 (diff)
downloadphp-git-30a73658c63a91c413305a4c4d49882fda4dab3e.tar.gz
Merge branch 'PHP-5.4' into PHP-5.5
* PHP-5.4: Fix stream_select() issue with OpenSSL buffer Conflicts: ext/openssl/xp_ssl.c
Diffstat (limited to 'ext')
-rw-r--r--ext/openssl/xp_ssl.c13
1 files changed, 13 insertions, 0 deletions
diff --git a/ext/openssl/xp_ssl.c b/ext/openssl/xp_ssl.c
index 5fddf73c4e..79d4a09f66 100644
--- a/ext/openssl/xp_ssl.c
+++ b/ext/openssl/xp_ssl.c
@@ -881,6 +881,19 @@ static int php_openssl_sockop_cast(php_stream *stream, int castas, void **ret TS
case PHP_STREAM_AS_FD_FOR_SELECT:
if (ret) {
+ if (sslsock->ssl_active) {
+ /* OpenSSL has an internal buffer which select() cannot see. If we don't
+ fetch it into the stream's buffer, no activity will be reported on the
+ stream even though there is data waiting to be read - but we only fetch
+ the number of bytes OpenSSL has ready to give us since we weren't asked
+ for any data at this stage. This is only likely to cause issues with
+ non-blocking streams, but it's harmless to always do it. */
+ int bytes;
+ while ((bytes = SSL_pending(sslsock->ssl_handle)) > 0) {
+ php_stream_fill_read_buffer(stream, (size_t)bytes);
+ }
+ }
+
*(php_socket_t *)ret = sslsock->s.socket;
}
return SUCCESS;