summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--NEWS1
-rw-r--r--Zend/tests/generators/yield_from_greedy_parse.phpt24
-rw-r--r--Zend/zend_language_scanner.l3
3 files changed, 27 insertions, 1 deletions
diff --git a/NEWS b/NEWS
index dc8831bc88..ae0f6e096e 100644
--- a/NEWS
+++ b/NEWS
@@ -12,6 +12,7 @@ PHP NEWS
(Nikita)
. Fixed bug #74265 (Build problems after 7.0.17 release: undefined reference
to `isfinite'). (Nikita)
+ . Fixed bug #74302 (yield fromLABEL is over-greedy). (Sara)
- Date:
. Fixed bug #72096 (Swatch time value incorrect for dates before 1970). (mcq8)
diff --git a/Zend/tests/generators/yield_from_greedy_parse.phpt b/Zend/tests/generators/yield_from_greedy_parse.phpt
new file mode 100644
index 0000000000..598fb515b4
--- /dev/null
+++ b/Zend/tests/generators/yield_from_greedy_parse.phpt
@@ -0,0 +1,24 @@
+--TEST--
+yield from parses too greedily
+--FILE--
+<?php
+
+function from1234($x) {
+ return $x;
+}
+
+function bar() {
+ yield 24;
+}
+
+function foo() {
+ yield from1234(42);
+ yield from(bar());
+}
+
+foreach (foo() as $value) {
+ var_dump($value);
+}
+--EXPECT--
+int(42)
+int(24)
diff --git a/Zend/zend_language_scanner.l b/Zend/zend_language_scanner.l
index 1ac7b53a89..ff65ebd999 100644
--- a/Zend/zend_language_scanner.l
+++ b/Zend/zend_language_scanner.l
@@ -1142,7 +1142,8 @@ NEWLINE ("\r"|"\n"|"\r\n")
RETURN_TOKEN(T_RETURN);
}
-<ST_IN_SCRIPTING>"yield"{WHITESPACE}"from" {
+<ST_IN_SCRIPTING>"yield"{WHITESPACE}"from"[^a-zA-Z0-9_\x80-\xff] {
+ yyless(--yyleng);
HANDLE_NEWLINES(yytext, yyleng);
RETURN_TOKEN(T_YIELD_FROM);
}