diff options
Diffstat (limited to 'sapi/phpdbg/phpdbg_set.c')
| -rw-r--r-- | sapi/phpdbg/phpdbg_set.c | 116 | 
1 files changed, 62 insertions, 54 deletions
diff --git a/sapi/phpdbg/phpdbg_set.c b/sapi/phpdbg/phpdbg_set.c index fc7e788fa0..54269a8193 100644 --- a/sapi/phpdbg/phpdbg_set.c +++ b/sapi/phpdbg/phpdbg_set.c @@ -27,32 +27,30 @@  ZEND_EXTERN_MODULE_GLOBALS(phpdbg); -#define PHPDBG_SET_COMMAND_D(f, h, a, m, l, s, flags) \ -	PHPDBG_COMMAND_D_EXP(f, h, a, m, l, s, &phpdbg_prompt_commands[18], flags) +#define PHPDBG_SET_COMMAND_D(f, h, a, m, l, s) \ +	PHPDBG_COMMAND_D_EXP(f, h, a, m, l, s, &phpdbg_prompt_commands[18])  const phpdbg_command_t phpdbg_set_commands[] = { -	PHPDBG_SET_COMMAND_D(prompt,       "usage: set prompt [<string>]",            'p', set_prompt,       NULL, "|s", 0), +	PHPDBG_SET_COMMAND_D(prompt,       "usage: set prompt [<string>]",            'p', set_prompt,       NULL, "|s"),  #ifndef _WIN32 -	PHPDBG_SET_COMMAND_D(color,        "usage: set color  <element> <color>",     'c', set_color,        NULL, "ss", PHPDBG_ASYNC_SAFE), -	PHPDBG_SET_COMMAND_D(colors,       "usage: set colors [<on|off>]",            'C', set_colors,       NULL, "|b", PHPDBG_ASYNC_SAFE), +	PHPDBG_SET_COMMAND_D(color,        "usage: set color  <element> <color>",     'c', set_color,        NULL, "ss"), +	PHPDBG_SET_COMMAND_D(colors,       "usage: set colors [<on|off>]",            'C', set_colors,       NULL, "|b"),  #endif -	PHPDBG_SET_COMMAND_D(oplog,        "usage: set oplog  [<output>]",            'O', set_oplog,        NULL, "|s", 0), -	PHPDBG_SET_COMMAND_D(break,        "usage: set break id [<on|off>]",          'b', set_break,        NULL, "l|b", PHPDBG_ASYNC_SAFE), -	PHPDBG_SET_COMMAND_D(breaks,       "usage: set breaks [<on|off>]",            'B', set_breaks,       NULL, "|b", PHPDBG_ASYNC_SAFE), -	PHPDBG_SET_COMMAND_D(quiet,        "usage: set quiet [<on|off>]",             'q', set_quiet,        NULL, "|b", PHPDBG_ASYNC_SAFE), -	PHPDBG_SET_COMMAND_D(stepping,     "usage: set stepping [<line|op>]",         's', set_stepping,     NULL, "|s", PHPDBG_ASYNC_SAFE), -	PHPDBG_SET_COMMAND_D(refcount,     "usage: set refcount [<on|off>]",          'r', set_refcount,     NULL, "|b", PHPDBG_ASYNC_SAFE), +	PHPDBG_SET_COMMAND_D(oplog,        "usage: set oplog  [<output>]",            'O', set_oplog,        NULL, "|s"), +	PHPDBG_SET_COMMAND_D(break,        "usage: set break id [<on|off>]",          'b', set_break,        NULL, "l|b"), +	PHPDBG_SET_COMMAND_D(breaks,       "usage: set breaks [<on|off>]",            'B', set_breaks,       NULL, "|b"), +	PHPDBG_SET_COMMAND_D(quiet,        "usage: set quiet [<on|off>]",             'q', set_quiet,        NULL, "|b"), +	PHPDBG_SET_COMMAND_D(stepping,     "usage: set stepping [<line|op>]",         's', set_stepping,     NULL, "|s"), +	PHPDBG_SET_COMMAND_D(refcount,     "usage: set refcount [<on|off>]",          'r', set_refcount,     NULL, "|b"),  	PHPDBG_END_COMMAND  };  PHPDBG_SET(prompt) /* {{{ */  {  	if (!param || param->type == EMPTY_PARAM) { -		phpdbg_writeln("setprompt", "str=\"%s\"", "Current prompt: %s", phpdbg_get_prompt(TSRMLS_C)); -	} else { -		phpdbg_set_prompt(param->str TSRMLS_CC); -	} - +		phpdbg_writeln("%s", phpdbg_get_prompt(TSRMLS_C)); +	} else phpdbg_set_prompt(param->str TSRMLS_CC); +	  	return SUCCESS;  } /* }}} */ @@ -63,21 +61,21 @@ PHPDBG_SET(break) /* {{{ */  			if (param->next) {  				if (param->next->num) {  					phpdbg_enable_breakpoint(param->num TSRMLS_CC); -				} else { -					phpdbg_disable_breakpoint(param->num TSRMLS_CC); -				} +				} else phpdbg_disable_breakpoint(param->num TSRMLS_CC);  			} else {  				phpdbg_breakbase_t *brake = phpdbg_find_breakbase(param->num TSRMLS_CC);  				if (brake) { -					phpdbg_writeln("setbreak", "id=\"%ld\" active=\"%s\"", "Breakpoint #%ld %s", param->num, brake->disabled ? "off" : "on"); +					phpdbg_writeln( +						"%s", brake->disabled ? "off" : "on");  				} else { -					phpdbg_error("setbreak", "type=\"nobreak\" id=\"%ld\"", "Failed to find breakpoint #%ld", param->num); +					phpdbg_error("Failed to find breakpoint #%ld", param->num);  				}  			}  		} break;  		default: -			phpdbg_error("setbreak", "type=\"wrongargs\"", "set break used incorrectly: set break [id] <on|off>"); +			phpdbg_error( +				"set break used incorrectly: set break [id] <on|off>");  	}  	return SUCCESS; @@ -86,18 +84,18 @@ PHPDBG_SET(break) /* {{{ */  PHPDBG_SET(breaks) /* {{{ */  {  	if (!param || param->type == EMPTY_PARAM) { -		phpdbg_writeln("setbreaks", "active=\"%s\"", "Breakpoints %s",PHPDBG_G(flags) & PHPDBG_IS_BP_ENABLED ? "on" : "off"); -	} else switch (param->type) { +		phpdbg_writeln("%s", +			PHPDBG_G(flags) & PHPDBG_IS_BP_ENABLED ? "on" : "off"); +	} else switch (param->type) {	  		case NUMERIC_PARAM: {  			if (param->num) {  				phpdbg_enable_breakpoints(TSRMLS_C); -			} else { -				phpdbg_disable_breakpoints(TSRMLS_C); -			} +			} else phpdbg_disable_breakpoints(TSRMLS_C);  		} break;  		default: -			phpdbg_error("setbreaks", "type=\"wrongargs\"", "set breaks used incorrectly: set breaks <on|off>"); +			phpdbg_error( +				"set break used incorrectly: set break [id] <on|off>");  	}  	return SUCCESS; @@ -106,35 +104,41 @@ PHPDBG_SET(breaks) /* {{{ */  #ifndef _WIN32  PHPDBG_SET(color) /* {{{ */  { -	const phpdbg_color_t *color = phpdbg_get_color(param->next->str, param->next->len TSRMLS_CC); - +	const phpdbg_color_t *color = phpdbg_get_color( +			param->next->str, param->next->len TSRMLS_CC); +	  	if (!color) { -		phpdbg_error("setcolor", "type=\"nocolor\"", "Failed to find the requested color (%s)", param->next->str); +		phpdbg_error( +			"Failed to find the requested color (%s)", param->next->str);  		return SUCCESS;  	} - +	  	switch (phpdbg_get_element(param->str, param->len TSRMLS_CC)) {  		case PHPDBG_COLOR_PROMPT: -			phpdbg_notice("setcolor", "type=\"prompt\" color=\"%s\" code=\"%s\"", "setting prompt color to %s (%s)", color->name, color->code); +			phpdbg_notice( +				"setting prompt color to %s (%s)", color->name, color->code);  			if (PHPDBG_G(prompt)[1]) {  				free(PHPDBG_G(prompt)[1]);  				PHPDBG_G(prompt)[1]=NULL;  			}  			phpdbg_set_color(PHPDBG_COLOR_PROMPT, color TSRMLS_CC);  		break; - +		  		case PHPDBG_COLOR_ERROR: -			phpdbg_notice("setcolor", "type=\"error\" color=\"%s\" code=\"%s\"", "setting error color to %s (%s)", color->name, color->code); +			phpdbg_notice( +				"setting error color to %s (%s)", color->name, color->code);  			phpdbg_set_color(PHPDBG_COLOR_ERROR, color TSRMLS_CC);  		break; - +		  		case PHPDBG_COLOR_NOTICE: -			phpdbg_notice("setcolor", "type=\"notice\" color=\"%s\" code=\"%s\"", "setting notice color to %s (%s)", color->name, color->code); +			phpdbg_notice( +				"setting notice color to %s (%s)", color->name, color->code);  			phpdbg_set_color(PHPDBG_COLOR_NOTICE, color TSRMLS_CC);  		break; - +		  		default: -			phpdbg_error("setcolor", "type=\"invalidtype\"", "Failed to find the requested element (%s)", param->str); +			phpdbg_error( +				"Failed to find the requested element (%s)", param->str);  	}  	return SUCCESS; @@ -143,7 +147,7 @@ PHPDBG_SET(color) /* {{{ */  PHPDBG_SET(colors) /* {{{ */  {  	if (!param || param->type == EMPTY_PARAM) { -		phpdbg_writeln("setcolors", "active=\"%s\"", "Colors %s", PHPDBG_G(flags) & PHPDBG_IS_COLOURED ? "on" : "off"); +		phpdbg_writeln("%s", PHPDBG_G(flags) & PHPDBG_IS_COLOURED ? "on" : "off");  	} else switch (param->type) {  		case NUMERIC_PARAM: {  			if (param->num) { @@ -152,9 +156,10 @@ PHPDBG_SET(colors) /* {{{ */  				PHPDBG_G(flags) &= ~PHPDBG_IS_COLOURED;  			}  		} break; - +		  		default: -			phpdbg_error("setcolors", "type=\"wrongargs\"", "set colors used incorrectly: set colors <on|off>"); +			phpdbg_error( +				"set colors used incorrectly: set colors <on|off>");  	}  	return SUCCESS; @@ -164,7 +169,7 @@ PHPDBG_SET(colors) /* {{{ */  PHPDBG_SET(oplog) /* {{{ */  {  	if (!param || param->type == EMPTY_PARAM) { -		phpdbg_notice("setoplog", "active=\"%s\"", "Oplog %s", PHPDBG_G(oplog) ? "on" : "off"); +		phpdbg_notice("Oplog %s", PHPDBG_G(oplog) ? "enabled" : "disabled");  	} else switch (param->type) {  		case STR_PARAM: {  			/* open oplog */ @@ -172,15 +177,14 @@ PHPDBG_SET(oplog) /* {{{ */  			PHPDBG_G(oplog) = fopen(param->str, "w+");  			if (!PHPDBG_G(oplog)) { -				phpdbg_error("setoplog", "type=\"openfailure\" file=\"%s\"", "Failed to open %s for oplog", param->str); +				phpdbg_error("Failed to open %s for oplog", param->str);  				PHPDBG_G(oplog) = old;  			} else {  				if (old) { -					phpdbg_notice("setoplog", "type=\"closingold\"", "Closing previously open oplog"); +					phpdbg_notice("Closing previously open oplog");  					fclose(old);  				} - -				phpdbg_notice("setoplog", "file=\"%s\"", "Successfully opened oplog %s", param->str); +				phpdbg_notice("Successfully opened oplog %s", param->str);  			}  		} break; @@ -193,7 +197,8 @@ PHPDBG_SET(oplog) /* {{{ */  PHPDBG_SET(quiet) /* {{{ */  {  	if (!param || param->type == EMPTY_PARAM) { -		phpdbg_writeln("setquiet", "active=\"%s\"", "Quietness %s", PHPDBG_G(flags) & PHPDBG_IS_QUIET ? "on" : "off"); +		phpdbg_writeln("Quietness %s",  +			PHPDBG_G(flags) & PHPDBG_IS_QUIET ? "on" : "off");  	} else switch (param->type) {  		case NUMERIC_PARAM: {  			if (param->num) { @@ -212,15 +217,18 @@ PHPDBG_SET(quiet) /* {{{ */  PHPDBG_SET(stepping) /* {{{ */  {  	if (!param || param->type == EMPTY_PARAM) { -		phpdbg_writeln("setstepping", "type=\"%s\"", "Stepping %s", PHPDBG_G(flags) & PHPDBG_STEP_OPCODE ? "opcode" : "line"); +		phpdbg_writeln("Stepping %s", +			PHPDBG_G(flags) & PHPDBG_STEP_OPCODE ? "opcode" : "line");  	} else switch (param->type) { -		case STR_PARAM: { -			if ((param->len == sizeof("opcode") - 1) && memcmp(param->str, "opcode", sizeof("opcode")) == SUCCESS) { +		case STR_PARAM: {	 +			if ((param->len == sizeof("opcode")-1) && +				(memcmp(param->str, "opcode", sizeof("opcode")) == SUCCESS)) {  				PHPDBG_G(flags) |= PHPDBG_STEP_OPCODE; -			} else if ((param->len == sizeof("line")-1) && memcmp(param->str, "line", sizeof("line")) == SUCCESS) { +			} else if ((param->len == sizeof("line")-1) && +				(memcmp(param->str, "line", sizeof("line")) == SUCCESS)) {  				PHPDBG_G(flags) &= ~PHPDBG_STEP_OPCODE;  			} else { -				phpdbg_error("setstepping", "type=\"wrongargs\"", "usage set stepping [<opcode|line>]"); +				phpdbg_error("usage set stepping [<opcode|line>]");  			}  		} break; @@ -233,7 +241,7 @@ PHPDBG_SET(stepping) /* {{{ */  PHPDBG_SET(refcount) /* {{{ */  {  	if (!param || param->type == EMPTY_PARAM) { -		phpdbg_writeln("setrefcount", "active=\"%s\"", "Showing refcounts %s", PHPDBG_G(flags) & PHPDBG_IS_QUIET ? "on" : "off"); +		phpdbg_writeln("Refcount %s", PHPDBG_G(flags) & PHPDBG_IS_QUIET ? "on" : "off");  	} else switch (param->type) {  		case NUMERIC_PARAM: {  			if (param->num) {  | 
