From 396e9cdb7fbb4d50eee0ed1d47a1c950f1569dda Mon Sep 17 00:00:00 2001 From: Xinchen Hui Date: Fri, 16 Jan 2015 18:12:33 +0800 Subject: Optimized extract symbol table already be rebuilt.. no need use set_local_var --- ext/standard/array.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) (limited to 'ext') diff --git a/ext/standard/array.c b/ext/standard/array.c index 5662dee8ff..808992a271 100644 --- a/ext/standard/array.c +++ b/ext/standard/array.c @@ -1445,6 +1445,12 @@ PHP_FUNCTION(extract) } symbol_table = zend_rebuild_symbol_table(); +#if 0 + if (!symbol_table) { + php_error_docref(NULL, E_WARNING, "failed to build symbol table"); + return; + } +#endif ZEND_HASH_FOREACH_KEY_VAL_IND(Z_ARRVAL_P(var_array), num_key, var_name, entry) { zval final_name; @@ -1534,7 +1540,7 @@ PHP_FUNCTION(extract) } } else { if (Z_REFCOUNTED_P(entry)) Z_ADDREF_P(entry); - zend_set_local_var(Z_STR(final_name), entry, 1); + zend_hash_update_ind(&symbol_table->ht, Z_STR(final_name), entry); } count++; } -- cgit v1.2.1