From 88ba5a625c7efb1001ce90c8f4649cff830d82a4 Mon Sep 17 00:00:00 2001
From: Anatol Belski <ab@php.net>
Date: Mon, 10 Nov 2014 18:16:31 +0100
Subject: do portable socket checks

also introduced a portable macro for that
---
 sapi/cli/php_cli_server.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

(limited to 'sapi/cli/php_cli_server.c')

diff --git a/sapi/cli/php_cli_server.c b/sapi/cli/php_cli_server.c
index 19a94218ff..20e27f0bb7 100644
--- a/sapi/cli/php_cli_server.c
+++ b/sapi/cli/php_cli_server.c
@@ -556,7 +556,7 @@ static void sapi_cli_server_flush(void *server_context TSRMLS_DC) /* {{{ */
 		return;
 	}
 
-	if (client->sock < 0) {
+	if (!ZEND_VALID_SOCKET(client->sock)) {
 		php_handle_aborted_connection();
 		return;
 	}
@@ -1338,7 +1338,7 @@ out:
 		php_network_freeaddresses(sal);
 	}
 	if (err) {
-		if (retval >= 0) {
+		if (ZEND_VALID_SOCKET(retval)) {
 			closesocket(retval);
 		}
 		if (errstr) {
@@ -2186,7 +2186,7 @@ static void php_cli_server_dtor(php_cli_server *server TSRMLS_DC) /* {{{ */
 {
 	zend_hash_destroy(&server->clients);
 	zend_hash_destroy(&server->extension_mime_types);
-	if (server->server_sock >= 0) {
+	if (ZEND_VALID_SOCKET(server->server_sock)) {
 		closesocket(server->server_sock);
 	}
 	if (server->host) {
@@ -2407,7 +2407,7 @@ static int php_cli_server_do_event_for_each_fd_callback(void *_params, php_socke
 			return FAILURE;
 		}
 		client_sock = accept(server->server_sock, sa, &socklen);
-		if (client_sock < 0) {
+		if (!ZEND_VALID_SOCKET(client_sock)) {
 			char *errstr;
 			errstr = php_socket_strerror(php_socket_errno(), NULL, 0);
 			php_cli_server_logf("Failed to accept a client (reason: %s)" TSRMLS_CC, errstr);
-- 
cgit v1.2.1


From c3471cc1c9ce58a9c1dd4abbbf2dd72a760ea46b Mon Sep 17 00:00:00 2001
From: Anatol Belski <ab@php.net>
Date: Mon, 10 Nov 2014 18:20:11 +0100
Subject: cleanup unused variable

---
 sapi/cli/php_cli_server.c | 1 -
 1 file changed, 1 deletion(-)

(limited to 'sapi/cli/php_cli_server.c')

diff --git a/sapi/cli/php_cli_server.c b/sapi/cli/php_cli_server.c
index 20e27f0bb7..9612352b00 100644
--- a/sapi/cli/php_cli_server.c
+++ b/sapi/cli/php_cli_server.c
@@ -838,7 +838,6 @@ static int php_cli_server_poller_iter_on_active(php_cli_server_poller *poller, v
 		SOCKET fd;
 		int events;
 	} entries[FD_SETSIZE * 2];
-	php_socket_t fd = 0;
 	size_t i;
 	struct socket_entry *n = entries, *m;
 
-- 
cgit v1.2.1


From 940e69147ec127e44e8eb66d9bab6d3de136e4c9 Mon Sep 17 00:00:00 2001
From: Anatol Belski <ab@php.net>
Date: Mon, 10 Nov 2014 18:21:55 +0100
Subject: fix var usage only when unistd.h available

---
 sapi/cli/php_cli_server.c | 2 ++
 1 file changed, 2 insertions(+)

(limited to 'sapi/cli/php_cli_server.c')

diff --git a/sapi/cli/php_cli_server.c b/sapi/cli/php_cli_server.c
index 9612352b00..49680cede4 100644
--- a/sapi/cli/php_cli_server.c
+++ b/sapi/cli/php_cli_server.c
@@ -259,7 +259,9 @@ static php_cli_server_http_response_status_code_pair template_map[] = {
 	{ 501, "<h1>%s</h1><p>Request method not supported.</p>" }
 };
 
+#if HAVE_UNISTD_H
 static int php_cli_output_is_tty = OUTPUT_NOT_CHECKED;
+#endif
 
 static size_t php_cli_server_client_send_through(php_cli_server_client *client, const char *str, size_t str_len);
 static php_cli_server_chunk *php_cli_server_chunk_heap_new_self_contained(size_t len);
-- 
cgit v1.2.1