From d02ef65bce6575e10ac0b4e7b8552ff67687c944 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Sat, 10 Dec 2022 18:26:43 -0500 Subject: Standardize error reports in unimplemented I/O functions. We chose a specific wording of the not-implemented errors for pseudotype I/O functions and other cases where there's little value in implementing input and/or output. gtsvectorin never got that memo though, nor did most of contrib. Make these all fall in line, mostly because I'm a neatnik but also to remove unnecessary translatable strings. gbtreekey_in needs a bit of extra love since it supports multiple SQL types. Sadly, gbtreekey_out doesn't have the ability to do that, but I think it's unreachable anyway. Noted while surveying datatype input functions to see what we have left to fix. --- contrib/pg_trgm/trgm_gist.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) (limited to 'contrib/pg_trgm/trgm_gist.c') diff --git a/contrib/pg_trgm/trgm_gist.c b/contrib/pg_trgm/trgm_gist.c index 7a7be807af..3d74a1463a 100644 --- a/contrib/pg_trgm/trgm_gist.c +++ b/contrib/pg_trgm/trgm_gist.c @@ -55,15 +55,21 @@ PG_FUNCTION_INFO_V1(gtrgm_options); Datum gtrgm_in(PG_FUNCTION_ARGS) { - elog(ERROR, "not implemented"); - PG_RETURN_DATUM(0); + ereport(ERROR, + (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), + errmsg("cannot accept a value of type %s", "gtrgm"))); + + PG_RETURN_VOID(); /* keep compiler quiet */ } Datum gtrgm_out(PG_FUNCTION_ARGS) { - elog(ERROR, "not implemented"); - PG_RETURN_DATUM(0); + ereport(ERROR, + (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), + errmsg("cannot display a value of type %s", "gtrgm"))); + + PG_RETURN_VOID(); /* keep compiler quiet */ } static TRGM * -- cgit v1.2.1