From a885ecd6efc28b57b8079ae865a6a09035d1fc3d Mon Sep 17 00:00:00 2001
From: Neil Conway <neilc@samurai.com>
Date: Thu, 27 Jan 2005 23:24:11 +0000
Subject: Change heap_modifytuple() to require a TupleDesc rather than a
 Relation. Patch from Alvaro Herrera, minor editorializing by Neil Conway.

---
 src/backend/access/common/heaptuple.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

(limited to 'src/backend/access/common/heaptuple.c')

diff --git a/src/backend/access/common/heaptuple.c b/src/backend/access/common/heaptuple.c
index d60cd2a214..42643a8752 100644
--- a/src/backend/access/common/heaptuple.c
+++ b/src/backend/access/common/heaptuple.c
@@ -9,7 +9,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/access/common/heaptuple.c,v 1.95 2004/12/31 21:59:07 pgsql Exp $
+ *	  $PostgreSQL: pgsql/src/backend/access/common/heaptuple.c,v 1.96 2005/01/27 23:23:49 neilc Exp $
  *
  * NOTES
  *	  The old interface functions have been converted to macros
@@ -662,19 +662,15 @@ heap_formtuple(TupleDesc tupleDescriptor,
  *
  *		forms a new tuple from an old tuple and a set of replacement values.
  *		returns a new palloc'ed tuple.
- *
- *		XXX it is misdesign that this is passed a Relation and not just a
- *		TupleDesc to describe the tuple structure.
  * ----------------
  */
 HeapTuple
 heap_modifytuple(HeapTuple tuple,
-				 Relation relation,
+				 TupleDesc tupleDesc,
 				 Datum *replValues,
 				 char *replNulls,
 				 char *replActions)
 {
-	TupleDesc	tupleDesc = RelationGetDescr(relation);
 	int			numberOfAttributes = tupleDesc->natts;
 	int			attoff;
 	Datum	   *values;
-- 
cgit v1.2.1