From c079673dcb7f210617c9fc1470e6bf166d8a2971 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Tue, 16 May 2017 20:36:35 -0400 Subject: Preventive maintenance in advance of pgindent run. Reformat various places in which pgindent will make a mess, and fix a few small violations of coding style that I happened to notice while perusing the diffs from a pgindent dry run. There is one actual bug fix here: the need-to-enlarge-the-buffer code path in icu_convert_case was obviously broken. Perhaps it's unreachable in our usage? Or maybe this is just sadly undertested. --- src/backend/commands/publicationcmds.c | 4 +++- src/backend/commands/subscriptioncmds.c | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) (limited to 'src/backend/commands') diff --git a/src/backend/commands/publicationcmds.c b/src/backend/commands/publicationcmds.c index 14c2f68d59..1c8d88d336 100644 --- a/src/backend/commands/publicationcmds.c +++ b/src/backend/commands/publicationcmds.c @@ -493,8 +493,10 @@ OpenTableList(List *tables) rel = heap_openrv(rv, ShareUpdateExclusiveLock); myrelid = RelationGetRelid(rel); + /* - * filter out duplicates when user specifies "foo, foo" + * Filter out duplicates if user specifies "foo, foo". + * * Note that this algorithm is known to not be very efficient (O(N^2)) * but given that it only works on list of tables given to us by user * it's deemed acceptable. diff --git a/src/backend/commands/subscriptioncmds.c b/src/backend/commands/subscriptioncmds.c index 304ac842a5..b80af275da 100644 --- a/src/backend/commands/subscriptioncmds.c +++ b/src/backend/commands/subscriptioncmds.c @@ -296,6 +296,7 @@ CreateSubscription(CreateSubscriptionStmt *stmt, bool isTopLevel) /* * Parse and check options. + * * Connection and publication should not be specified here. */ parse_subscription_options(stmt->options, &connect, &enabled_given, -- cgit v1.2.1