From 7ce9b7c0d8c8dbefc04978765422f760dcf3788c Mon Sep 17 00:00:00 2001 From: Bruce Momjian Date: Mon, 1 Dec 2003 22:08:02 +0000 Subject: This patch adds a new GUC var, "default_with_oids", which follows the proposal for eventually deprecating OIDs on user tables that I posted earlier to pgsql-hackers. pg_dump now always specifies WITH OIDS or WITHOUT OIDS when dumping a table. The documentation has been updated. Neil Conway --- src/backend/executor/execMain.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) (limited to 'src/backend/executor/execMain.c') diff --git a/src/backend/executor/execMain.c b/src/backend/executor/execMain.c index 2be2d2d639..e53bb1f704 100644 --- a/src/backend/executor/execMain.c +++ b/src/backend/executor/execMain.c @@ -26,7 +26,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/executor/execMain.c,v 1.222 2003/11/29 19:51:48 pgsql Exp $ + * $PostgreSQL: pgsql/src/backend/executor/execMain.c,v 1.223 2003/12/01 22:07:58 momjian Exp $ * *------------------------------------------------------------------------- */ @@ -43,6 +43,7 @@ #include "optimizer/var.h" #include "parser/parsetree.h" #include "utils/acl.h" +#include "utils/guc.h" #include "utils/lsyscache.h" @@ -593,11 +594,12 @@ InitPlan(QueryDesc *queryDesc, bool explainOnly) do_select_into = true; /* - * For now, always create OIDs in SELECT INTO; this is for - * backwards compatibility with pre-7.3 behavior. Eventually we - * might want to allow the user to choose. + * The presence of OIDs in the result set of SELECT INTO is + * controlled by the default_with_oids GUC parameter. The + * behavior in versions of PostgreSQL prior to 7.5 is to + * always include OIDs. */ - estate->es_force_oids = true; + estate->es_force_oids = default_with_oids; } /* -- cgit v1.2.1