From 6bfe64032efd043f80a495a495331dcfc2d9f05c Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Fri, 14 Jul 2000 22:18:02 +0000 Subject: Cleanup of code for creating index entries. Functional indexes with pass-by-ref data types --- eg, an index on lower(textfield) --- no longer leak memory during index creation or update. Clean up a lot of redundant code ... did you know that copy, vacuum, truncate, reindex, extend index, and bootstrap each basically duplicated the main executor's logic for extracting information about an index and preparing index entries? Functional indexes should be a little faster now too, due to removal of repeated function lookups. CREATE INDEX 'opt_type' clause is deimplemented by these changes, but I haven't removed it from the parser yet (need to merge with Thomas' latest change set first). --- src/include/commands/vacuum.h | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) (limited to 'src/include/commands') diff --git a/src/include/commands/vacuum.h b/src/include/commands/vacuum.h index fed4c6a9a1..b42a8e6a17 100644 --- a/src/include/commands/vacuum.h +++ b/src/include/commands/vacuum.h @@ -7,17 +7,16 @@ * Portions Copyright (c) 1996-2000, PostgreSQL, Inc * Portions Copyright (c) 1994, Regents of the University of California * - * $Id: vacuum.h,v 1.31 2000/05/29 17:40:44 momjian Exp $ + * $Id: vacuum.h,v 1.32 2000/07/14 22:17:57 tgl Exp $ * *------------------------------------------------------------------------- */ #ifndef VACUUM_H #define VACUUM_H -#include "fmgr.h" -#include "access/funcindex.h" -#include "catalog/pg_index.h" #include "catalog/pg_attribute.h" +#include "catalog/pg_index.h" +#include "fmgr.h" #include "nodes/pg_list.h" #include "storage/itemptr.h" @@ -54,14 +53,6 @@ typedef struct VacPageListData typedef VacPageListData *VacPageList; -typedef struct -{ - FuncIndexInfo finfo; - FuncIndexInfo *finfoP; - Form_pg_index tform; - int natts; -} IndDesc; - typedef struct { Form_pg_attribute attr; -- cgit v1.2.1