From 0655b26282466be8cb0ffbef4f5c825f889acf4a Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Sat, 24 Jul 2004 19:51:23 +0000 Subject: log_destination should only be PGC_SIGHUP, not PGC_POSTMASTER, as per discussion yesterday. Also a few improvements in the associated documentation. --- src/backend/utils/misc/guc.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) (limited to 'src') diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c index af73fd1867..b9865462a4 100644 --- a/src/backend/utils/misc/guc.c +++ b/src/backend/utils/misc/guc.c @@ -10,7 +10,7 @@ * Written by Peter Eisentraut . * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/utils/misc/guc.c,v 1.223 2004/07/21 20:34:46 momjian Exp $ + * $PostgreSQL: pgsql/src/backend/utils/misc/guc.c,v 1.224 2004/07/24 19:51:23 tgl Exp $ * *-------------------------------------------------------------------- */ @@ -1625,8 +1625,8 @@ static struct config_string ConfigureNamesString[] = }, { - {"log_destination", PGC_POSTMASTER, LOGGING_WHERE, - gettext_noop("Sets the target for log output."), + {"log_destination", PGC_SIGHUP, LOGGING_WHERE, + gettext_noop("Sets the destination for server log output."), gettext_noop("Valid values are combinations of stderr, syslog " "and eventlog, depending on platform."), GUC_LIST_INPUT @@ -5099,15 +5099,12 @@ assign_log_destination(const char *value, bool doit, GucSource source) } } + if (doit) + Log_destination = newlogdest; + pfree(rawstring); list_free(elemlist); - /* If we aren't going to do the assignment, just return OK indicator. */ - if (!doit) - return value; - - Log_destination = newlogdest; - return value; } -- cgit v1.2.1