summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNed Batchelder <ned@nedbatchelder.com>2012-11-20 05:41:41 -0500
committerNed Batchelder <ned@nedbatchelder.com>2012-11-20 05:41:41 -0500
commit00b6dd7817da35f361a94da903367a841bfdaed0 (patch)
tree032cd7af2cea22a6f7b213ac309e5e4a598be778
parent49b594340681ae31c4a46c6279fffe90bdb55ce8 (diff)
downloadpython-coveragepy-git-00b6dd7817da35f361a94da903367a841bfdaed0.tar.gz
Silence the last of the pylint warnings.
-rw-r--r--coverage/collector.py2
-rw-r--r--coverage/parser.py4
-rw-r--r--doc/contributing.rst12
3 files changed, 6 insertions, 12 deletions
diff --git a/coverage/collector.py b/coverage/collector.py
index b8048e45..1b807b27 100644
--- a/coverage/collector.py
+++ b/coverage/collector.py
@@ -4,7 +4,7 @@ import os, sys, threading
try:
# Use the C extension code when we can, for speed.
- from coverage.tracer import CTracer
+ from coverage.tracer import CTracer # pylint: disable=F0401,E0611
except ImportError:
# Couldn't import the C extension, maybe it isn't built.
if os.getenv('COVERAGE_TEST_TRACER') == 'c':
diff --git a/coverage/parser.py b/coverage/parser.py
index 636a8353..3694b924 100644
--- a/coverage/parser.py
+++ b/coverage/parser.py
@@ -529,7 +529,7 @@ class ByteParser(object):
chunks.append(chunk)
# Give all the chunks a length.
- chunks[-1].length = bc.next_offset - chunks[-1].byte
+ chunks[-1].length = bc.next_offset - chunks[-1].byte # pylint: disable=W0631,C0301
for i in range(len(chunks)-1):
chunks[i].length = chunks[i+1].byte - chunks[i].byte
@@ -576,7 +576,7 @@ class ByteParser(object):
else:
# No chunk for this byte!
raise Exception("Couldn't find chunk @ %d" % byte)
- byte_chunks[byte] = ch
+ byte_chunks[byte] = ch # pylint: disable=W0631
if ch.line:
lines.add(ch.line)
diff --git a/doc/contributing.rst b/doc/contributing.rst
index e2882a64..23eb1adb 100644
--- a/doc/contributing.rst
+++ b/doc/contributing.rst
@@ -130,18 +130,12 @@ to possible problems::
$ make lint
pylint --rcfile=.pylintrc coverage setup.py test
- ************* Module coverage.collector
- F0401: 7,4: Unable to import 'coverage.tracer'
- E0611: 7,4: No name 'tracer' in module 'coverage'
- ************* Module coverage.parser
- W0631:532,32:ByteParser._split_into_chunks: Using possibly undefined loop variable 'bc'
- W0631:579,40:ByteParser._arcs: Using possibly undefined loop variable 'ch'
- make: [lint] Error 7 (ignored)
python -m tabnanny coverage setup.py test
python igor.py check_eol
-As you can see, a few warnings persist, don't worry about them. But clean up
-any ones you may be responsible for.
+The source is pylint-clean, even if it's because there are pragmas quieting
+some warnings. Please try to keep it that way, but don't let pylint warnings
+keep you from sending patches. I can clean them up.
Contributing