diff options
author | Ned Batchelder <ned@nedbatchelder.com> | 2021-10-30 09:28:50 -0400 |
---|---|---|
committer | Ned Batchelder <ned@nedbatchelder.com> | 2021-10-30 09:28:50 -0400 |
commit | 3d962a30a3f659978b96ef59811e8062867b358b (patch) | |
tree | e493f0e0df16849c0f45df277a1399e495433e38 /coverage/htmlfiles/coverage_html.js | |
parent | 5f20bf99f115c0227a320fa37bf7c6af44de0ce4 (diff) | |
download | python-coveragepy-git-3d962a30a3f659978b96ef59811e8062867b358b.tar.gz |
style: remove implicit string concatenation
.. and also add trailing commas where needed to remove ambiguity.
I used semgrep with this config:
```
rules:
- id: implicit-string-concatenation
pattern: |
"$X" "$Y"
languages:
- python
message: string cat BAD
severity: INFO
```
Running it showed this:
```
$ semgrep --config=../lab/string-cat.yml coverage tests doc ci igor.py setup.py __main__.py
Running 1 rules...
setup.py
severity:info rule:lab.implicit-string-concatenation: string cat BAD
128: 'https://tidelift.com/subscription/pkg/pypi-coverage'
129: '?utm_source=pypi-coverage&utm_medium=referral&utm_campaign=pypi'
tests/test_api.py
severity:info rule:lab.implicit-string-concatenation: string cat BAD
319: "!coverage.py: This is a private format, don't read it directly!"
320: '{"lines":{"/private/tmp/foo.py":[1,5,2,3]}}'
tests/test_html.py
severity:info rule:lab.implicit-string-concatenation: string cat BAD
614: ('<span class="key">if</span> <span class="num">1</span> '
615: '<span class="op"><</span> <span class="num">2</span>'),
--------------------------------------------------------------------------------
616: (' <span class="nam">a</span> '
617: '<span class="op">=</span> <span class="num">3</span>'),
--------------------------------------------------------------------------------
665: ('<span class="key">if</span> <span class="nam">x</span> '
666: '<span class="op"><</span> <span class="num">2</span>'),
--------------------------------------------------------------------------------
667: (' <span class="nam">a</span> <span class="op">=</span> '
668: '<span class="num">3</span>'),
--------------------------------------------------------------------------------
949: ('<span class="key">if</span> <span class="num">1</span> '
950: '<span class="op"><</span> <span class="num">2</span>'),
--------------------------------------------------------------------------------
951: (' <span class="nam">a</span> <span class="op">=</span> '
952: '<span class="num">3</span>'),
ran 1 rules on 134 files: 8 findings
```
This wasn't all of the instances, so I wrote a bug report: https://github.com/returntocorp/semgrep/issues/4184
Diffstat (limited to 'coverage/htmlfiles/coverage_html.js')
0 files changed, 0 insertions, 0 deletions