diff options
author | Ned Batchelder <ned@nedbatchelder.com> | 2009-12-20 11:03:33 -0500 |
---|---|---|
committer | Ned Batchelder <ned@nedbatchelder.com> | 2009-12-20 11:03:33 -0500 |
commit | 30c191f13fe5d397d1b624b4894f2c6bd841a389 (patch) | |
tree | 70fc7cc600eecfd84697c4be10556dcb3ac7263c /coverage/parser.py | |
parent | d17aeb10e55585a23702737087afc60a35d3123c (diff) | |
download | python-coveragepy-git-30c191f13fe5d397d1b624b4894f2c6bd841a389.tar.gz |
Jumps to jumps could make loops look like they go places they really don't, so start new chunks for every absolute jump. Fixes issue #39.
Diffstat (limited to 'coverage/parser.py')
-rw-r--r-- | coverage/parser.py | 15 |
1 files changed, 14 insertions, 1 deletions
diff --git a/coverage/parser.py b/coverage/parser.py index cf462181..aea05f3d 100644 --- a/coverage/parser.py +++ b/coverage/parser.py @@ -256,6 +256,11 @@ OPS_CHUNK_END = _opcode_set( 'BREAK_LOOP', 'CONTINUE_LOOP', ) +# Opcodes that unconditionally begin a new code chunk. By starting new chunks +# with unconditional jump instructions, we neatly deal with jumps to jumps +# properly. +OPS_CHUNK_BEGIN = _opcode_set('JUMP_ABSOLUTE', 'JUMP_FORWARD') + # Opcodes that push a block on the block stack. OPS_PUSH_BLOCK = _opcode_set('SETUP_LOOP', 'SETUP_EXCEPT', 'SETUP_FINALLY') @@ -399,12 +404,20 @@ class ByteParser(object): ult = penult = None for bc in ByteCodes(self.code.co_code): - # Maybe have to start a new block + # Maybe have to start a new chunk if bc.offset in bytes_lines_map: + # Start a new chunk for each source line number. if chunk: chunk.exits.add(bc.offset) chunk = Chunk(bc.offset, bytes_lines_map[bc.offset]) chunks.append(chunk) + elif bc.op in OPS_CHUNK_BEGIN: + # Jumps deserve their own unnumbered chunk. This fixes + # problems with jumps to jumps getting confused. + if chunk: + chunk.exits.add(bc.offset) + chunk = Chunk(bc.offset) + chunks.append(chunk) if not chunk: chunk = Chunk(bc.offset) |