summaryrefslogtreecommitdiff
path: root/coverage/results.py
diff options
context:
space:
mode:
authorMike Fiedler <miketheman@gmail.com>2018-12-23 20:19:39 -0500
committerNed Batchelder <ned@nedbatchelder.com>2018-12-23 22:13:53 -0500
commit9f29efdf20c5dcfe49e85cc61c0839730be2462e (patch)
tree9e9d9ed3d9db32f2b64488ac68b07d13bd84111f /coverage/results.py
parentce9194abe4c369c455cca9f1d88c25b70db031e6 (diff)
downloadpython-coveragepy-git-9f29efdf20c5dcfe49e85cc61c0839730be2462e.tar.gz
Disallow impossible values for fail_under
Since there's no way were likely to achieve greater than 100% code coverage, disallow usage of any value above 100. Resolves #743 Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Diffstat (limited to 'coverage/results.py')
-rw-r--r--coverage/results.py4
1 files changed, 4 insertions, 0 deletions
diff --git a/coverage/results.py b/coverage/results.py
index cab8796e..9be16b15 100644
--- a/coverage/results.py
+++ b/coverage/results.py
@@ -283,6 +283,10 @@ def should_fail_under(total, fail_under, precision):
Returns True if the total should fail.
"""
+ # We can never achieve higher than 100% coverage
+ if fail_under > 100.0:
+ raise ValueError("`fail_under` is greater than 100. Please use 100 or lower.")
+
# Special case for fail_under=100, it must really be 100.
if fail_under == 100.0 and total != 100.0:
return True