summaryrefslogtreecommitdiff
path: root/coverage/ctracer/tracer.c
diff options
context:
space:
mode:
Diffstat (limited to 'coverage/ctracer/tracer.c')
-rw-r--r--coverage/ctracer/tracer.c30
1 files changed, 23 insertions, 7 deletions
diff --git a/coverage/ctracer/tracer.c b/coverage/ctracer/tracer.c
index 00d9f106..f508a85d 100644
--- a/coverage/ctracer/tracer.c
+++ b/coverage/ctracer/tracer.c
@@ -174,22 +174,38 @@ static int
CTracer_record_pair(CTracer *self, int l1, int l2)
{
int ret = RET_ERROR;
-
- PyObject * t = NULL;
-
- t = Py_BuildValue("(ii)", l1, l2);
- if (t == NULL) {
+ PyObject * packed_obj = NULL;
+ long packed = 0;
+
+ // Conceptually, data is a set of tuples (l1, l2), but that literally
+ // making a set of tuples would require us to construct a tuple just to
+ // see if we'd already recorded an arc. On many-times-executed code,
+ // that would mean we construct a tuple, find the tuple is already in the
+ // set, then discard the tuple. We can avoid that overhead by packing
+ // the two line numbers into one integer instead.
+ // See collector.py:flush_data for the Python code that unpacks this.
+ if (l1 < 0) {
+ packed |= (1L << 40);
+ l1 = -l1;
+ }
+ if (l2 < 0) {
+ packed |= (1L << 41);
+ l2 = -l2;
+ }
+ packed |= (((long)l2) << 20) + (long)l1;
+ packed_obj = PyLong_FromLong(packed);
+ if (packed_obj == NULL) {
goto error;
}
- if (PySet_Add(self->pcur_entry->file_data, t) < 0) {
+ if (PySet_Add(self->pcur_entry->file_data, packed_obj) < 0) {
goto error;
}
ret = RET_OK;
error:
- Py_XDECREF(t);
+ Py_XDECREF(packed_obj);
return ret;
}